Received-SPF: pass (google.com: domain of linux-kernel+bounces-38848-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 25 Jan 2024 07:48:46 -0800
From: Luis Chamberlain <mcgrof@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russ Weight <russ.weight@linux.dev>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware_loader: introduce __free() cleanup hanler
Message-ID: <ZbKC3gLfNz301hRQ@bombadil.infradead.org>
References: <ZaeQw7VXhnirX4pQ@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZaeQw7VXhnirX4pQ@google.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>

On Wed, Jan 17, 2024 at 12:33:07AM -0800, Dmitry Torokhov wrote:
> Define cleanup handler using facilities from linux/cleanup.h to simplify
> error handling in code using firmware loader. This will allow writing code
> like this:
> 
> int driver_update_firmware(...)
> {
> 	const struct firmware *fw_entry __free(firmware) = NULL;
> 	int error;
> 
> 	...
> 	error = request_firmware(&fw_entry, fw_name, dev);
> 	if (error) {
> 		dev_err(dev, "failed to request firmware %s: %d",
> 			fw_name, error);
> 		return error;
> 	}
> 
> 	error = check_firmware_valid(fw_entry);
> 	if (error)
> 		return error;
> 
> 	guard(mutex)(&instance->lock);
> 
> 	error = use_firmware(instance, fw);
> 	if (error)
> 		return error;
> 
> 	return 0;
> }
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Acked-by: Luis Chamberalin <mcgrof@kernel.org>

  Luis