Received-SPF: pass (google.com: domain of linux-kernel+bounces-39306-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Luca Weiss <luca@z3ntu.xyz>
To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
 Bjorn Andersson <andersson@kernel.org>,
 Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 Vladimir Lypak <vladimir.lypak@gmail.com>
Subject: Re: [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset
Date: Thu, 25 Jan 2024 22:25:52 +0100
Message-ID: <2714198.mvXUDI8C0e@z3ntu.xyz>
In-Reply-To: <5192c3b1-46fd-455d-aa67-b05bf5c54e19@linaro.org>
References:
 <20240123-msm8953-mdss-reset-v1-0-bb8c6d3ce897@z3ntu.xyz>
 <20240123-msm8953-mdss-reset-v1-2-bb8c6d3ce897@z3ntu.xyz>
 <5192c3b1-46fd-455d-aa67-b05bf5c54e19@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Mittwoch, 24. J=E4nner 2024 13:10:53 CET Konrad Dybcio wrote:
> On 1/23/24 22:03, Luca Weiss wrote:
> > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >=20
> > Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953.
> >=20
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > [luca: expand commit message, move entry]
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
>=20
> I found some more definitions in lk2nd
>=20
> 88:#define  GCC_CRYPTO_BCR                    (CLK_CTL_BASE + 0x16000)
> 106:#define SDCC1_BCR                          (CLK_CTL_BASE + 0x42000) /*
> block reset*/ 125:#define SDCC2_BCR                          (CLK_CTL_BASE
> + 0x43000) /* block reset */ 150:#define USB_HS_BCR                      =
 =20
> (CLK_CTL_BASE + 0x41000) 155:#define GCC_QUSB2_PHY_BCR                =20
> (CLK_CTL_BASE + 0x4103C) 168:#define USB_30_BCR                =20
> (CLK_CTL_BASE + 0x3F070)
> 189:#define USB3_PHY_BCR                (CLK_CTL_BASE + 0x3F034)
> 190:#define USB3PHY_PHY_BCR                 (CLK_CTL_BASE + 0x3F03C)
>=20
> Couldn't find this one though, did you confirm that MDSS goes off
> when you assert it?

That one's defined here:
https://gerrit-public.fairphone.software/plugins/gitiles/kernel/msm-4.9/+/r=
efs/heads/int/13/fp3/arch/arm64/boot/dts/qcom/msm8953-mdss-pll.dtsi#21

I'll add some of the others in v2.

>=20
> Konrad