Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp242803rdb; Thu, 25 Jan 2024 14:00:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDulUqut1sfleqp4TIPKi/+KPUfJMJsbhXAZh6G7zTmO1WG2Ckh+wwJmI74v0eBAsqdZWO X-Received: by 2002:a5d:49c8:0:b0:337:c558:254f with SMTP id t8-20020a5d49c8000000b00337c558254fmr206219wrs.123.1706220028407; Thu, 25 Jan 2024 14:00:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706220028; cv=pass; d=google.com; s=arc-20160816; b=ox8aiYcM8+6wKNVafQTpTFjuWxwDgibhhgm7YoZxG4Ca8IR0GMMA5skw3Dmncbrtvm sBjslTBEyJx9qvr68i+3fTw5GHDOA40NtOmNUCvQWwvgckkQy0pnb1Qx40WvFHSkAIAE NeW8ghgz850woxRyjeXKtfRt/kQ7uF//90ZsYd/oNQXfitC98bO6xVba+8FDy2JskRVa eO61C8TjNF+OKSxtfPINMFNRZTzX/L/NmOjdo3DvDSnwO1q94kjjzdhYVIoiYGElwKaH hErxzxqaPOaTZIbR70IkQZ4++uCKgr3ykYRWzbv27wS8FpZsobagiYjSbb6dCEGax0G9 pwkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id; bh=H3UV6VJPbNgVcBkuZCXegdLtp9dedlnC1Lin+XrtCPg=; fh=tbN/kg3p9wWf1r8kzFD9LbbO3CKRUlKjN0/15ZzAVEM=; b=zzg70kYyH0hCIuQNt6CS8YWyIN3c7buP1QLIF3vNLgmbcORFNJSg9ySBpeg1VwjUx2 09r6xacC9gfB53iK67A1SyQiXCA/yXodIt62iGOZyZxXQzbQ0GLqk4mzH1BDjwDOZ8Ui 2/oU3KPHzYuIFH2ZTSL4dDRb0c8/4Mg6dzzxB8RmhuKy/rTgxHG0mmXWTFMhdQvrEEDK RJZKQCy7E7g1msOoxNkNO1TWzBSroHPaOnIYMvY+T7ey4ey5p9LwQRSU+PnvvkRzDvhl 4pXyqqa1pi067lFuuhv+BnxZCuwQplrLraqYj6Zw71bO/O+bU7nFdePXbHls8EvsO8Tp dvOw== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=perches.com); spf=pass (google.com: domain of linux-kernel+bounces-39344-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39344-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gc24-20020a170906c8d800b00a32e34b96casi533659ejb.634.2024.01.25.14.00.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 14:00:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39344-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=perches.com); spf=pass (google.com: domain of linux-kernel+bounces-39344-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39344-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 29ADF1F23F3C for ; Thu, 25 Jan 2024 22:00:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 690AC13AA4D; Thu, 25 Jan 2024 22:00:18 +0000 (UTC) Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BDD31CA89; Thu, 25 Jan 2024 22:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706220017; cv=none; b=ZZo/aETtuoE3pOMbhFpdyMVhEK/x6+M3ZTTkFxU0TQLLG2u5nFp2VFrHdeeio5wUa9+UnqFTSK5vqXmeUNFaW/j0FxjOOsXz834Fv9hmpKWGAv+C/3rU7QhuMUNu8/fdYEp2L2/NDIfsozXbf+mcqYRZgGsWcNCNrn1yJxKZvuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706220017; c=relaxed/simple; bh=RItmqS9jqdMPP9X0BIiJ7ScnCDLQTWAEQYeO6/47XXI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=B6xeIZFJIE9U9Y6bnkMfePrqfFllHCuyCwFtiw90SHV3VRo+oz2y5g4xxNpA9p/zFm5ra/N9Ckh9vPxbPaQlLTresEkksMPdbpe7mf15SCFGkonJc5mRUzOF79mNQ1GULBywIeY7eVPw0CQvuhnpA0WRmiESE7QP4QGIiZQ0vOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com Received: from omf14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 311EAA1AEA; Thu, 25 Jan 2024 21:54:18 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA id 9578F2D; Thu, 25 Jan 2024 21:54:06 +0000 (UTC) Message-ID: <443a7a529f6987eb53b8b399c0cf9375e05e993c.camel@perches.com> Subject: Re: [HID Patchsets for Samsung driver v4 2/6] HID: Samsung : Fix the checkpatch complain. Rewritten code using memcmp where applicable. From: Joe Perches To: Sandeep C S , Jiri Kosina , Benjamin Tissoires Cc: gaudium.lee@samsung.com, ih0923.kim@samsung.com, suhyun_.kim@samsung.com, jitender.s21@samsung.com, junwan.cho@samsung.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 25 Jan 2024 13:54:04 -0800 In-Reply-To: <20240125043630.4031634-3-sandeep.cs@samsung.com> References: <20240125043630.4031634-1-sandeep.cs@samsung.com> <20240125043630.4031634-3-sandeep.cs@samsung.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Rspamd-Queue-Id: 9578F2D X-Stat-Signature: netg7ytrkhf5yn7g9ss3rqtp6edq4y1x X-Rspamd-Server: rspamout01 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+/lgHE9tEIP3LCpllBaSnMinnSVYZnflU= X-HE-Tag: 1706219646-171183 X-HE-Meta: U2FsdGVkX19q5nfWT/ncDEf0UGPqNDNT0bD1dD26L+l3U0BVk/FyRVy+8f9eZWqHq5bLV82zlpvR9tuWcE6/ER7oX3p5u99J8rt2u5JESFzHamwHXOJnDSTRwcS3ucnC8NgSxPnHj22qGi49gamdUVu5oXD1Di9q5/fzr8kK5Qsu01Nb3qY6NKjQNQ+g6pq7U61pQk4Tw0XMXPNln3gkICanL/V7CsIzRZcbJ62bhjUbql1GapkB1RBmYiNEh3fW0vX/0NCSTumAXQzOWwxxINQs6B6Teso/3uwuQIzDwauNnMtYjxfljCON+NJ31W3rj1DTFkV5AvPRAdAMHiaDvM4FqwJA+kfKA7QcI6BBP0WrorFc/UPE/p+KWNXaUNU1vaHPZ7OipTbmdNi6FummXm6skyHmOvrZ5MdBowO77hxNzc3b3FTx1TAzt4OiQ1c5 On Thu, 2024-01-25 at 10:06 +0530, Sandeep C S wrote: > Resolved warnings found by checkpatch.pl script. [] > diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c > @@ -107,17 +99,39 @@ static int samsung_kbd_mouse_input_mapping(struct hi= d_device *hdev, > =20 > switch (usage->hid & HID_USAGE) { > /* report 2 */ > - case 0x183: samsung_kbd_mouse_map_key_clear(KEY_MEDIA); break; > - case 0x195: samsung_kbd_mouse_map_key_clear(KEY_EMAIL); break; > - case 0x196: samsung_kbd_mouse_map_key_clear(KEY_CALC); break; > - case 0x197: samsung_kbd_mouse_map_key_clear(KEY_COMPUTER); break; > - case 0x22b: samsung_kbd_mouse_map_key_clear(KEY_SEARCH); break; > - case 0x22c: samsung_kbd_mouse_map_key_clear(KEY_WWW); break; > - case 0x22d: samsung_kbd_mouse_map_key_clear(KEY_BACK); break; > - case 0x22e: samsung_kbd_mouse_map_key_clear(KEY_FORWARD); break; > - case 0x22f: samsung_kbd_mouse_map_key_clear(KEY_FAVORITES); break; > - case 0x230: samsung_kbd_mouse_map_key_clear(KEY_REFRESH); break; > - case 0x231: samsung_kbd_mouse_map_key_clear(KEY_STOP); break; It's rather smaller code to remove the call duplication and use a static const struct and for loop as suggested here: https://lore.kernel.org/lkml/10aeef4ddd523b85ab34327bf384119d0d4b6567.camel= @perches.com/