Received-SPF: pass (google.com: domain of linux-kernel+bounces-39342-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 25 Jan 2024 13:56:31 -0800
From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Taniya Das <quic_tdas@quicinc.com>,
        Johan Hovold
	<johan+linaro@kernel.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        "Dmitry
 Baryshkov" <dmitry.baryshkov@linaro.org>,
        Ulf Hansson
	<ulf.hansson@linaro.org>
Subject: Re: [PATCH v4 0/8] arm64: dts: qcom: sa8295p: Enable GPU
Message-ID: <20240125215631.GM2936378@hu-bjorande-lv.qualcomm.com>
References: <20240125-sa8295p-gpu-v4-0-7011c2a63037@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240125-sa8295p-gpu-v4-0-7011c2a63037@quicinc.com>

On Thu, Jan 25, 2024 at 01:05:06PM -0800, Bjorn Andersson wrote:
> Due to the different PMIC configuration found in the SA8295P platform,
> compared to SC8280XP, the VDD_GFX pads are supplied by an dedicated
> MAX20411 LDO.
> 
> Support for expressing the regulator supply is added to the binding, the
> support for enabling the parent supply for GX is added, the missing
> gfx.lvl power-domain is dropped, and the DeviceTree is wired up to
> enable the GPU in this configuration.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>

Sorry, I forgot to change the subject prefix of the rpmhpd patch, and
pick up Konrad's two r-b.

Regards,
Bjorn

> ---
> Changes in v4:
> - Updated qcom,gpucc.yaml binding check that both power-domains and
>   vdd-gfx-supply isn't used together. Updated related comment as well.
> - Link to v3: https://lore.kernel.org/r/20240123-sa8295p-gpu-v3-0-d5b4474c8f33@quicinc.com
> 
> Changes in v3:
> - Removed one unnecessary empty line in DT node
> - Rebased series to v6.8-rc1
> - Link to v2: https://lore.kernel.org/r/20231220-sa8295p-gpu-v2-0-4763246b72c0@quicinc.com
> 
> Changes in v2:
> - Made gpucc binding accept either power-domain or vdd-gfx-supply
> - Updated comment in gdsc_gx_do_nothing_enable()
> - Added a comment for the /delete-property/ power-domains
> - Fixed node and property sort order in dts
> - Switched zap firmware to use mbn file
> - Link to v1: https://lore.kernel.org/r/20231220-sa8295p-gpu-v1-0-d8cdf2257f97@quicinc.com
> 
> ---
> Bjorn Andersson (8):
>       dt-bindings: clock: qcom: Allow VDD_GFX supply to GX
>       clk: qcom: gdsc: Enable supply reglator in GPU GX handler
>       clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc
>       soc: qcom: rpmhpd: Drop SA8540P gfx.lvl
>       arm64: dts: qcom: sa8540p: Drop gfx.lvl as power-domain for gpucc
>       arm64: dts: qcom: sa8295p-adp: add max20411
>       arm64: dts: qcom: sa8295p-adp: Enable GPU
>       arm64: defconfig: Enable MAX20411 regulator driver
> 
>  .../devicetree/bindings/clock/qcom,gpucc.yaml      |  9 +++
>  arch/arm64/boot/dts/qcom/sa8295p-adp.dts           | 68 ++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sa8540p.dtsi              |  3 +
>  arch/arm64/configs/defconfig                       |  1 +
>  drivers/clk/qcom/gdsc.c                            | 12 +++-
>  drivers/clk/qcom/gpucc-sc8280xp.c                  |  1 +
>  drivers/pmdomain/qcom/rpmhpd.c                     |  1 -
>  7 files changed, 92 insertions(+), 3 deletions(-)
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20231220-sa8295p-gpu-51c5f343e3ec
> 
> Best regards,
> -- 
> Bjorn Andersson <quic_bjorande@quicinc.com>
>