Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp263713rdb; Thu, 25 Jan 2024 14:51:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEg08dCRV4w1NkH7bdJkwK8lG3RHxsXvXNasZrvH1kMy1J/UzM+A6+eCYfIiE68lwREN16K X-Received: by 2002:a05:6a00:2d01:b0:6d9:aaef:89a7 with SMTP id fa1-20020a056a002d0100b006d9aaef89a7mr519547pfb.10.1706223073336; Thu, 25 Jan 2024 14:51:13 -0800 (PST) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id g9-20020a056a000b8900b006dddfdd0fe0si51511pfj.121.2024.01.25.14.51.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 14:51:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=VO+BhBcB; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-39362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39362-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 21E10B2562A for ; Thu, 25 Jan 2024 22:35:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 108081118A; Thu, 25 Jan 2024 22:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VO+BhBcB" Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 924621118E for ; Thu, 25 Jan 2024 22:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706222103; cv=none; b=AnLca/0nbzmkL4bknKF2NNK0lCwTtv++34OSVTQwCe+CmaJMiMr3WziNn/nSusraRaaNTqJvBViJvUy6mMESl2waWxePXI1BZPWaxJhv/Yb+q8fgtObH05aCs8mIFk3xVyjMQZfrzUxukT5D63FD3ZPZQLtvXq4KRz016PUqDR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706222103; c=relaxed/simple; bh=PWubl/XtYBpas/AdivCCWYMQQNqPtjT7WZPtVgnZW+E=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=s4cKE/1d7EW8QhOKtB8x+yYC2zmqsthtTcmvq+KAapH5Yy4WwbIZZr2AG77Tp2dKThltleFpFO39Rz1tf+YCn9rn23h4cThYoDn1hfYUxUrJNeP9l1XzSQ3L01kGsItIlI2Bg72M8DcG6agtz5Nr3WZWtbyj6dFjXNUfhqTwvng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VO+BhBcB; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6da9c834646so26692b3a.3 for ; Thu, 25 Jan 2024 14:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706222101; x=1706826901; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+Eb0c3haY7NyGtB+8UjAu5Wtfyd5HZxv9SnvbZwJOFM=; b=VO+BhBcBfOPmcG1cPgDAU5nnE9lVBnxh4uTePyfceSP+NDbNp+77ub6+WkdDe2IWGh //oOTFgFYLmVobOMyrt3vO+Fp9VefZ7ZC/Y07TKGM+0vDiL05geJOKM0DtKiOlzcq97q ig1UYrbMCjq3bDQCUt6bTIgqmidkKMkzVvb8wMvNd+52YMdTDhRBJLB66eygo9dZJnZy 1pHmHEsshFa1TViFRsy+va8Qi8aAKLFoER0dYXy85NZpYa4zvdmRTykZNxtxNCX/Tf6D oPpxwPMmQEsEWrhoPphPT+zmUd27avLnH+OnK8HJGY4uANbt3drRJkNwK1qnzwtxZGvN UBfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706222101; x=1706826901; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Eb0c3haY7NyGtB+8UjAu5Wtfyd5HZxv9SnvbZwJOFM=; b=SU2J4J+WpcvV97/WeXhT4YHjL1LJrY0+fs45oZnQKKWlm9EhhK/JXxewbTz2P/F6T/ CXtz+6BPnK2G50TTzPgViDLyxis2Rp7nqbQa2e/xldhdSAjYupOxAlxjThi7v9HnwFxn rzVfExKpn/vQuQ+trjV2n25pJl7rtd/cFiUDxr2JjDtTxDWRWj3OtLb/GDAAMbu2q1Bx MxXlMnoA9JoxPd7RYi3qnFLmBwP7DDJ1nJkHhLOPygFYWnnxTHcOXSEmyQZv1B1cgAUV dVMSzJBZH6lN3VzyAI3RraXkuzV1maAD9YKpGeWSSsw9imMUQPpcw5aXlHmHLTZyL0Qn tWKQ== X-Gm-Message-State: AOJu0YwgjiCa27R/3LGw8V86xZubY/RE6RIGue75E7R2EUzGjlMS0qqy 9p9fFRkbg3T8vcqWSHSTVATPtUiIwsOv5JocG70pGDm6OfHBwS3yO4g0HRwe9wIwGb17POAjr1s 141yFC1i2WAAlMpuGXNDSJIl7fHeNVI9HNtXI8w== X-Received: by 2002:a05:6a20:2453:b0:19a:66a4:7966 with SMTP id t19-20020a056a20245300b0019a66a47966mr509176pzc.55.1706222100868; Thu, 25 Jan 2024 14:35:00 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240123153421.715951-1-tudor.ambarus@linaro.org> <7c998d34-919b-46e7-8942-75da94d5ac21@linaro.org> In-Reply-To: From: Sam Protsenko Date: Thu, 25 Jan 2024 16:34:49 -0600 Message-ID: Subject: Re: [PATCH 00/21] spi: s3c64xx: winter cleanup and gs101 support To: Tudor Ambarus Cc: Mark Brown , arnd@arndb.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Andi Shyti Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 25, 2024 at 4:25=E2=80=AFPM Andi Shyti = wrote: > > Hi Tudor, > > > >> The patch set cleans a bit the driver and adds support for gs101 SPI= . > > >> > > >> Apart of the SPI patches, I added support for iowrite{8,16}_32 acces= sors > > >> in asm-generic/io.h. This will allow devices that require 32 bits > > >> register accesses to write data in chunks of 8 or 16 bits (a typical= use > > >> case is SPI, where clients can request transfers in words of 8 bits = for > > >> example). GS101 only allows 32bit register accesses otherwise it rai= sses > > >> a Serror Interrupt and hangs the system, thus the accessors are need= ed > > >> here. If the accessors are fine, I expect they'll be queued either t= o > > >> the SPI tree or to the ASM header files tree, but by providing an > > >> immutable tag, so that the other tree can merge them too. > > >> > > >> The SPI patches were tested with the spi-loopback-test on the gs101 > > >> controller. > > > > > > The reformatting in this series will conflict with the SPI changes in= : > > > > > > https://lore.kernel.org/r/20240120012948.8836-1-semen.protsenko@li= naro.org > > > > > > Can you please pull those into this series or otherwise coordinate? > > > > ah, I haven't noticed Sam's updates. I'll rebase on top of his set and > > adapt if necessary. I'll review that set in a sec. > > it's a long series, please give it a few days before resending > it. > Also, I recommend splitting it up in a way I suggested before: 1. First add gs101 support with minimal amount of patches (without fifosize introduction, etc) 2. Then do all those cleanups and reworks on top of that The reason why I think it's better than doing that vice-versa is that I feel (2) can take a lot of time/review rounds to get polished and accepted. So this way you can make sure gs101 support gets applied sooner. It'll also make it easier to do the backporting work later, if that's ever needed. > Thanks, > Andi