Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp277041rdb; Thu, 25 Jan 2024 15:22:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzNGRmLNsCDS/d+tpMhCsMgbH+jEpk1W2YCHQ6Oo5M2kNqZ+A3M0XJ/XsidsPJhJq3EaM9 X-Received: by 2002:ac8:7d15:0:b0:42a:54cb:32c8 with SMTP id g21-20020ac87d15000000b0042a54cb32c8mr508109qtb.85.1706224922277; Thu, 25 Jan 2024 15:22:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706224922; cv=pass; d=google.com; s=arc-20160816; b=YwwcVnXMR+7hVjRRIwmoxsNRxxAQxIOqRsv71hon92Aed2B9zq4RrHr+JPkynPae9A iyomNyc6ax99ZBXS+L2nuLt5xyVf797cjCdz3epELx4bO19tuBl+jykYKIis6SNpSp3U ByIIUiltFdJuBXcXGQ6v9HeEOvC4qRD5dYDzxQCiag0gx8/+8WUKfDgIVO1+WahqIpeK MxMBuPMFGBxyw6KlWQhLEdIdbLJxp7FdLMszpNLMQn6ZDB+v86X3fXQSRFAJ7DzzjJy+ R+L0SoXE0TXXLbpkhKogK0aX9l5MTHIam01Hdb5oPn52Hh+HsbmE2Gvipgy65M+OPuBn iWYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5p/WqjirjBt2GNKb14k5KYDpiDYijG3aEmvVmVKoWb0=; fh=/KzSCYo0ATKYQ8eqkLNwiYH9CmT2qaa1DaO1/JhgZ+Y=; b=Rnoi2x1k5Xn+kJ251kvyW1A2IRJtq5hyJzlgmzlV74s4tSDRmiprfZxC52Lk8N6Qpy 03LYwswyzA2KQwfN2m6H6Uiwe5dBOQtUEHLSC0+RJaEVxGdbdMC9JRuYXauvaCkyt2jV WZrC5ZElET43TGKH14CFUSNWDqUDbzSD9Wjct5IfhaERbpKFUDrjgCWAn8kvOpjXCHOo pHDz97EAtDYkBtQ8Uhk6uPv6xJXLtLoG+pjNdEt004ngOy8apOecAUeAZdow0qgsOlsn +O1bVn0Vtzd9t0vtw6tftsc6xcuG6s4LtIRZeDH609uOA8ar89YodBrtdmLd6zp22ImX kmlg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mmh748ud; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-39410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39410-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v17-20020a05622a015100b0042a648cbbdasi3794876qtw.272.2024.01.25.15.22.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 15:22:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mmh748ud; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-39410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39410-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EE17B1C22B3B for ; Thu, 25 Jan 2024 23:22:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A476D134C7; Thu, 25 Jan 2024 23:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mmh748ud" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5CE1125C8; Thu, 25 Jan 2024 23:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224907; cv=none; b=XpGBGNI1vaLr5f//ijC4uZIbuODSqzgjKLX3IRfHJkhNcKKz9PlUGhNX/TXLZdueWbP52tl1yYlBQlHd8SLnRf+mCTk6F4rjN0eKMBVCByh8g4KyyydPGIqWAQYcbUU99yVksmqyAJieEO0+/kEYYePn9Abo6dwNCLDctSyNfHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224907; c=relaxed/simple; bh=guOzA7K6RUgZ5DDnCdKRtRAA0JyuY3NLLW25sX22Xag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lSG0rjoY2ekWMQ4ZfoeHgEUYKTzxiDWwEEpxNO7ozomI/XP8KQOmad/71+G8x9psRYpZfO69VyF0+c5O7aR4FLkApGQX2ynLBaaEeO5GFaRwyjhWhbuoC8pW6+n6X8pqo8rNEf/6TCJozEaS+0uTMJOuNsoqTt0jZqn6aCI9vSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mmh748ud; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C0D5C433F1; Thu, 25 Jan 2024 23:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706224907; bh=guOzA7K6RUgZ5DDnCdKRtRAA0JyuY3NLLW25sX22Xag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mmh748ud3Gbon2Ah/b3OsL3op+RJWgcz/46gD1rs+N4tL7aFMhUVtB35T6Q7ZkZLk MyK6EXm41JZzMkPYFIg8S4J/tJrO6Y8wOMWcqJ3AJKkKDEXINxS8IJocZvjfXwOGkc ZeIjPEfvazV/u8gDk26Xz1/ly4mTgfFP5peIqDUU= Date: Thu, 25 Jan 2024 15:21:46 -0800 From: Greg Kroah-Hartman To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, kuba@kernel.org, willemdebruijn.kernel@gmail.com, weiwan@google.com, Jonathan Corbet , Alexander Viro , Jan Kara , Michael Ellerman , Nathan Lynch , Steve French , Thomas Zimmermann , Jiri Slaby , Julien Panis , Arnd Bergmann , Andrew Waterman , Thomas Huth , Palmer Dabbelt , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH net-next v3 3/3] eventpoll: Add epoll ioctl for epoll_params Message-ID: <2024012551-anyone-demeaning-867b@gregkh> References: <20240125225704.12781-1-jdamato@fastly.com> <20240125225704.12781-4-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240125225704.12781-4-jdamato@fastly.com> On Thu, Jan 25, 2024 at 10:56:59PM +0000, Joe Damato wrote: > +struct epoll_params { > + u64 busy_poll_usecs; > + u16 busy_poll_budget; > + > + /* for future fields */ > + u8 data[118]; > +} EPOLL_PACKED; variables that cross the user/kernel boundry need to be __u64, __u16, and __u8 here. And why 118? thanks, greg k-h