Received-SPF: pass (google.com: domain of linux-kernel+bounces-39451-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Sai Krishna <saikrishnag@marvell.com>, richardcochran@gmail.com,
 davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, sgoutham@marvell.com, gakula@marvell.com,
 lcherian@marvell.com, hkelam@marvell.com, sbhatta@marvell.com
Cc: Sai Krishna <saikrishnag@marvell.com>, Naveen Mamindlapalli
 <naveenm@marvell.com>
Subject: Re: [net-next PATCH] octeontx2: Add PTP clock driver for Octeon PTM
 clock.
In-Reply-To: <20240124064156.2577119-1-saikrishnag@marvell.com>
References: <20240124064156.2577119-1-saikrishnag@marvell.com>
Date: Thu, 25 Jan 2024 16:11:02 -0800
Message-ID: <87h6j154yx.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Sai Krishna <saikrishnag@marvell.com> writes:

> The PCIe PTM(Precision time measurement) protocol provides precise
> coordination of events across multiple components like PCIe host
> clock, PCIe EP PHC local clocks of PCIe devices. This patch adds
> support for ptp clock based PTM clock. We can use this PTP device
> to sync the PTM time with CLOCK_REALTIME or other PTP PHC
> devices using phc2sys.
>
> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> ---

I can see that the same device id (PCI_DEVID_OCTEONTX2_PTP) is used by a
ethernet driver.

That brings me a question: why expose a different PTP chardev? In other
words, why can't you just implement .getcrosststamp() for that ethernet
device?


Cheers,
-- 
Vinicius