Received-SPF: pass (google.com: domain of linux-kernel+bounces-39460-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 26 Jan 2024 09:32:57 +0900
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com,
 kernel-team@android.com
Subject: Re: [PATCH v12 3/6] tracing: Add snapshot refcount
Message-Id: <20240126093257.b6059a4c4fa1b1d345132350@kernel.org>
In-Reply-To: <ZbJ19CF2Zv4d0R_Z@google.com>
References: <20240123110757.3657908-1-vdonnefort@google.com>
	<20240123110757.3657908-4-vdonnefort@google.com>
	<20240125001149.364c0b08237e8b7f0a69bd56@kernel.org>
	<ZbJ19CF2Zv4d0R_Z@google.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Vincent,

On Thu, 25 Jan 2024 14:53:40 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:

> > > @@ -1470,12 +1483,20 @@ register_snapshot_trigger(char *glob,
> > >  			  struct event_trigger_data *data,
> > >  			  struct trace_event_file *file)
> > >  {
> > > -	if (tracing_alloc_snapshot_instance(file->tr) != 0)
> > > +	if (tracing_arm_snapshot(file->tr))
> > >  		return 0;
> > 
> > BTW, is this return value correct? It seems that the register_*_trigger()
> > will return error code when it fails.
> 
> It should indeed be 
> 
>  ret = tracing_arm_snapshot()
>  if (ret)
>      return ret;

OK, then there is a bug. We need to fix it before changing this
for backporting.

Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>