Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp324852rdb; Thu, 25 Jan 2024 17:23:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAv5To2nT1/RCre5tgkeGzCAQiNmeZ74treTwm9dWzPUjhpTn3WX7I+yN/Kukd9Z69p5/G X-Received: by 2002:a6b:680d:0:b0:7bf:b561:b97b with SMTP id d13-20020a6b680d000000b007bfb561b97bmr838326ioc.1.1706232200635; Thu, 25 Jan 2024 17:23:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706232200; cv=pass; d=google.com; s=arc-20160816; b=jd5LFEQnkO1JRkHNZ1BScXOcd5IPDJA0dTj/9oP5iqx3k70DfEvA1qePpAaUUFeCUB W2VKa/rT1GulmK0WUDP/Gw2EzHj8TOmzyWmDrJRrFfZ8Zv9dnc1ZzQqL/BM1y8krfkqz vWIu5DY1VF01JK/wqnoYAWUFnXP4S0geSK4+jtllaQvDLV6FNEQwtlGRmGikb664qRgf 4I8DRvpjUknSEKb/hK/4Hvj1VRh+WedVmQYej9ykJZYDVYJBxSyKlFI/+Ik6ZuOMk2mF UqFXSSnckAptUG1cQOb+v2RQiyjUHjZVQv4Unwuo38FnWjgvSmnH0YnWwd913t9ptxbC apqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=uGWLDl2OUOpMvYBSd1HHOEKIHx0gIBUL8DZMOC35Dx8=; fh=7iX86AFizLgo68XDjMJcUUr/3PxlxiziG60BVFaJqVA=; b=jcQcIUvU7Sv9OMGB8dZLui0mVeN9MA4V+850rxzeOAGUbS0uGx/gwy4uBUJwFDmkfl w5WuVuqw7RINDAwoppgUCORxT0ZJSO17/DFsklXFu9YjOmPNT/xT1G93uyIBgUmcwjo1 zQd5L2Rw6MJn+bkhKJSiAWdBJFjs9EmHK+GZmM1mVRj1UEhEypV+JjiFBNAjk5aSW8N7 nz4sMd4KX79qkAMxg5cLzObyeGKabWNVCLiQQHW2Arvp9Rh1mi4JExS5CKlU7nuvqm73 PgI291aWopAB/TCmceLWmc/Cv/EnGeoJ2hNFWMcPFgbAx/pxKJTXVRyS1EdKzxRb9Eh4 9+Fg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QbX2GfKh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-39490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39490-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s17-20020a63ff51000000b005d42e7a9195si196927pgk.713.2024.01.25.17.23.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 17:23:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QbX2GfKh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-39490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39490-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D5DE728F619 for ; Fri, 26 Jan 2024 01:23:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 73EA51115; Fri, 26 Jan 2024 01:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QbX2GfKh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DBD710E9; Fri, 26 Jan 2024 01:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706232175; cv=none; b=oZ4ko+f8TSRk3fkHzZ9fiZ4Lqin18mOe6Ip0ASLfHsqTb6mtzGvex1vdsDm69v+WOtR8U+V4pvjja6YKggBiqtq2GVTsZXZ/vPz0dnfLR+OQyAxplCD6IRjS8nkmMn1la+XI5qpKA6TiHOWtvWqPoWsgoKc4k5CakR2BdzQp75E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706232175; c=relaxed/simple; bh=Hk9/gpwL/FH2xmnit/2UJvfVqasuwOB//G3xIDeSRXY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PVoQmIGTHsm3tJcBnrVgYPpQCXIRktMxIGRIsgxonkwP4gmhp9OjUQNEboJdLNSffxpFMs5Hg+yWFEgG9CUXtoxAfyQoP9HfzDjV2HiRplSdhWmZ79qBMxGsAqFLNpjqpX1fPFhm18PKjeJ+Lc22BmKke98yv7cysKUB2REOD8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QbX2GfKh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3997C433C7; Fri, 26 Jan 2024 01:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706232175; bh=Hk9/gpwL/FH2xmnit/2UJvfVqasuwOB//G3xIDeSRXY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QbX2GfKhc5hZC6h46CHXmhCNSbMB8gJ/J4nLe6qNyA1qja9Bx/1+7GMkkTu7Vrkqo 2B1vx1tOGSpm3V8/KYFG+mBy621FwOkM5v5A6zENUMsqvkzEJLgMfZ/HNq664U8tkP Nr4prtIK2SqWcBWyaxLsUhZlvjwcVKkki/Q4vBkuCUsOgMMy4HqX5xPpxEECJly+aA D3N2ZmkRivt4zCmOGAHEVuKM27BJGqiVonKPbSuqcpcf3eztESC17H/FzAlpdGT4wL 8qEN1M9Os2zV8uf7+5rAddkolgppNsYnFmpbp2TJIesGiMlXOl4MCg/9td0zCyC+UL ZL8+JdfmnpD4g== Date: Thu, 25 Jan 2024 17:22:53 -0800 From: Jakub Kicinski To: Esben Haabendal Cc: netdev@vger.kernel.org, Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings Message-ID: <20240125172253.3fe50cfc@kernel.org> In-Reply-To: <5606bb5f0b7566a20bb136b268dae89d22a48898.1706184304.git.esben@geanix.com> References: <5606bb5f0b7566a20bb136b268dae89d22a48898.1706184304.git.esben@geanix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 25 Jan 2024 13:34:34 +0100 Esben Haabendal wrote: > + for (int i = 0; i < plat_dat->tx_queues_to_use; i++) { > + /* Default TX Q0 to use TSO and rest TXQ for TBS */ > + if (i > 0) > + plat_dat->tx_queues_cfg[i].tbs_en = 1; > + } checkpatch points out this code is indented with spaces. Please use tabs.