Received-SPF: pass (google.com: domain of linux-kernel+bounces-39494-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 25 Jan 2024 17:28:03 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
 <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
 <sgoutham@marvell.com>, <gakula@marvell.com>, <hkelam@marvell.com>,
 <sbhatta@marvell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Reset MAC stats during probe
Message-ID: <20240125172803.01189ac4@kernel.org>
In-Reply-To: <20240125110601.124209-1-saikrishnag@marvell.com>
References: <20240125110601.124209-1-saikrishnag@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 25 Jan 2024 16:36:01 +0530 Sai Krishna wrote:
> Reset CGX/RPM MAC HW statistics at the time of driver probe()
> 
> Also added a devlink option to do the same at runtime, this will be
> helpful during debug.
> 
> Usage: Reset MAC stats
> devlink dev param  set  pci/0002:03:00.0 name mac_stats_reset value true
> cmode runtime

Where are the stats reported? It'd be more intuitive to add the ability
to reset stats to whatever interface is used to report them. Or one of
your reset interfaces (devlink dev reload).