Received-SPF: pass (google.com: domain of linux-kernel+bounces-39498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 25 Jan 2024 17:34:48 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Potapenko <glider@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 kasan-dev@googlegroups.com, Marco Elver <elver@google.com>, Dmitry Vyukov
 <dvyukov@google.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Nicholas
 Miehlbradt <nicholas@linux.ibm.com>
Subject: Re: [PATCH v2] mm: kmsan: remove runtime checks from
 kmsan_unpoison_memory()
Message-Id: <20240125173448.e866d84cda146145cbc67c93@linux-foundation.org>
In-Reply-To: <20240124173134.1165747-1-glider@google.com>
References: <20240124173134.1165747-1-glider@google.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Jan 2024 18:31:34 +0100 Alexander Potapenko <glider@google.com> wrote:

> Similarly to what's been done in commit ff444efbbb9be ("kmsan: allow

I make that 85716a80c16d.

> using __msan_instrument_asm_store() inside runtime"), it should be safe
> to call kmsan_unpoison_memory() from within the runtime, as it does not
> allocate memory or take locks. Remove the redundant runtime checks.
> 
> This should fix false positives seen with CONFIG_DEBUG_LIST=y when
> the non-instrumented lib/stackdepot.c failed to unpoison the memory
> chunks later checked by the instrumented lib/list_debug.c
> 
> Also replace the implementation of kmsan_unpoison_entry_regs() with
> a call to kmsan_unpoison_memory().
> 

"false positives" sound unpleasant.  Should this fix be backported into
earlier kernels?  And can we identify a suitable Fixes: target?