Received-SPF: pass (google.com: domain of linux-kernel+bounces-39522-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <13890cb8-c454-49d6-af55-c274fa2ef025@kylinos.cn>
Date: Fri, 26 Jan 2024 09:58:37 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] powerpc/cell: Code cleanup for spufs_mfc_flush
Content-Language: en-US
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
 "jk@ozlabs.org" <jk@ozlabs.org>, "arnd@arndb.de" <arnd@arndb.de>,
 "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
 "npiggin@gmail.com" <npiggin@gmail.com>,
 "aneesh.kumar@kernel.org" <aneesh.kumar@kernel.org>,
 "naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20240125100854.540964-1-chentao@kylinos.cn>
 <c34968b8-f6bf-4ee1-8767-ef463637d866@csgroup.eu>
From: Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <c34968b8-f6bf-4ee1-8767-ef463637d866@csgroup.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 2024/1/25 18:41, Christophe Leroy wrote:
>=20
>=20
> Le 25/01/2024 =C3=A0 11:08, Kunwu Chan a =C3=A9crit=C2=A0:
>> This part was commented from commit a33a7d7309d7
>> ("[PATCH] spufs: implement mfc access for PPE-side DMA")
>> in about 18 years before.
>>
>> If there are no plans to enable this part code in the future,
>> we can remove this dead code.
>>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>>    arch/powerpc/platforms/cell/spufs/file.c | 12 ------------
>>    1 file changed, 12 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/p=
latforms/cell/spufs/file.c
>> index 02a8158c469d..d5e1af483601 100644
>> --- a/arch/powerpc/platforms/cell/spufs/file.c
>> +++ b/arch/powerpc/platforms/cell/spufs/file.c
>> @@ -1705,19 +1705,7 @@ static int spufs_mfc_flush(struct file *file, f=
l_owner_t id)
>>    	ret =3D spu_acquire(ctx);
>>    	if (ret)
>>    		goto out;
>> -#if 0
>> -/* this currently hangs */
>> -	ret =3D spufs_wait(ctx->mfc_wq,
>> -			 ctx->ops->set_mfc_query(ctx, ctx->tagwait, 2));
>> -	if (ret)
>> -		goto out;
>> -	ret =3D spufs_wait(ctx->mfc_wq,
>> -			 ctx->ops->read_mfc_tagstatus(ctx) =3D=3D ctx->tagwait);
>> -	if (ret)
>> -		goto out;
>> -#else
>>    	ret =3D 0;
>=20
Thanks for your reply.
> If you arrived here, it means ret is already 0, otherwise you would hav=
e
> jumped to label out:, so you can also remove that ret =3D 0 setting.
>=20
I'm patronizing the removal of useless code, it's my bad.
> And while you are at it, there is no point in a goto to just a return,
> just return instead of the goto, and then you can return 0 directly,
> something like:
>=20
> 	ret =3D spu_acquire(ctx);
> 	if (ret)
> 		return ret;
>=20
> 	spu_release(ctx);
>=20
> 	return 0;
>=20
>=20
> That would be a better cleanup.
Thanks for your suggestions,i'll update in v2 and add a 'Suggested-by:'.
>=20
>> -#endif
>>    	spu_release(ctx);
>>    out:
>>    	return ret;
--=20
Thanks,
   Kunwu