Received-SPF: pass (google.com: domain of linux-kernel+bounces-39717-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <1b42866bb6f05b7d68e9b8304e42359fccdf2bad.camel@gmail.com>
Subject: Re: [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>, Ibrahim Tilki
 <Ibrahim.Tilki@analog.com>, "a.zummo@towertech.it" <a.zummo@towertech.it>, 
 "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
 "jdelvare@suse.com" <jdelvare@suse.com>,  "linux@roeck-us.net"
 <linux@roeck-us.net>, "robh+dt@kernel.org" <robh+dt@kernel.org>, 
 "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org"
	 <linux-kernel@vger.kernel.org>, "linux-hwmon@vger.kernel.org"
	 <linux-hwmon@vger.kernel.org>, "devicetree@vger.kernel.org"
	 <devicetree@vger.kernel.org>
Date: Fri, 26 Jan 2024 08:51:39 +0100
In-Reply-To: <147c92f9-b42b-4a51-a6f9-2d90bfe63aa0@alliedtelesis.co.nz>
References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com>
	 <147c92f9-b42b-4a51-a6f9-2d90bfe63aa0@alliedtelesis.co.nz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-01-26 at 02:22 +0000, Chris Packham wrote:
> Hi All,
>=20
> On 4/04/23 03:43, Ibrahim Tilki wrote:
> > changelog:
> > since v5:
> > =C2=A0=C2=A0 - dt-binding: add enum value "2" to aux-voltage-chargable
> > =C2=A0=C2=A0 - dt-binding: remove adi,trickle-diode-enable
> > =C2=A0=C2=A0 - dt-binding: change description of trickle-resistor-ohms
> > =C2=A0=C2=A0 - dt-binding: reorder as in example schema
> > =C2=A0=C2=A0 - parse "wakeup-source" when irq not requested
> > =C2=A0=C2=A0 - remove limitation on max31328 irq and clokout
> > =C2=A0=C2=A0 - remove error and warning messages during trickle charger=
 setup
> >=20
> > since v4:
> > =C2=A0=C2=A0 - dt-binding: remove interrupt names.
> > =C2=A0=C2=A0 - dt-binding: add description for "interrupts" property
> > =C2=A0=C2=A0 - dt-binding: replace deprecated property "trickle-diode-d=
isable"
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 by "aux-voltage-chargeable"
> > =C2=A0=C2=A0 - dt-binding: add new property "adi,trickle-diode-enable"
> > =C2=A0=C2=A0 - dt-binding: remove "wakeup-source"
> > =C2=A0=C2=A0 - use clear_bit instead of __clear_bit
> > =C2=A0=C2=A0 - use devm_of_clk_add_hw_provider instead of of_clk_add_pr=
ovider
> > =C2=A0=C2=A0 - use chip_desc pointer as driver data instead of enum.
> >=20
> > since v3:
> > =C2=A0=C2=A0 - add "break" to fix warning: unannotated fall-through
> > =C2=A0=C2=A0=C2=A0=C2=A0 Reported-by: kernel test robot <lkp@intel.com>
> >=20
> > since v2:
> > =C2=A0=C2=A0 - dt-binding: update title and description
> > =C2=A0=C2=A0 - dt-binding: remove last example
> > =C2=A0=C2=A0 - drop watchdog support
> > =C2=A0=C2=A0 - support reading 12Hr format instead of forcing 24hr at p=
robe time
> > =C2=A0=C2=A0 - use "tm_year % 100" instead of range check
> > =C2=A0=C2=A0 - refactor max313xx_init for readability
> >=20
> > Ibrahim Tilki (2):
> > =C2=A0=C2=A0 drivers: rtc: add max313xx series rtc driver
> > =C2=A0=C2=A0 dt-bindings: rtc: add max313xx RTCs
> >=20
> > =C2=A0 .../devicetree/bindings/rtc/adi,max313xx.yaml |=C2=A0 144 +++
> > =C2=A0 drivers/rtc/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 11 +
> > =C2=A0 drivers/rtc/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0 1 +
> > =C2=A0 drivers/rtc/rtc-max313xx.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 | 1053 +++++++++++++++++
> > =C2=A0 4 files changed, 1209 insertions(+)
> > =C2=A0 create mode 100644 Documentation/devicetree/bindings/rtc/adi,max=
313xx.yaml
> > =C2=A0 create mode 100644 drivers/rtc/rtc-max313xx.c
>=20
> What happened to this series in the end? It kind of went off my radar=20
> and I forgot about it.
>=20
> We've been carrying a version of these changes in our local tree for a=
=20
> while (and using it quite happily I should add).
>=20

Hi Chris,

Also not sure.... In the meantime Ibrahim left ADI so if this is not in sha=
pe to
be merged he won't be able to re-spin. If there's a need for a re-spin, ple=
ase
let me know so I can see internally if there's someone who can continue thi=
s
work. I would do it myself if I had the HW.

- Nuno S=C3=A1