Received-SPF: pass (google.com: domain of linux-kernel+bounces-39723-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 26 Jan 2024 15:54:00 +0800
From: Chao Gao <chao.gao@intel.com>
To: Yang Weijiang <weijiang.yang@intel.com>
CC: <seanjc@google.com>, <pbonzini@redhat.com>, <dave.hansen@intel.com>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<yuan.yao@linux.intel.com>, <peterz@infradead.org>,
	<rick.p.edgecombe@intel.com>, <mlevitsk@redhat.com>, <john.allen@amd.com>
Subject: Re: [PATCH v9 25/27] KVM: nVMX: Introduce new VMX_BASIC bit for
 event error_code delivery to L1
Message-ID: <ZbNlGLu/PReeyCu5@chao-email>
References: <20240124024200.102792-1-weijiang.yang@intel.com>
 <20240124024200.102792-26-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240124024200.102792-26-weijiang.yang@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YYTK+7FjOSxon0DbC4Orztb/uDh+NRp2QjzCnR0jfVTQvfJ+4XV0qerV7YE2?=
 =?us-ascii?Q?3owvBmlVrGrEUj1SoyU/3beKUdUIxNzpaq0OJaWEv9993wvXsc/QQCrBGd6B?=
 =?us-ascii?Q?YpjJLNfeQHFE+RlJLhM5bQSbiVs3eFUvUXqtCtHjo/8LdeLHR+gMDJ0FcCBG?=
 =?us-ascii?Q?pLr174LRnMQD/ncFxgL71BeAOdIIzWMKW/Xfv2vqUe7N66HJbyQ98CN+l03X?=
 =?us-ascii?Q?pL65MOObmdZHet/yjtxpFvWSG+jNQV7DgMRpSYiLdobk9j2yIQRbIHDCcCSC?=
 =?us-ascii?Q?NOV/RitD/QFsQeEak6a9KFSr4l+nrzUJfy5GK5HfVSelOiZ3zbhsAT1R6Fd+?=
 =?us-ascii?Q?tobcXut1ZeySQ4NA+zrQK4WZPrGSyQH52uP5N429SYg0JqrlMkS0NHgzRtix?=
 =?us-ascii?Q?cjEn2eDMZGRUExq+/4b+t6sxJdSq2gMNnHaTj8x4kTZDRfEhu7TiwhPftpZR?=
 =?us-ascii?Q?slacSWVqM6LOsUyCsWlhQyIdNs95vhH4UD3A8Lidr6KJGXHSyagz7fAY3KmS?=
 =?us-ascii?Q?VmVXH5BVLITqvyQ4k9mN48TmVWAr3WISml0iMwR9x+HWFALjZjbNp9aVI+6E?=
 =?us-ascii?Q?wZIXSq1ZccbOzk++1wOoEJogT2L7Mj4Ox2DTyv7NSbYoj7pobnLrRd3Ms/8U?=
 =?us-ascii?Q?KICw4Hph5FFEASXTa0oL94pcAJzg5LQMohcBb6wQaOAIjPNtMHLu4SfVOnO+?=
 =?us-ascii?Q?J5QKmWTsPTRAEXSCF73LEpTmJsJ7mOmyJG4mJsuczDHSGgU7akwVgd3n/gWC?=
 =?us-ascii?Q?IwtXWy8GOUImdZRea90DROLW6jf8aU8XvxfHnf/tVK0NCWnjg6hwLEyYNP7f?=
 =?us-ascii?Q?bY2M4RXAnsBg8PmqLLOsjPiKWKEbnh8qfF2Fge6t1ym0YMqSlovOwcLXq5cM?=
 =?us-ascii?Q?fiV8FzPdzt/KiD7qT0Q7gBqe6LBdDgQgrZjKR6R7yVwxs6mo/A6pGvqN3aMb?=
 =?us-ascii?Q?/4iLVbVYqnz41vZJ0WyxBI8FZGCOfGRIcTmezYRzlxyeQ23/ccHCiqXsbMmQ?=
 =?us-ascii?Q?i+gpxYYGvFX04JSL2lslkJKJ5vVxmebZHU89XkqpB68j4dKmPhNYpDrknmyP?=
 =?us-ascii?Q?+5CYEU+zJX/MX/+FUli359ciJdn4zYuTgwhPwGTr+1+5Lo8jhKI3Ru7W6cbL?=
 =?us-ascii?Q?0lzyNKgt47/JHWLSSTZM1VL8sM1WL+I7WbnDVdD+P7DGRgbhlmh9q/hw76XN?=
 =?us-ascii?Q?EjWAJXpKv23hCQqc+tO4RjmzBnCXruYIpxAX4j2++KAaWbDHcEazPZ73+emQ?=
 =?us-ascii?Q?Fd/1nuw/hnr2JtG1yKIWcby72yJrnkKRux89wRTkI6Bejbm7Jex6eLLRhIGW?=
 =?us-ascii?Q?kHVUrhLCK4NdRQWMi5RmELCeB4v1Xiy99T7ileQPbBMIuER2ek7aX92B0AR1?=
 =?us-ascii?Q?2P0kX/4ecxxklfFrSdFS6m6nAZ+WT3Fp8+yWwx2YauORY+0s3dWdBy0CdNLu?=
 =?us-ascii?Q?Lurl9H9jM2cb3HntT6kP0a3CLdT5bBjWvwH5rJOorti63xZ3cAdJ6lxaoDKf?=
 =?us-ascii?Q?14yEBJelYpa64CDiZPQ1r5Xklm+LXtXl1vm4vCLq0Vq9d+QrVdihtrWIA3sC?=
 =?us-ascii?Q?jxgYhwthogwSfgzPJ97h2GID5xO6SjrGkge0byY6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d14a09c5-f76b-4d36-33dd-08dc1e43faa4
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 07:54:09.8379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pf9PB5MSDt8dNMmrvxVlR/0VlIPbnQDip5ue6wyLk2rLRrwB6Vl6SKg3p9AlZFlR7zjyma/MQqtARWF+aOnLwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7280
X-OriginatorOrg: intel.com

On Tue, Jan 23, 2024 at 06:41:58PM -0800, Yang Weijiang wrote:
>Per SDM description(Vol.3D, Appendix A.1):
>"If bit 56 is read as 1, software can use VM entry to deliver a hardware
>exception with or without an error code, regardless of vector"
>
>Modify has_error_code check before inject events to nested guest. Only
>enforce the check when guest is in real mode, the exception is not hard
>exception and the platform doesn't enumerate bit56 in VMX_BASIC, in all
>other case ignore the check to make the logic consistent with SDM.
>
>Suggested-by: Chao Gao <chao.gao@intel.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>