Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp486274rdb; Fri, 26 Jan 2024 01:26:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IESop1yTE033pQN5bS6iMGJdq5m9aopTy3RBt4VoUnX1CMevV0raEQsvIhtuvlSzd6Db6f6 X-Received: by 2002:ac8:584a:0:b0:42a:5a44:4210 with SMTP id h10-20020ac8584a000000b0042a5a444210mr1505513qth.85.1706261184795; Fri, 26 Jan 2024 01:26:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706261184; cv=pass; d=google.com; s=arc-20160816; b=J+3TOE1sbwPvJasGj+SzlyRCCTBug++VDu/Z1ca2z33eWwIv8+7Dam28lY2yBstdHo SrZD15eG0f8OB1l0al7tizgfBY0an0AymdpYCRAUB3ad4YZ59GekimT4BBgcdVZMoJny XKJPcxkZeSqOhLcx2AvYEkKva8hgocLfR+RprbLfC9VftK8WrC40bBC32MBGrgNGe+W6 O321lU4nWZp84c1d1/yPrCkLsUk9AD12SCaQpOZHjFRkJ14DW1ojNqh2r7OwIagOFnrJ Zdvt6tzbDalxbwesjmb500OB/9QoDN5xixEeEsCocAX6Fi57tGu3lyPgmL3KCLWnTI2d WK2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=Zyarw9IVqR02/IX82g8qzKunIT89ZgffeUzH3Tr2v60=; fh=wTXPvjXk+b9La2i1anG50lvHfKYhtFNNDJPifhI39sU=; b=Ck27ARHAgEU1bSgIFp6iiPOyZQcMz5deNr2QKtPxoilLgAMLZH4j2BtlPnVRP3wYzS vSCfgIqLe0um3y+O6kNMySZnGfh3tA5NBhALpJ2r5PYuNxyvmamOJbOfbpzeodQygkFg p7KzSSSLgHZMtVzP4wy+bEf17mNDBbaSOAbUdH0BJP20HYFchbTlLsKprzIooRFNLAEl AJv58Un7XA/arr/JC2paYJ5yyLb2PoK534Ces3hW+wlsAvxLEkZZjDgYc7IRGrBS26Jb lamgM1gcofiS0iTAdhcsnHzk+kRQLwcgyspdhBNE9pDO7OQLrtO78qH98zn/TbXReWA/ PRNQ== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-kernel+bounces-39796-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39796-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 12-20020ac8574c000000b0042a59972c9fsi790828qtx.245.2024.01.26.01.26.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 01:26:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39796-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-kernel+bounces-39796-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39796-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 98E2F1C26578 for ; Fri, 26 Jan 2024 09:26:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6D0A20311; Fri, 26 Jan 2024 08:54:28 +0000 (UTC) Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A991200BE; Fri, 26 Jan 2024 08:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706259268; cv=none; b=AlFkosiYtO9cCf72rdtf5nsYwELL46qm7inZmv8Bpuh4bCPEd+JSerR1nnHwiIsqEDEDEBsX6PS/D/MsIJehiwTP2/i4URhnN/P+/PxPtyQihWcHaapIeF0WD5sz7yH3LEDOwWtQJY5pCZ7StrcqnUMx4TdMAXKVYPdN0cazLuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706259268; c=relaxed/simple; bh=m2v8yGscxTccKKQmICA2Ug+JNmQcZxXV7SctgFuruso=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gz2rfgf2ze6db7R+dZ06PkU4zMGUJTZtglRFG6mzIGNh8YHGMh1hGJyZQvPhVHF5VcvhApqpv7BpDWobH3jg9k2CTvK9iSO92qBxFEUP3Ds9gMzSFildCgY7kGaMGKB3r9m9HEPyyJpo3nqzvoWjy+677q1pX/XsIPm3DDGYYMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rTHyW-006ESD-Fn; Fri, 26 Jan 2024 16:54:13 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Jan 2024 16:54:25 +0800 Date: Fri, 26 Jan 2024 16:54:25 +0800 From: Herbert Xu To: taoqi Cc: davem@davemloft.net, liulongfang@huawei.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH 3/4] crypto: hisilicon/sec2 - fix some cleanup issues Message-ID: References: <20231229064421.16981-1-taoqi10@huawei.com> <20231229064421.16981-4-taoqi10@huawei.com> <273d30b3-edba-4f4c-8138-fe83dbfd83aa@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <273d30b3-edba-4f4c-8138-fe83dbfd83aa@huawei.com> On Fri, Jan 26, 2024 at 04:40:39PM +0800, taoqi wrote: > > I'm sorry. I made a mistake here. unsigned long and uintptr_t are the same > data type in linux kernel. The type cast is invalidly repeated here. Can I > just keep (unsigned long) one cast? Yes that makes sense. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt