Received-SPF: pass (google.com: domain of linux-kernel+bounces-39884-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Jan 2024 09:06:05 +0000
From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>, broonie@kernel.org,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes
Message-ID: <20240126090605.GO74950@google.com>
References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com>
 <20240125102555.2621736-2-ckeepax@opensource.cirrus.com>
 <20240125135509.GL74950@google.com>
 <CAHp75Vc4jiz3Wjg_1DKs=X=Q8oxMmEASx2VB-BZsawSDa2cwRQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75Vc4jiz3Wjg_1DKs=X=Q8oxMmEASx2VB-BZsawSDa2cwRQ@mail.gmail.com>

On Thu, 25 Jan 2024, Andy Shevchenko wrote:

> On Thu, Jan 25, 2024 at 3:55 PM Lee Jones <lee@kernel.org> wrote:
> > On Thu, 25 Jan 2024, Charles Keepax wrote:
> >
> > > Use more forward declarations, move header guards to cover other
> > > includes, and rely less on including headers through other headers.
> > >
> > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> >
> > Patches look okay to me, but seeing as Andy suggested the changes, it
> > would be good to get a R-by from him.
> 
> I'm worried now only about missing a commit message in one patch and
> (with less severity) the v2 of this one which appears not to be
> necessary (i.e. v1 is fully okay). If you consider the commit message
> absence is okay, feel free to apply v2, otherwise with that addressed
> v3 can go in my opinion.

Please fix-up and submit a v4 with Andy's R-bs.

> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

-- 
Lee Jones [李琼斯]