Received-SPF: pass (google.com: domain of linux-kernel+bounces-39932-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d717a278-640b-432d-b026-2a624700b61a@intel.com>
Date: Fri, 26 Jan 2024 17:37:19 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 23/27] KVM: VMX: Set host constant supervisor states to
 VMCS fields
Content-Language: en-US
To: Chao Gao <chao.gao@intel.com>
CC: <seanjc@google.com>, <pbonzini@redhat.com>, <dave.hansen@intel.com>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<yuan.yao@linux.intel.com>, <peterz@infradead.org>,
	<rick.p.edgecombe@intel.com>, <mlevitsk@redhat.com>, <john.allen@amd.com>
References: <20240124024200.102792-1-weijiang.yang@intel.com>
 <20240124024200.102792-24-weijiang.yang@intel.com>
 <ZbNRz/c207HYuHxi@chao-email>
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZbNRz/c207HYuHxi@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzhWR09LNjhpZVpyMy9jZlpWd1h3dEtHTklsZEQzZW9IV0ZRQkFYcUFYeTk5?=
 =?utf-8?B?WGV3R0Q3NitKekZxMWpManJxN1JrZHNkOFJQSnN6RHRiczFJMzFtcnIzT0Rn?=
 =?utf-8?B?aGxoL3c5T3JVSEZKVnZrOGJTNGpVZ1VYOGpKRUJqUGlCSFdWdWhQeEFrd1RR?=
 =?utf-8?B?ZVZESlFibGM5Vmw1ZFd3UFI5L2orTG9RSEE2Q2V0SkphZ0t6anV4Z0dwTTky?=
 =?utf-8?B?cWU5QWtveFBUZGIwNFc0NTl4MktTYjl0elNZcnliV3R1MExxdktqcnRqK1U1?=
 =?utf-8?B?NHB5V1dDL3h5WXJKb3V2Um10TzlNQ1VwMEpKS2dGbnFRei9Odkd6b3NvUFcz?=
 =?utf-8?B?amZibld0c1k4OHJxZXFGdUlKTjE2Q2dhek9HMjhrZEVBeUlHTGdvM3JUekhT?=
 =?utf-8?B?YTBDa0pNVnplK3BWWCtHbk04N29mRmlhVmFpUzZER2l0UnRTeGpXZmhuM3kv?=
 =?utf-8?B?djJKTUtlTVVKenFwVmp5ZVNCT3Rick9qdjZ2VTcxaXZRalFsM2l6b0xiQTNC?=
 =?utf-8?B?cFBsRUprcXh6SkhTb0RidXZyNkVkWTkyL2oxWWxPOGVHcEdJYmI5bDQzUVg4?=
 =?utf-8?B?MGwwYWE1YThRa2hjK2FZVTFURDMvRjJrRytyTkl5NitVTEF2bEJyWGlHSTBl?=
 =?utf-8?B?dGxoNFlzQldQQXh3NmQ4dnNCZm9KQ2I4SXlLYzRsVk1FMGZSdkJyRmdjV2xp?=
 =?utf-8?B?RzV6V0dhTUhFNXZnSzR2SlRiWXFEQVNhSUhTYytBZU82TElaS2JjWTM2UUJx?=
 =?utf-8?B?K2V0Y0ZJbmJKRmhHRE5zenZ2b2Y4RStnVDkyb3UzVjlBMVRrbDlzcklla2xH?=
 =?utf-8?B?ZVRlNlJxR0RmM1pxblZ3RUI1aTNYbktNSFBsR2tsVVUyblBWR0hVRDdBbm00?=
 =?utf-8?B?UVNzL0hTdVZUdkRUaGRIU0JqNHRMdmdnbWR3U0FEd1hISE5WRHdGSDRJS1ZN?=
 =?utf-8?B?NEZXQng2TDNSRHpxRmNGNVAvdnpHcEtyRHllY0VzbldwTGhzSHp2R0hEMUdz?=
 =?utf-8?B?anpKbVNSMGZqcVNBQ2xJSmM5RGtIY2xLMWpodUVuMXAra1l1a1YzNVRNV0Fv?=
 =?utf-8?B?b21CbEJrK2Urc3Jza0dQeHQyZCt6SWZFZ3NGU1pnUWZ5OEc5aW9lQmhZSVRm?=
 =?utf-8?B?Z2lla1g5WlpTWlJzUGdCdEtGRDBzQXJIbzl5Z3FqUjFjR0ZZUWlGVU1zYjFY?=
 =?utf-8?B?MG5STDFOMXIwOEFsQTc1M1N0RWJrMnFVMFFkbXNGUGdVcTVPWlY0K3J0Nlg0?=
 =?utf-8?B?bGViUldWdHJ6Q3ZUd0Y1VUtqMVFnaERPbzh2d25rblh3bWp5d3V6bzFYajVY?=
 =?utf-8?B?bEhtdTZWUm5PcEU2L3I5d1Rtcit4Mm42azQxRWkwN2Z5RHI3UGV4V1BJelRw?=
 =?utf-8?B?dGQ1WHNVSGloNVR4Tm84c3dzTTVXVWFPQWVLaFZiVGYvamM5NE5lcFMxcEZZ?=
 =?utf-8?B?L3VPa3NuMmVjamdVRmhubWxQcUVzT3lwL1R1TlZBUTlUNHRTS0FOYzU5bENm?=
 =?utf-8?B?WkhkamxKVHcwTW5mdjRmYXJEajlMUVFDVU1qSWxodmhpdWtyZThCelJPQ1ZE?=
 =?utf-8?B?aDVnVFIzaFRVd0lLeHJ3OGNRYnE4am9pbGtDQThnT2NhMDhMMTlDT3RIV2xs?=
 =?utf-8?B?T2lITndLSm0vWEJmOXo5U1p4bWQ3UERrLzlsZ3lmZFBNK3ZOV1JLY01TKzdq?=
 =?utf-8?B?eFlxdkpRdUd2RTkrZURTbDFlekZoMGl6ZHQzcUVJSjk2VGpBQ0h5T1ArSjBG?=
 =?utf-8?B?MVVrbUwyRjNyeU5uYWRHVmtEZmszWEswVUpaNEs1cmxuM3BjUDBHREIzWTZs?=
 =?utf-8?B?bk40S1lrR0UxOGhnMmk5YkdqRi9YQ3RoVG52MVNYb1dhYUgxNE4yZ3BNV2NR?=
 =?utf-8?B?UGN0UkV6S1N6STNqRE5hWFdIWmNmcDNnblVONFlwMUQzcGZyL0pWUUVrUjBF?=
 =?utf-8?B?V2dRZXVzYmlpR0ZBREJiUWJVYStiOUw0M3JnamdERFFjWkdSRU5EZ0gzNGxn?=
 =?utf-8?B?azU4UG5sZXlHaUdtbnhiNWNQbVlJcFIxSHN3VmM5ZHIwaEVhZTNqdnBLM05L?=
 =?utf-8?B?RmZyTWQ3R2gwVERodStzbVNyekJHMDFXYkV4MTZlYjBOeFBYZ3B5eTlyUy93?=
 =?utf-8?B?Z1NHaTNEcHJ3MnduemcyUzcxKzNKT1VkNitDclc5WFB2clByQkUzZURXVFB1?=
 =?utf-8?B?ZFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49c6cced-6ec2-40f4-4500-08dc1e526726
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 09:37:25.0052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mj+1LMdrvf3pViZp8AtSN6PYMjYKfEfgNqXASYFZvQV6RrjTobTM6i42s3EtqEXV7jAy3cdb/7cinh/7PjH2Jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4805
X-OriginatorOrg: intel.com

On 1/26/2024 2:31 PM, Chao Gao wrote:
> On Tue, Jan 23, 2024 at 06:41:56PM -0800, Yang Weijiang wrote:
>> Save constant values to HOST_{S_CET,SSP,INTR_SSP_TABLE} field explicitly.
>> Kernel IBT is supported and the setting in MSR_IA32_S_CET is static after
>> post-boot(The exception is BIOS call case but vCPU thread never across it)
>> and KVM doesn't need to refresh HOST_S_CET field before every VM-Enter/
>> VM-Exit sequence.
>>
>> Host supervisor shadow stack is not enabled now and SSP is not accessible
>> to kernel mode, thus it's safe to set host IA32_INT_SSP_TAB/SSP VMCS field
>> to 0s. When shadow stack is enabled for CPL3, SSP is reloaded from PL3_SSP
>> before it exits to userspace. Check SDM Vol 2A/B Chapter 3/4 for SYSCALL/
>> SYSRET/SYSENTER SYSEXIT/RDSSP/CALL etc.
>>
>> Prevent KVM module loading if host supervisor shadow stack SHSTK_EN is set
>> in MSR_IA32_S_CET as KVM cannot co-exit with it correctly.
>>
>> Suggested-by: Sean Christopherson <seanjc@google.com>
>> Suggested-by: Chao Gao <chao.gao@intel.com>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> Reviewed-by: Chao Gao <chao.gao@intel.com>
>
> two nits below.
>
>> ---
>> arch/x86/kvm/vmx/capabilities.h |  4 ++++
>> arch/x86/kvm/vmx/vmx.c          | 15 +++++++++++++++
>> arch/x86/kvm/x86.c              | 14 ++++++++++++++
>> arch/x86/kvm/x86.h              |  1 +
>> 4 files changed, 34 insertions(+)
>>
>> diff --git a/arch/x86/kvm/vmx/capabilities.h b/arch/x86/kvm/vmx/capabilities.h
>> index 41a4533f9989..ee8938818c8a 100644
>> --- a/arch/x86/kvm/vmx/capabilities.h
>> +++ b/arch/x86/kvm/vmx/capabilities.h
>> @@ -106,6 +106,10 @@ static inline bool cpu_has_load_perf_global_ctrl(void)
>> 	return vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL;
>> }
>>
>> +static inline bool cpu_has_load_cet_ctrl(void)
> s/cet_ctrl/cet_state
>
>> +{
>> +	return (vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_CET_STATE);
> nit: unnecessary brackets.

OK, will fix these nits.