Received-SPF: pass (google.com: domain of linux-kernel+bounces-39928-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <4da92124-ab97-45dc-a89b-61a85f6ce240@intel.com>
Date: Fri, 26 Jan 2024 17:36:06 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 22/27] KVM: VMX: Set up interception for CET MSRs
Content-Language: en-US
To: Chao Gao <chao.gao@intel.com>
CC: <seanjc@google.com>, <pbonzini@redhat.com>, <dave.hansen@intel.com>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<yuan.yao@linux.intel.com>, <peterz@infradead.org>,
	<rick.p.edgecombe@intel.com>, <mlevitsk@redhat.com>, <john.allen@amd.com>
References: <20240124024200.102792-1-weijiang.yang@intel.com>
 <20240124024200.102792-23-weijiang.yang@intel.com>
 <ZbMs6KsCWqE0fpQv@chao-email>
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZbMs6KsCWqE0fpQv@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3c5Q0xtQzd5K0pmdzhVVGRCWCt6NWw2RmxYQVVvNW1LRVNmczd6eUNMR2Fx?=
 =?utf-8?B?WGY0WjM1SzFoM0d4TkdPM0tTM2ttVUErSThvb1NvYk12Z0x1czdpampWQkRG?=
 =?utf-8?B?RzJNOEJueVR2V2hMdThybTRRZmUxZlNtdEpaVmFCbDN5cCtORmUyVkY5Tkt4?=
 =?utf-8?B?L0cyTXNITXFITHc5cy9YZXhJMm1uRmtDbHJHbDV3NndsTkxQdGVPczZSam0x?=
 =?utf-8?B?dUlCWktHR1A1Ri9KSDRqOW9pNUtBc2NMb1BxWWRtV3hzNE0wejdxcjVSUXdO?=
 =?utf-8?B?bGZxZUkrRERuWThWWWwrS2thcTQvcU1oM0FTSnZLRTQ4NG04Q3RXYzVGWnlx?=
 =?utf-8?B?RUNlNmpTQzU2Y0xqc1Q1c2RwN09uWXl1dENFcGpzRnlrZHYwUGpIZU9PUXFM?=
 =?utf-8?B?SkZlV3U2dXhmRnpuS0JSN29vV2s0QTV2UjdaK0Q3dHZnd1cwVEtmcW9HZG1j?=
 =?utf-8?B?akt4WXd3b1pxWGZYQ1EvRFVPR3RySHM1MXJrMUZXY1YySGN4azdmUVpJSlg3?=
 =?utf-8?B?bHlBQXhEMjlHMEw5Wkl5QkJ3WTBiczlUY016R25uVWo5WnhBSUpZQUhUbkJR?=
 =?utf-8?B?SFZIYnl5a1RsZjVkZGxudWtiUFBZcnkxMXUvTUY2QjBYem5ESjBWblNGa0RF?=
 =?utf-8?B?R1lhRXJtNmVVdWtRS1FEUFprOUkvMXlQMjZveEdiUTkrcVlTRVYra3Q2NWNj?=
 =?utf-8?B?bk9SZ1hzRzF5RjQ1ZTh4L0VNMk9WbEd5TDlPd1FvLytydFJiRjUxSm1mSERS?=
 =?utf-8?B?ZjdoekN6TEEzaVhpb3pGSjUzMjE3TUIxb2RnTEt4dEZuNFpIZk9yQUh1aWNN?=
 =?utf-8?B?VENVbnBGVHRDR0V6WVcrS0RLWTIvUjZjRUpqTDUva1FzR1lWL3FLc01ETFF6?=
 =?utf-8?B?QjVJWGNOTUFKQjlrYm9IYXVSVk1SdjNidUcxT2FDUU55NGtlQk9IWk85TVFp?=
 =?utf-8?B?N3gxcHNHZktZa3RDRmo1RUhib013bDV1STQ1T2QwTEV3U3BMbTBmbFJQOGdT?=
 =?utf-8?B?VG14Qm5VTndHc3FCSDBXczBLb2YwSlBaQzA3dUtLK1ZmeGprYzM5SlRsdEhs?=
 =?utf-8?B?SUhBakJnc3pWRmJvNVlFejN3N2lxYXJud3V6aVpVUHpHM1N5UzQ2ZGMrb3Rl?=
 =?utf-8?B?MXcwZDZCTE4yY1k3dVpLbTBpdWgvcGRzZnhDeVZaaWo2VzBQKzdvbXdUems2?=
 =?utf-8?B?NnRVRnRUclcxZ2lvaW1RdVlRMnd3ODM3UEJmaWNhc1gvQmVreDVUd3IwMnht?=
 =?utf-8?B?TXQrZXp0WGZhUzdxUlFEUklNMG5DUkZhVWZKeTNzMEdaZHF3VUl0VWZMRW53?=
 =?utf-8?B?bHo4eWY0Wk93MTBsTmx4NXBYclNOVmlWcGl3M1BYdjFvMzFwTVpnYlZ6RWV0?=
 =?utf-8?B?MUJDQWY5cllDekx4VHQ3RWVaOGpEOW1YeFVtKytpd3hqRHFkZFFCck1EaU5V?=
 =?utf-8?B?bU5TN2tLMHl6MTNkWnY3Y0krRjI2bEJ4WEJxUW5USmRZRHViNEo1Zkh1OHdv?=
 =?utf-8?B?WDNKNHFkRnNvNE5qb09PY0t4SGZoUWJVZHlkd0lKV1czTHVFNVZFNGRRb3Zq?=
 =?utf-8?B?ZzBpaGVPNTBKQ0pGZFZMa1I3Q3JIQUhqZGFXUlkyK0NTU05lTGwyc0I2UmF6?=
 =?utf-8?B?Ty92TVN4Wmk1SEFEMlJtUTNZa1ZrZDhndXJvckJnUEhIU3RGdlF4UzlzMS9k?=
 =?utf-8?B?bVdpMlJUN3pTUk9UUGErU1JZZEpFZXNiSHdlQ0NRK2RtSkdESjIzTitxNHNJ?=
 =?utf-8?B?UXpxdTlwOHpZbUlKQi9QY1FkVjdqNGsvbnY1SHN0QXp3UTYzK3VCSG04Zndw?=
 =?utf-8?B?RFF2YTgvaExuVXNZSEFsSEZBTVFkVVRiVlgrNWlHTHlTU0pPc21oUnBkWGhr?=
 =?utf-8?B?QjdGVHdUck9vVURGTmxsVXVLMFl3TFZVM3RKWkwrWVRhNzhPTzJ6VDlNRGNp?=
 =?utf-8?B?dm5Fa0xlWUJsR05uNVpLT0FDRDhvNnl2L0p2bWNoUUxlU2h6TVRLOXJqWElJ?=
 =?utf-8?B?RVNqaUtNZ1pJaERFUjRaL09NYllWakR0Z1pqZTFUYllXbTZOZExNeHZvS2Jw?=
 =?utf-8?B?ajA2dE4reE9rL2prdGdxdlNWdDRqVnRpU0JaVEYvd0twTmhVYXlSekppM0x0?=
 =?utf-8?B?N0RNeTJtd0crS3Y3SFRKMzRCMUtydkxXN3R6MmF3OVZHNFFvNTRYdGpuOGZ3?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1621410a-faab-4aec-b59e-08dc1e524091
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 09:36:20.2316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xl5egRQIM66VthpZ0Y70KHD7jIDtbzVVkCOcohENd7x0Xh6DeKDfL4P1FosaDZaUM+esALkD2cUiOaPeldyN+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4805
X-OriginatorOrg: intel.com

On 1/26/2024 11:54 AM, Chao Gao wrote:
> On Tue, Jan 23, 2024 at 06:41:55PM -0800, Yang Weijiang wrote:
>> Enable/disable CET MSRs interception per associated feature configuration.
>> Shadow Stack feature requires all CET MSRs passed through to guest to make
>> it supported in user and supervisor mode while IBT feature only depends on
>> MSR_IA32_{U,S}_CETS_CET to enable user and supervisor IBT.
>>
>> Note, this MSR design introduced an architectural limitation of SHSTK and
>> IBT control for guest, i.e., when SHSTK is exposed, IBT is also available
>> to guest from architectual perspective since IBT relies on subset of SHSTK
>> relevant MSRs.
>>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> Reviewed-by: Chao Gao <chao.gao@intel.com>
>
> one nit below,
>
>> ---
>> arch/x86/kvm/vmx/vmx.c | 41 +++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 41 insertions(+)
>>
>> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>> index 064a5fe87948..34e91dbbffed 100644
>> --- a/arch/x86/kvm/vmx/vmx.c
>> +++ b/arch/x86/kvm/vmx/vmx.c
>> @@ -692,6 +692,10 @@ static bool is_valid_passthrough_msr(u32 msr)
>> 	case MSR_LBR_CORE_TO ... MSR_LBR_CORE_TO + 8:
>> 		/* LBR MSRs. These are handled in vmx_update_intercept_for_lbr_msrs() */
>> 		return true;
>> +	case MSR_IA32_U_CET:
>> +	case MSR_IA32_S_CET:
>> +	case MSR_IA32_PL0_SSP ... MSR_IA32_INT_SSP_TAB:
>> +		return true;
> Please update the comment above vmx_possible_passthrough_msrs[] to indicate CET
> MSRs are also handled separately.

OK, will do it, thanks!