Received-SPF: pass (google.com: domain of linux-kernel+bounces-39987-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <84e362b0-9a9f-461b-b472-a9b3666cb94b@ysoft.com>
Date: Fri, 26 Jan 2024 11:14:22 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v2] net: dsa: qca8k: fix illegal usage of GPIO
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
 Vladimir Oltean <olteanv@gmail.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Christian Marangi <ansuelsmth@gmail.com>,
 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
 =?UTF-8?Q?Marek_Beh=C3=BAn?= <kabel@kernel.org>,
 Christian Lamparter <chunkeey@gmail.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, petr.benes@ysoft.com
References: <1706096225-23468-1-git-send-email-michal.vokac@ysoft.com>
 <2477cf4a-6824-4997-aef8-3f8e5f9b2399@lunn.ch>
From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= <michal.vokac@ysoft.com>
In-Reply-To: <2477cf4a-6824-4997-aef8-3f8e5f9b2399@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 25. 01. 24 17:59, Andrew Lunn wrote:
>> diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
>> index ec57d9d52072..3663de8f2617 100644
>> --- a/drivers/net/dsa/qca/qca8k-8xxx.c
>> +++ b/drivers/net/dsa/qca/qca8k-8xxx.c
>> @@ -2037,13 +2037,11 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
>>   	priv->dev = &mdiodev->dev;
>>   	priv->info = of_device_get_match_data(priv->dev);
>>   
>> -	priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
>> -						   GPIOD_ASIS);
>> +	priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset", GPIOD_OUT_HIGH);
> 
> Sorry, i should of pointed this out on the previous version. netdev
> kept with 80 character lines. That is why what you deleted was split
> over two lines, and what you add should also split at the same point.
OK, no problem I will fix that. I did not realize, that netdev kept
that rule.

Michal