Received-SPF: pass (google.com: domain of linux-kernel+bounces-40007-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Jan 2024 11:51:11 +0100
From: Michal Hocko <mhocko@suse.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: akpm@linux-foundation.org, surenb@google.com, riel@surriel.com,
	willy@infradead.org, cl@linux.com, yang@os.amperecomputing.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	"Bernhard M. Wiedemann" <bwiedemann@suse.de>,
	Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32
 bit
Message-ID: <ZbOOn0hrKQ_ojM2K@tiehlicka>
References: <20240118133504.2910955-1-shy828301@gmail.com>
 <ZbIhoj2PzD5jIdSn@tiehlicka>
 <2afa54e6-90db-4ae0-a21c-78e5051aa83c@kernel.org>
 <de249ba0-6efa-416a-a1a9-59c47d71cbc9@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <de249ba0-6efa-416a-a1a9-59c47d71cbc9@kernel.org>

On Fri 26-01-24 10:41:49, Jiri Slaby wrote:
> On 26. 01. 24, 10:36, Jiri Slaby wrote:
> > > > --- a/mm/huge_memory.c
> > > > +++ b/mm/huge_memory.c
> > > > @@ -37,6 +37,7 @@
> > > > ? #include <linux/page_owner.h>
> > > > ? #include <linux/sched/sysctl.h>
> > > > ? #include <linux/memory-tiers.h>
> > > > +#include <linux/compat.h>
> > > > ? #include <asm/tlb.h>
> > > > ? #include <asm/pgalloc.h>
> > > > @@ -811,6 +812,14 @@ static unsigned long
> > > > __thp_get_unmapped_area(struct file *filp,
> > > > ????? loff_t off_align = round_up(off, size);
> > > > ????? unsigned long len_pad, ret;
> > > > +??? /*
> > > > +???? * It doesn't make too much sense to froce huge page alignment on
> > > > +???? * 32 bit system or compat userspace due to the contrained virtual
> > > > +???? * address space and address entropy.
> > > > +???? */
> > 
> > FWIW,
> > Bernhard noticed that "froce" and "contrained", could you fix that
> > before applying the patch?
> 
> No, you can't:
> 
> 1) it was merged to mm-stable already, and
> 2) the comment is not in that version at all [1]
> 
> [1] https://lore.kernel.org/all/20240126075612.87780C433F1@smtp.kernel.org/

Matthew has objected that the comment is not really necessary and I
think he is quite right. If anything the commend would be helpful to
explain why this doesn't make much sense (because that breaks ASLR
on default configuration and compat tasks). But that should be clear
from the changelog so I think we are good here.

-- 
Michal Hocko
SUSE Labs