Received-SPF: pass (google.com: domain of linux-kernel+bounces-39923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240125071901.3223188-1-zhaoyang.huang@unisoc.com>
 <CAGWkznGpW=bUxET8yZGu4dNTBfsj7n79yXsTD23fE5-SWkdjfA@mail.gmail.com> <ZbNziLeet7TbDKEl@casper.infradead.org>
In-Reply-To: <ZbNziLeet7TbDKEl@casper.infradead.org>
From: Zhaoyang Huang <huangzhaoyang@gmail.com>
Date: Fri, 26 Jan 2024 17:28:58 +0800
Message-ID: <CAGWkznGG1xLcPMsWbbXqO5iUWqC2UmyWwcJaFd4WBQ-aFE=-jA@mail.gmail.com>
Subject: Re: [PATCHv3 1/1] block: introduce content activity based ioprio
To: Matthew Wilcox <willy@infradead.org>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>, Alexander Viro <viro@zeniv.linux.org.uk>, 
	Christian Brauner <brauner@kernel.org>, linux-fsdevel@vger.kernel.org, 
	Andrew Morton <akpm@linux-foundation.org>, Jens Axboe <axboe@kernel.dk>, Yu Zhao <yuzhao@google.com>, 
	Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <niklas.cassel@wdc.com>, 
	"Martin K . Petersen" <martin.petersen@oracle.com>, Hannes Reinecke <hare@suse.de>, 
	Linus Walleij <linus.walleij@linaro.org>, linux-mm@kvack.org, linux-block@vger.kernel.org, 
	linux-kernel@vger.kernel.org, steve.kang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 26, 2024 at 4:55=E2=80=AFPM Matthew Wilcox <willy@infradead.org=
> wrote:
>
> On Fri, Jan 26, 2024 at 03:59:48PM +0800, Zhaoyang Huang wrote:
> > loop more mm and fs guys for more comments
>
> I agree with everything Damien said.  But also ...
ok, I will find a way to solve this problem.
>
> > > +bool BIO_ADD_FOLIO(struct bio *bio, struct folio *folio, size_t len,
> > > +               size_t off)
>
> You don't add any users of these functions.  It's hard to assess whether
> this is the right API when there are no example users.
Actually, the code has been tested on ext4 and f2fs by patchv2 on a
v6.6 6GB android system where I get the test result posted on the
commit message. These APIs is to keep block layer clean and wrap
things up for fs.
>
> > > +       activity +=3D (bio->bi_vcnt + 1 <=3D IOPRIO_NR_ACTIVITY &&
> > > +                       PageWorkingset(&folio->page)) ? 1 : 0;
>
> folio_test_workingset().
>
> > > +       return bio_add_page(bio, &folio->page, len, off) > 0;
>
> bio_add_folio().
>
> > > +int BIO_ADD_PAGE(struct bio *bio, struct page *page,
> > > +               unsigned int len, unsigned int offset)
> > > +{
> > > +       int class, level, hint, activity;
> > > +
> > > +       if (bio_add_page(bio, page, len, offset) > 0) {
> > > +               class =3D IOPRIO_PRIO_CLASS(bio->bi_ioprio);
> > > +               level =3D IOPRIO_PRIO_LEVEL(bio->bi_ioprio);
> > > +               hint =3D IOPRIO_PRIO_HINT(bio->bi_ioprio);
> > > +               activity =3D IOPRIO_PRIO_ACTIVITY(bio->bi_ioprio);
> > > +               activity +=3D (bio->bi_vcnt <=3D IOPRIO_NR_ACTIVITY &=
& PageWorkingset(page)) ? 1 : 0;
> > > +               bio->bi_ioprio =3D IOPRIO_PRIO_VALUE_ACTIVITY(class, =
level, hint, activity);
> > > +       }
>
> why are BIO_ADD_PAGE and BIO_ADD_FOLIO so very different from each
> other?
These two API just repeat the same thing that bio_add_page and
bio_add_folio do.
>
> > >  static __always_inline __u16 ioprio_value(int prioclass, int priolev=
el,
> > > -                                         int priohint)
> > > +               int priohint)
>
> why did you change this whitespace?
>
> > >  {
> > >         if (IOPRIO_BAD_VALUE(prioclass, IOPRIO_NR_CLASSES) ||
> > > -           IOPRIO_BAD_VALUE(priolevel, IOPRIO_NR_LEVELS) ||
> > > -           IOPRIO_BAD_VALUE(priohint, IOPRIO_NR_HINTS))
> > > +                       IOPRIO_BAD_VALUE(priolevel, IOPRIO_NR_LEVELS)=
 ||
> > > +                       IOPRIO_BAD_VALUE(priohint, IOPRIO_NR_HINTS))
>
> ditto
These white spaces are trimmed by vim, I will change them back in next vers=
ion.
>
> > >                 return IOPRIO_CLASS_INVALID << IOPRIO_CLASS_SHIFT;
> > >
> > >         return (prioclass << IOPRIO_CLASS_SHIFT) |
> > >                 (priohint << IOPRIO_HINT_SHIFT) | priolevel;
> > >  }
> > > -
>
> more gratuitous whitespace change
>