Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp544321rdb; Fri, 26 Jan 2024 03:43:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEykXba7cnmEtXzn8E0p9jx39eoqqN5Wqwpm5IVkTA5Q1vvQjh3QcxSYGo3B0oC4W8ym0do X-Received: by 2002:a17:90a:fb57:b0:28d:dbe8:aa6c with SMTP id iq23-20020a17090afb5700b0028ddbe8aa6cmr836881pjb.36.1706269410563; Fri, 26 Jan 2024 03:43:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706269410; cv=pass; d=google.com; s=arc-20160816; b=Y2gt6/yKr/RhHvWMLOAlORRkfj8RwCBokQQw95S8BEMXKICzdx8/nKnbW0eP6BnQVw 0pNdne7Ba70uBekVMdcrWmgwu6x+mCK1Ps22qOSYiPFZ0EG1xc1khEI1+1cIJ50ImEkJ KDfbtbMQYPnAt8Fe+82dltJ5gBDoyj1nTBQQ802EU43rl6+t39oj58gl6WAmFbvy71yu 6EoOP9dc0uOzYyey+PNV/IUIOvgkVqZMiuN1mCiZDZrQBViicdl+NpSpJF+STVuf4uZE GxenJ/+a7rF+Qjqs/LE+JZJS6MdPWr5yLQJhKtnOZiYIi0+iOHD6b5kGXt0lf7l1omyh c/zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Qd3nlym//LAlFHkady1BwwInKwCk8mDwSQ8io13WFIE=; fh=GyMgJgAJDifskgPT9wvC2z6Gg7CQFjZsd39qsc/MfUg=; b=wPNw58onfHP5pxoBf1FqZtrOe3keXZaMAF/24htk++uQv4iYtUElmEYCN9nDTO2v2i I1ZePcyAYnJb3zQfbSYJ9lsPCDw1M5FBAkziSUDMQe2+O0bEWDAABeawftj3yfFqVOKL Ox0/7fSpIb9ax17qIwYOOhRZx+/uA4uXl5FnphitNt5PRRBeVTv8AsM7tnn6aUqTStK7 Va7d8lM00JbuPFtPoDM9LfwYmPu8nKQL1k2erZdHQ+m0YjnS5DsWn03USIM1CXVZfAce m/J1f7aZEGfGMnlHwg1YXfUTFmSJdr490m45V2F3V9zVv1kgP51WqD6+76ZcaIe9lBFd T/bw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OrN8QdyZ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-39547-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39547-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bi4-20020a170902bf0400b001d74cea8012si989598plb.630.2024.01.26.03.43.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 03:43:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-39547-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OrN8QdyZ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-39547-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-39547-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8DDF428E503 for ; Fri, 26 Jan 2024 02:38:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 54FC99465; Fri, 26 Jan 2024 02:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="OrN8QdyZ" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29EA267C66; Fri, 26 Jan 2024 02:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706236694; cv=none; b=g97IhEiLfqZJCun+THJw0eESgAvrme9olMMOXug5beYiGf1Q3drypj+0Yg+GmLY1YuV83B2fuKKECEoyx8+2+UxGNi9X2EXWX46Djyn7SEGtWx50QcwO7PdsUFIyad8cVKCZAP9l64uMg3mWC3hNJJbXAlphox6cbeaJhze4J2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706236694; c=relaxed/simple; bh=nWa2dEMXl6ypPEqUGRQ2M3mnbCfR2mDPSDM2usegB3w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jrWqEBnXrv9TNLuCnFE7KRvm/Fm3L1W7Sesr7xW1aDUKoFs2GjuYV9KlbtqGVPxwPTB5+SA3cUP8iAuJz4mZCjCsWx67yFvEgmYayHJ6NVyHKtIVHzAupJV444lOUBz18601x792hKKCsQFzMdsG0bizeIuKL0Gs1m/nfsubYYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=OrN8QdyZ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Qd3nlym//LAlFHkady1BwwInKwCk8mDwSQ8io13WFIE=; b=OrN8QdyZszp6d1b56uObl4eelP V9TYkudRghzXlSB2hJe1teeqmEyEONz51wj6fvf+Roy490GD/qwhhTWop1afWX4ulECwMyG2bB04I 7m8BaOdmGj9k2kRaFQskcfSI11CXRguxZUdUVbOz3U3WrwHjaCDB/df5JPXObcutKvVM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rTC6a-0068q8-4r; Fri, 26 Jan 2024 03:38:08 +0100 Date: Fri, 26 Jan 2024 03:38:08 +0100 From: Andrew Lunn To: Hariprasad Kelam Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, sbhatta@marvell.com, gakula@marvell.com, sgoutham@marvell.com Subject: Re: [net-next PATCH] octeontx2-pf: Add support to read eeprom information Message-ID: <1c39b3eb-0616-4214-bcfa-aaba1bd4e4a4@lunn.ch> References: <20240125112133.8483-1-hkelam@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240125112133.8483-1-hkelam@marvell.com> On Thu, Jan 25, 2024 at 04:51:33PM +0530, Hariprasad Kelam wrote: > Add support to read/decode EEPROM module information using ethtool. It looks like you have a very primitive firmware here, which can only return the first page of the SFPs EEPROM. What are your plans to make this fully featured? Ideally you should not be using this API, but the newer API which indicates what page you would like to read. > Signed-off-by: Christina Jacob > Signed-off-by: Hariprasad Kelam > Signed-off-by: Sunil Goutham These seem to be in the wrong order. Andrew