Received-SPF: pass (google.com: domain of linux-kernel+bounces-40157-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20231215160637.842748-1-masahiroy@kernel.org> <20240122141203.CWe3n5rG@linutronix.de>
In-Reply-To: <20240122141203.CWe3n5rG@linutronix.de>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Fri, 26 Jan 2024 22:56:11 +0900
Message-ID: <CAK7LNASSi78o-Tg24P2uDy1KhUKP8FBrzcn1JhvWrgpoR_mgpA@mail.gmail.com>
Subject: Re: [PATCH v2] kbuild: resolve symlinks for O= properly
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kbuild@vger.kernel.org, Nicolas Schier <n.schier@avm.de>, 
	Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, 
	Nicolas Schier <nicolas@fjasle.eu>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2024 at 11:12=E2=80=AFPM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> On 2023-12-16 01:06:37 [+0900], Masahiro Yamada wrote:
> =E2=80=A6
> > Using the physical directory structure for the O=3D option seems more
> > reasonable.
> >
> > The comment says "expand a shell special character '~'", but it has
> > already been expanded to the home directory in the command line.
>
> It might have been expanded, it might have not been expanded. Having a
> shell script:
> | #!/bin/sh
> |
> | exec make O=3D~/scratch/mk-check defconfig
>
> with bin/sh =3D dash results in:
>
> | make[1]: Entering directory '/home/bigeasy/linux/~/scratch/mk-check'
>
> while bin/sh =3D bash expands the ~ properly before for O=3D. Would it be
> too much to ask, to expand the ~?


Not only O=3D.


If the shell does not expand the '~' character,
there are more variables that do not work as expected.

For example,


$ make CROSS_COMPILE=3D~/path/to/compiler/dir

$ make M=3D~/path/to/external/module/dir'


It is strange to require only O=3D to expand the '~' character.


So, Kbuild should be agnostic about '~'. This is consistent.


>
> Sebastian
>


--=20
Best Regards
Masahiro Yamada