Received-SPF: pass (google.com: domain of linux-kernel+bounces-40179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 26 Jan 2024 15:25:50 +0100
From: Joel Granados <j.granados@samsung.com>
To: Jason Gunthorpe <jgg@nvidia.com>
CC: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Kevin
	Tian <kevin.tian@intel.com>, Jean-Philippe Brucker
	<jean-philippe@linaro.org>, Nicolin Chen <nicolinc@nvidia.com>, Yi Liu
	<yi.l.liu@intel.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, Longfang
	Liu <liulongfang@huawei.com>, Yan Zhao <yan.y.zhao@intel.com>,
	<iommu@lists.linux.dev>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 01/16] iommu: Move iommu fault data to linux/iommu.h
Message-ID: <20240126142550.jeq2fszun5xvjelf@localhost>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="cfolaexkjjaoso2l"
Content-Disposition: inline
In-Reply-To: <20240125134337.GN1455070@nvidia.com>
CMS-TYPE: 201P
References: <20240122054308.23901-1-baolu.lu@linux.intel.com>
	<20240122054308.23901-2-baolu.lu@linux.intel.com>
	<CGME20240125091737eucas1p2091d853e27e669b3b12cea8ee3bbe34e@eucas1p2.samsung.com>
	<20240125091734.chekvxgof2d5zpcg@localhost>
	<20240125134337.GN1455070@nvidia.com>

--cfolaexkjjaoso2l
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 25, 2024 at 09:43:37AM -0400, Jason Gunthorpe wrote:
> On Thu, Jan 25, 2024 at 10:17:34AM +0100, Joel Granados wrote:
> > On Mon, Jan 22, 2024 at 01:42:53PM +0800, Lu Baolu wrote:
> > > The iommu fault data is currently defined in uapi/linux/iommu.h, but =
is
> > > only used inside the iommu subsystem. Move it to linux/iommu.h, where=
 it
> > > will be more accessible to kernel drivers.
> > >=20
> > > With this done, uapi/linux/iommu.h becomes empty and can be removed f=
rom
> > > the tree.
> >=20
> > The reason for removing this [1] is that it is only being used by
> > internal code in the kernel. What happens with usespace code that have
> > used these definitions? Should we deprecate instead of just removing?
>=20
> There was never an in-tree kernel implementation. Any userspace that
> implemented this needs to decide on its own if it will continue to
> support the non-mainline kernel and provide a copy of the definitions
> itself..
>=20
> (it was a process mistake to merge a uapi header without a
> corresponding uapi implementation, sorry)
Thx.
This makes sense and its actually a good thing that we remove it.

Best
>=20
> Jason

--=20

Joel Granados

--cfolaexkjjaoso2l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmWzwO4ACgkQupfNUreW
QU/0uAwAir1ZIFyTWLN4Gl6xuLdD715v4GjX2rIbKiuoopx8JXVvnFYNqNQ447CJ
miCjmXFZmCcaAzTdhkt8D7heb4jFbKPIvFB66z1ZUfWrapacs+/zDvFzBivwmFwR
0k43yQN/LkWuQq5hLZVPQ7ZXMeUJAeVz/tMTOZbORvoAGkIZBT/cWbXQIsmTGSNd
nY+dGerPPMBWPDk0XJCFDY52wTirS1IveWxUP21ZfFXEZWLxhrAuX8bSEMgC4zIA
8pi2HJX8it7fFAg4ZXf7ZaNKskzR77rxjSt6DYkTApj0lDukEcG6Y2oo1zvwCD5V
fc7nUcPQ65oIBEDgtBlIxK3y2XmFmUEQZOax11+S9qUuhxB3dnHFM62wtdz4kohW
N76R19C4+R3tEZngI1eC/FvfW6Izv+FDxOnLlC2S3roPopY2qhUHhVO3NrfAuThY
Qfdn3dYXrVjaxAooliArvF/Ut0+Ly8vOeDioeKmk5HG123kvGEPSytgEXzvjDdbi
a7pwsiZN
=VqiW
-----END PGP SIGNATURE-----

--cfolaexkjjaoso2l--