Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp641414rdb; Fri, 26 Jan 2024 06:35:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWhUZFFC8OmnpP1xDP1yBBT5S29sDZ+zaiO0HqHpi3zdSEcWzeLEDDSmwhS8e+BIhmazfH X-Received: by 2002:a05:6a20:da91:b0:19c:64a5:2162 with SMTP id iy17-20020a056a20da9100b0019c64a52162mr1722362pzb.20.1706279740182; Fri, 26 Jan 2024 06:35:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706279740; cv=pass; d=google.com; s=arc-20160816; b=qYFXlsrMWFfx3ZF/s4j3yu837HQbm/fkoZfq6HW5BKWV9MB1oYuDLAbgSxRZUy47sj 0AGMc6hTzUDLCDTybQp0BuEE9365/XDXm5MVucKdPMn6fQd+OXFCj+e43SGTEauyAc4E JsxXPO10xvu2ECnbqgruPZuU9zOXrkSgEAKKbUSrZrYJE7n0+Qlu/Ol50zWtTyrQ5q2y Wu8/8CglYMggGiEahBYKoZk5nZ52QEl/bkBJlI6lAwQj97Lkcw39/xrNdGoACoLsVpUs dz+cMmfZEvwfuITX3ZYdqO5H/aCLEq3e1RKgIOydNHFcC2/bs/BxijcVpu//PB8Cd9An krUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=/OnZhArMqkGsBweDf4EHksg+nR8ZzNCqWscmGw8BMTY=; fh=0799RN4ykQ4+jvLAJmEx+ACgrWnRa1O2MTpfyZ7u4jo=; b=MiOoDjFz0+86fPM9Y7sQCKhtoBcC+UMU74PRDfm322kxbFco+7hC+Xt7UKSipS2DHq OF27EvcQf0e/7WKwEPEFfrjdGw6jyRD9oJ0SYtb2wgnZoOU8A/ZjGLYeD/kJ5J79dZCY FOcvLRgQdRJflG7CWxoiXfeNZyFdGOJ44ubxigGNSZWAJ1UpUlKWNGj0yAZGkFMRV51u 1H82FORMtRSjfDUaMmXnF8G4Kqjin3devrhp8YHQFdTncGFpsrGS6WilScGV3Mj8q8L5 ptVsJysN/lf9fcfzMGn8Lt0lmooYIUPKNyTUB8Tl7cCc3sYiliwyx1/WhxZ9qD6m8N4Q +YCQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WkWuuKvO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-40191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40191-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cb7-20020a056a02070700b005cec854edacsi1230968pgb.371.2024.01.26.06.35.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 06:35:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WkWuuKvO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-40191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40191-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D00DB281C2D for ; Fri, 26 Jan 2024 14:35:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7584B1BDF8; Fri, 26 Jan 2024 14:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WkWuuKvO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9025F134A6; Fri, 26 Jan 2024 14:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706279735; cv=none; b=BgnaYTcEw3fBRWZElhdjeTUoO94op191u8mDj6HBkWMnEc83n47je1M8Y4IPti+MULxL8IZuwZ3IW2iIH18NJobCMqjGkTo8sPiiX5zg/GPxU7M8W2Aa7QkMd8KXnTuXAa69kcnmK0AgAIkkcshuah65KqvDGUXMrvZ6JRy76O0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706279735; c=relaxed/simple; bh=wLiIzYIhleVyS3ZVSkO9myhj/MpErH5be7lV5PedklI=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=fNw6NONS0sBrBLgWpPGXZR8vz5tQ3GAwhtoypJQV/wGLmqIgoEp224PlsAXlXSowwxD8KrxkjnGFdc6KMh/fwrU3dnfFlIc7F7j6CcwX9jgi1dhSfMA0Suj2WnioH/N0dO42diGP2ke2wqFaR05yYCfpE4gc7F4qvlnn8hsIIGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WkWuuKvO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 095CAC43390; Fri, 26 Jan 2024 14:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706279735; bh=wLiIzYIhleVyS3ZVSkO9myhj/MpErH5be7lV5PedklI=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=WkWuuKvO0EVVyqdOkVXXtJbEQzRvi29m7dTop9sXA165hVao6tAfDW4XPsKnwVY0b xtysDIuvSscM6jC8QMlxENeep34q8vdt73xL53ONoCnaVNmb6rcJ2vjGbMdNpFfAjX WsdvuHWB0PFV4dzfLDE2JHBMhG0uJtpTGKf64gVm61eHcqkK7F2JHycn+bTZxi6ux2 V9AlELRqaZVyiDR73Nat3CfjxWWJVfqKaUbZAhefCBoEWJ/xnuAvqs/rvsEe4KkyIU XFljPZs7CTd3RAMWCl+0SVMRVqZ5eNHkRgjUIY4s1EtSfw4sqI6GZF6pxytuhwKUmg tLwPeVyv9Lz3w== From: Mark Brown To: David Lechner Cc: David Jander , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240125205312.3458541-2-dlechner@baylibre.com> References: <20240125205312.3458541-2-dlechner@baylibre.com> Subject: Re: [PATCH] spi: fix finalize message on error return Message-Id: <170627973371.36139.11882822858180324422.b4-ty@kernel.org> Date: Fri, 26 Jan 2024 14:35:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-a684c On Thu, 25 Jan 2024 14:53:09 -0600, David Lechner wrote: > In __spi_pump_transfer_message(), the message was not finalized in the > first error return as it is in the other error return paths. Not > finalizing the message could cause anything waiting on the message to > complete to hang forever. > > This adds the missing call to spi_finalize_current_message(). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: fix finalize message on error return commit: 8c2ae772fe08e33f3d7a83849e85539320701abd All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark