Received-SPF: pass (google.com: domain of linux-kernel+bounces-40180-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 26 Jan 2024 15:26:26 +0100
From: Joel Granados <j.granados@samsung.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
CC: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin
	Murphy <robin.murphy@arm.com>, Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian
	<kevin.tian@intel.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>, Yi Liu <yi.l.liu@intel.com>, Jacob Pan
	<jacob.jun.pan@linux.intel.com>, Longfang Liu <liulongfang@huawei.com>, Yan
	Zhao <yan.y.zhao@intel.com>, <iommu@lists.linux.dev>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v10 01/16] iommu: Move iommu fault data to linux/iommu.h
Message-ID: <20240126142626.4apu4wxmc3ypqmhz@localhost>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="kepxqkqwvuznsvic"
Content-Disposition: inline
In-Reply-To: <95ff904c-4731-46e2-ad3b-313811a3c2f2@linux.intel.com>
CMS-TYPE: 201P
References: <20240122054308.23901-1-baolu.lu@linux.intel.com>
	<20240122054308.23901-2-baolu.lu@linux.intel.com>
	<CGME20240125091737eucas1p2091d853e27e669b3b12cea8ee3bbe34e@eucas1p2.samsung.com>
	<20240125091734.chekvxgof2d5zpcg@localhost>
	<95ff904c-4731-46e2-ad3b-313811a3c2f2@linux.intel.com>

--kepxqkqwvuznsvic
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 25, 2024 at 07:21:53PM +0800, Baolu Lu wrote:
> On 2024/1/25 17:17, Joel Granados wrote:
> > On Mon, Jan 22, 2024 at 01:42:53PM +0800, Lu Baolu wrote:
> >> The iommu fault data is currently defined in uapi/linux/iommu.h, but is
> >> only used inside the iommu subsystem. Move it to linux/iommu.h, where =
it
> >> will be more accessible to kernel drivers.
> >>
> >> With this done, uapi/linux/iommu.h becomes empty and can be removed fr=
om
> >> the tree.
> > The reason for removing this [1] is that it is only being used by
> > internal code in the kernel. What happens with usespace code that have
> > used these definitions? Should we deprecate instead of just removing?
>=20
> The interfaces to deliver I/O page faults to user space have never been
> implemented in the Linux kernel before. Therefore, from a uAPI point of
> view, this definition is actually dead code.
thx for the explanation.
I was thinking it was something like that. Just wanted to make sure.

Best

--=20

Joel Granados

--kepxqkqwvuznsvic
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmWzwRIACgkQupfNUreW
QU8AIAv/U/z6MVZy+cyG1NCYzxkxy8xooBuWMOZCurDu0a7SdV6un/4KU9r5sFyb
mdt3SKwOc86g9Zn0ZAGpxaXxAjCKCq67OqSp3sz3MPUeADEPGDYd0ousIF+W/ABq
R/NB6SF5ZGLad7tYNcbZPLtugUAz7piU75kPYY68L0/Oj4HkZ/oiXdeFYPJA4O1N
hm4Pv/4X73kq/EpWGcWGxDg7RVffwFFnaep5OFgB/39zNyZjfvT7VMMuacGAeZ0p
kCeqjKu+TsyKl+qaQJBv3oLvtSuFw6fqkPEASxRYX6Of+YI+Bx6Tqnkw/alpaWyA
tWR1U8pgunDIflngqdQN65gBhWSIJNRc4qHQP+fpG62Z2AxtzgZIJ3UMxsshA8F3
JOgewm/BMVQZBOGA5RwdidhHsgNlzDy/YkSP7e02U7dHmrwxAeb5am3QuBmxLkLQ
vgVM+k36EJGQmApfroICCsThRVsAkaeWWXUMimY11M71P0GzGiKs2ytL4t+rrWrR
mEQ5YGOe
=1qb4
-----END PGP SIGNATURE-----

--kepxqkqwvuznsvic--