Received-SPF: pass (google.com: domain of linux-kernel+bounces-40253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <fd50d641-8090-4067-b4da-5b4cf131aabc@ieee.org>
Date: Fri, 26 Jan 2024 09:15:33 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH][next] net: ipa: remove the redundant assignment to
 variable trans_id
Content-Language: en-US
To: Simon Horman <horms@kernel.org>, Colin Ian King <colin.i.king@gmail.com>
Cc: Alex Elder <elder@kernel.org>, "David S . Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
 kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240116114025.2264839-1-colin.i.king@gmail.com>
 <20240116193152.GD588419@kernel.org>
From: Alex Elder <elder@ieee.org>
In-Reply-To: <20240116193152.GD588419@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 1/16/24 1:31 PM, Simon Horman wrote:
> On Tue, Jan 16, 2024 at 11:40:25AM +0000, Colin Ian King wrote:
>> The variable trans_id is being modulo'd by channel->tre_count and
>> the value is being re-assigned back to trans_id even though the
>> variable is not used after this operation. The assignment is
>> redundant. Remove the assignment and just replace it with the modulo
>> operator.
>>
>> Cleans up clang scan build warning:
>> warning: Although the value stored to 'trans_id' is used in the
>> enclosing expression, the value is never actually read from
>> 'trans_id' [deadcode.DeadStores]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Colin, net-next is open now and you are welcome to send v2 of
this patch.
     https://netdev.bots.linux.dev/net-next.html

					-Alex

> 
> ## Form letter - net-next-closed
> 
> [adapted from text by Jakub]
> 
> Hi Colin,
> 
> The merge window for v6.8 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations.
> We are currently accepting bug fixes only.
> 
> Please repost when net-next reopens on or after 22nd January.
> 
> RFC patches sent for review only are obviously welcome at any time.
> 
> See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
> --
> pw-bot: defer