Received-SPF: pass (google.com: domain of linux-kernel+bounces-40300-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <4dd2cf49-9fd1-4ad7-81ea-8de93e8b27d1@amd.com>
Date: Fri, 26 Jan 2024 09:47:03 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 7/7] Documentation: cpufreq: amd-pstate: introduce the new
 cpu boost control method
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706255676.git.perry.yuan@amd.com>
 <1be9c97cafb1406a607184ea48dcdae883dc4cd0.1706255676.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <1be9c97cafb1406a607184ea48dcdae883dc4cd0.1706255676.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkZmSGxoc1RRbHdxOTF5dEpTVUtUUzVXUGlGMzBnNFkrZWUwSjRJdXRGTE92?=
 =?utf-8?B?WDN4VVZsWjVXR1JSYWlac2JVcU5CZXB0d1NaMm5XeWZ3Tk90Q1NVc2pFRHNm?=
 =?utf-8?B?SnM0L29VcDNEaUhNMVlqYWhNV2xOMUV5WUNyYWw2OEhNVm9sR0JKTi83ektQ?=
 =?utf-8?B?OWRqWU1WWEwzeFBhYUp3N2NGUE1MZTB3Q2Z5THZ2U0VYWlVQZlVsc1ExVGY2?=
 =?utf-8?B?a1NVdDM1ODdkWUFMU1QwOFd0WnpCTW94Y3RrU1lXQmI5ZGtNVEVPTlhhY2RV?=
 =?utf-8?B?U1V2aWF6WE4yelAveGh5cExjUHUzOXZRc1RwQ0VjNmhza29wU09aL2ExQ1Zs?=
 =?utf-8?B?UUtxZTV6ZWcwTXFCdlVKMHRBeWZaRXNNdnE4MWNLUmloQkVJRkZtREg4d1JC?=
 =?utf-8?B?dG9rZTIrcXI5VFRZN1pmcURNWEtTVUpKcHFTRkFmNTRFc1kyMndnMGc0VU9h?=
 =?utf-8?B?R2g1TWNWdHhTc1NCVVBPNEh5VnN6SnFxdTdqR0NOTGl0ZFBUbFMrZG5tQVhp?=
 =?utf-8?B?NGdxdnkrM0JnMVpBbWUwS1VpL0tYNVZrbEdqZWNveDQvVW9FMnRsNm5UNXNS?=
 =?utf-8?B?Z3o4c1N1VDNaWVNiQndvTHVNNGR1d3hYeFBUQWFjdTFwbWU5MEdCNXZtdlhu?=
 =?utf-8?B?NHk4RS9uSkV0NGMxTEEzUi9aK2d1aHlrbUtycHJQTHdlRWxJS3JUdExDaHNX?=
 =?utf-8?B?dHFaWFNNdUQ5dWJhZmZ1MS9yTzNueE5RcEVWZjRPcXo4bEMvYTFDSFg0VDVW?=
 =?utf-8?B?NzlGS2tBSWdodTFiWlZhdWQzTHJWQXYvU3ZYUVl5ZjZXdVdtODJpVmRwNjRV?=
 =?utf-8?B?S0hOSlR3b1RQNEorTWhBbytFckdqWEtKVGExTFdEOGV0bmQvQ0pQT0NTR1ZL?=
 =?utf-8?B?NlNmY2hmT0FibG9oL2w2OXlTTXh6YmdSeDRjZDlkVXl2S1JwUWlZdzNvUm5l?=
 =?utf-8?B?aEh2VjhZbzVEaHcwcXVPdFdwT0luZ0ZKdzRpcGpaV1I2Y2xSM3lzcmJDYUtu?=
 =?utf-8?B?R252L1BucjFuS2xtSnBYS3VuM0NPWGRQWkl5aWJkZDZhR1hZRm1xdkszUjNx?=
 =?utf-8?B?L0RVcGNIVE1WYm41eVVBUjgxUmVPSk9aRGp1NEdVcXk0S3pRUS92VjM1dUhY?=
 =?utf-8?B?MWFpaEZIenBlZTIyMVQxRFJ6blVRS2hDTkhGSW4vbjU2NzJGMlowU3JrTXEv?=
 =?utf-8?B?UUJIcTl6cWNLYTZnMjVMb1BXRTd1KzRiV00yUEo5TTdIWG5VYjh2ZytyK2VH?=
 =?utf-8?B?UEh3MWRFK0VYd3R6Vnl1ZHFsbXhJZ3ExN0xDZ0lBeVVwWXR2ZGh0SncxVXlY?=
 =?utf-8?B?a1pDT0JzK1F5UWZsOHJEZEN3RFBla0JVd2NBZEp5V3pSd0t3WWhIVXc5TGtq?=
 =?utf-8?B?VXMvVmRKUnhTaDY3UnVObnl3RUl5N2FYVlRSSnlBYzVUQmNnVFR5R09RYk1M?=
 =?utf-8?B?Z1N1a1VkWVB1SmhNdnBVVElpLzlzUllsd2lnT3o5b3NsTks3UTlFNnRMbnpp?=
 =?utf-8?B?RmhFNTRNeUJCUHBwbmdzWXJ6M0JsTlRkblBySlFrYmgvNE05RlcxZnQ5MDB4?=
 =?utf-8?B?RVJXWUtISlp3MGpueStWdGVPNWhuL2tWRUJqYWVRbEZyMTBuUnA1YmFRK2p4?=
 =?utf-8?B?cFBMODRXclpsdkc3WHN6cmFBV2plbzcxbnhnc1Y4c253bEdRZ3R6RlAwNHF4?=
 =?utf-8?B?c3l3Z1h4aXp3T2xmQmJYS2dMYTg5MDdoaGpQN1RzaTQ3emFkY0NQeStCZFNv?=
 =?utf-8?B?VUpvdS9UTW1GRWN6Tks5a0tvYmVKNU9pQ3YrOUx6U09oaWRsTzYyNTRFamJi?=
 =?utf-8?B?OFFpajd0Q3M0c3Q2TnJoa3MraHNmUitKRzYxeVBNNE5xVDYxS3QwYm8xUldx?=
 =?utf-8?B?OUFac0EyVjhIVXhkbElSQ0ErL0pmUWxja0haekg0eFhWZGs0eGROdTVCV0tZ?=
 =?utf-8?B?S3oxMExrRkF0RUJxeVprSDAzQzVXNHdYSXdFSytCbm15YWZzbGkvQzU5LzBr?=
 =?utf-8?B?S0ZSL0hNZU1DbitHSmQxVDVFQXI1OElUQlc4RTN5cnBYUTlJMXd1YnJqKzNN?=
 =?utf-8?B?YlZLY3NTK2dxd0xtT2VUWitEVVpxTWx6VnI5aEJyN2tyMXVZR1U4d0tCcUZD?=
 =?utf-8?Q?rR8SlroP0f9J+8QXQlb13LcU/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 395b010c-44b2-4291-6836-08dc1e860c17
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 15:47:05.8527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bxuvK2HcUYRdSSMf0VsmRu4sKMR0gBLwW/V8P8VZf7g6rLNhC2tA6OmjpmDn+MYS6yhQFQat6j/qldMePY6NKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5048

On 1/26/2024 02:08, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> Introduce AMD CPU frequency boosting control sysfs entry which userd for
> switching boost on and boost off.

Typo in this sentence.

> 
> If core performance boost is disabled while a core is in a boosted P-state,
> the core automatically transitions to the highest performance non-boosted P-state
> The highest perf and frequency will be limited by the setting value.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 1cf40f69278c..d72dc407c4db 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -385,6 +385,17 @@ control its functionality at the system level.  They are located in the
>           to the operation mode represented by that string - or to be
>           unregistered in the "disable" case.
>   
> +``cpb_boost``
> +        Specifies whether core performance boost is requested to be enabled or disabled
> +        If core performance boost is disabled while a core is in a boosted P-state, the
> +        core automatically transitions to the highest performance non-boosted P-state.
> +        AMD Core Performance Boost(CPB) is controlled by this new attribute file which
> +        allow user to change all cores frequency boosting state. It supports both
> +        ``active mode`` and ``passive mode`` control with below value write to it.

Does it also support guided mode?

> +
> +        "0" Disable Core performance Boosting
> +        "1" Enable  Core performance Boosting
> +
>   ``cpupower`` tool support for ``amd-pstate``
>   ===============================================
>