Received-SPF: pass (google.com: domain of linux-kernel+bounces-40303-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <81830013-a956-4dd1-b3b7-88c419de77b3@amd.com>
Date: Fri, 26 Jan 2024 09:54:26 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/7] cpufreq: amd-pstate: fix max_perf calculation for
 amd_get_max_freq()
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706255676.git.perry.yuan@amd.com>
 <675807d1888f77d7d0f3bc335b5bb3bd2c023670.1706255676.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <675807d1888f77d7d0f3bc335b5bb3bd2c023670.1706255676.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OER3SUhkbHgwYUFiMFlpY1owZ3c3OTN3T1ZHVGgxenpJdGhBbTUyVCtxYktX?=
 =?utf-8?B?UVZ2dnZQdmp2L1dZR2I1RFJTLzJxM1Nlcmx3RkJjODBUTGZ3VUVnRnZQNW5Z?=
 =?utf-8?B?ZUlFUnU3YTdhVU5NS0UyK3VuN0xkOU5ad1VXU01zSUI0WUt6cVIwNFRkMW1B?=
 =?utf-8?B?WkozUWVvNzBlN0dzNklET0VnQzJIdjN0YXc3V3dnS2JPdUtqdDhqMnpObXNP?=
 =?utf-8?B?Ly8yM1k4aVpUZWczbGFUclZLYmdieXNQcUoyN0NOQmN2ejlMMjlRS2xiaTJD?=
 =?utf-8?B?d3AzTGRPSnFrWmZuZW1oVVN1alZHY21LVEFKZ3dXbUQ5NU5IZFlzazd2M2NU?=
 =?utf-8?B?aEVsOWloNDNZYUtlTWtGTGZEVFZ3TTJDTEZHYjF0NlRWMS9iNlBlc1hYRDlY?=
 =?utf-8?B?SEtvanhYbTdtcllvOGJTeURwOFdVd01pSlU0SUhwSm9SNXhOay9FN0htSW9a?=
 =?utf-8?B?eEdJalBNdE5idE9YR0kxVjljeEhqOG4wQWFRZytmK05GOGtVOVVneFZTWFQ2?=
 =?utf-8?B?K2hDVys0OEVNSFJ1ZWVXVDAyaTY0YkFCdndSei9MT1VKYXBENHorRzc1eDc4?=
 =?utf-8?B?K0VqamNwVDdBc3Zac3AzZXhkZXJ5RlpqVGlHRU4zUys2dFBpQUJQV3RIVk9X?=
 =?utf-8?B?ZFBPZmk0RG54YTVQUGlHM3JjNk9DMjJxdHRvclgxaVJWWWNxMlVKbVQ4d0Fx?=
 =?utf-8?B?U24ySVpJZzRVNG1iUHBUeUtqZWVRcXRNODUvMUNDd3pTQnZKR1dWV2s3bXhm?=
 =?utf-8?B?T2VlRU9NWE9Ea3V0d3VPUUU1WUhtcytjMkw4aXZVeWxrSGQ5eDRkYytMSVJK?=
 =?utf-8?B?Y1VVcVZvNjJxS0wwT0VHOWRlTDMwN1BKNG4vUXdEYS80UTB6UDBHWnhOdlVx?=
 =?utf-8?B?bDNaZUEyWkNxcm0yT1p0Wm1BT0dGbS82eDZ2VFBST1lWOWVFMXE1cUhxdEpB?=
 =?utf-8?B?R0Q4QUg3UmpsNUo1bWN5bTY2cWd3VUlrK0JuRWhGSmRZdm5qZEsvWVlSUkx1?=
 =?utf-8?B?RzB1RStsUVlvNnE3bDNleGUxWXBPYWpuMHNXWnJ1QnJzc2lwQXBwaC80THRa?=
 =?utf-8?B?UkdTS3hkV3pnbG9vbldHaUJ2dW1CdnI3OVJrY3diQnBXdTZzVHpoSGxDdmpG?=
 =?utf-8?B?ckRQOFJtTTRkWnBxZjNFL2VyNDFva2xINmszWkl5UVYwd09Rd2VTNGx1WHAy?=
 =?utf-8?B?cEFJVzNTdUtOMHlGYWh3UEtaaForaVpjbVd2RW0wSXBiSGllME14a21rckQ1?=
 =?utf-8?B?TmZnS2hTa0RLZEtpazh6WktzRnEvQ3VXaHRvSDdNbTNUdFBhRFg3aElUc1JK?=
 =?utf-8?B?YkpscU9LR0ZKS09hZDA4OHh2R1k5NkxDc0RTYUhVZXJTemU5SitFZmkwUS9T?=
 =?utf-8?B?ZnkreHIzNG8wZHZnWkwwdUlUMUxqWWZLTGJtVE1vSmZXNVdZQmppWmZqUG5t?=
 =?utf-8?B?Qm1jM09maW9zZzJVR2hOUkNPS3dncDZuNm5ERlNRd24yd2NiOWxITjM5YnJq?=
 =?utf-8?B?ekNGVktQWmhrRVFuWmxvaUVOY2srZ0V1SmRTMUJXeldzV2dHMXZPOFRBY3M1?=
 =?utf-8?B?OGlOSjBqeEJOZnZzR2hDVmhhY25jMjZpWkswR2U5T243eC9FRTRON0ZkcFIy?=
 =?utf-8?B?K3lOV2dQenNpK2Eyb1IvdEFqbGh4cTVlS1l0UlJHOUs0UUlwYTJkbHZWYjZO?=
 =?utf-8?B?TnNNTHZGdlF5UGYrdUpuSEFLT0hRdHplM3c4N1N4TU1kemVXRllRVjFYbkZn?=
 =?utf-8?B?Q0VDOGdwK1RJcUNIbmZ4dERGak9WRVZ2SnBEZ2taTzFaRDZzVE9xa1NtSEtX?=
 =?utf-8?B?MUJuZ2JIWGNtaWkwOGViT3gybzdhZjRjdlV1OGYrcnJ1d3N6S2ZYdTRKTVdH?=
 =?utf-8?B?bGcza0Q1Mk1FemZCb1dlSzI3NytGOVFjcUFwcURpanFyYm5zVzVZdUh4aFQr?=
 =?utf-8?B?ZmZlTURocWZNTlU1MnlScmpXMzQ0QmVhV3QyQkk5UG5uc25WZm43NWxqR1pS?=
 =?utf-8?B?SnlxemhsQTJPcmlZaDkvY1U4YnJHclErQXBwV0dQd29vL3hrdlF4S3RiQ282?=
 =?utf-8?B?bUFGbzVPVE9oUkNiRjlMZnN6SXRNQjhtNm9zZ0JVTndqNTBNU1doQmJ2dVln?=
 =?utf-8?Q?QX+sAOIxekV/SprlQTqE96gpr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f3a151a-6bc2-4093-6791-08dc1e871422
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 15:54:28.8811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8H1tOpZOuii+zPu5tnm+LBBWeJ31naxDAnfhB8lPi5S0abRQ3NmTsilRbI6uTU6OFsJ06ft5l2k6QLMEXUtYMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6456

On 1/26/2024 02:08, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> When CPU core Precision Boost state changed, the max frequency will also
> need to be updated according to the current boost state, if boost is
> disabled now, the max perf will be limited to nominal perf values.
> otherwise the max frequency will be showed wrongly.

What about the previous cppc_req?  Shouldn't it be explicitly updated as 
a result of this too?

> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index b37bea7440b9..3286d72f375e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -599,6 +599,10 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata)
>   	nominal_perf = READ_ONCE(cpudata->nominal_perf);
>   	max_perf = READ_ONCE(cpudata->highest_perf);
>   
> +	/* when boost is off, the highest perf will be limited to nominal_perf */
> +	if (!global.cpb_boost)
> +		max_perf = nominal_perf;
> +
>   	boost_ratio = div_u64(max_perf << SCHED_CAPACITY_SHIFT,
>   			      nominal_perf);
>