Received-SPF: pass (google.com: domain of linux-kernel+bounces-40319-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 26 Jan 2024 16:16:52 +0000
From: Conor Dooley <conor@kernel.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Peter Rosin <peda@axentia.se>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, mazziesaccount@gmail.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: afe: voltage-divider: Add
 io-channel-cells
Message-ID: <20240126-cinnamon-flatware-e042b5773f17@spud>
References: <20240126115509.1459425-1-naresh.solanki@9elements.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="wvdRtw+17GEGpdoo"
Content-Disposition: inline
In-Reply-To: <20240126115509.1459425-1-naresh.solanki@9elements.com>


--wvdRtw+17GEGpdoo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Fri, Jan 26, 2024 at 05:25:08PM +0530, Naresh Solanki wrote:
> Add #io-channel-cells expected by driver. i.e., below is the message
> seen in kernel log:
> OF: /iio-hwmon: could not get #io-channel-cells for /voltage_divider1
>=20

> TEST=3DRun below command & make sure there is no error:
> make DT_CHECKER_FLAGS=3D-m dt_binding_check -j1

This shouldn't be in the commit message.

>=20
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/afe/voltage-divider.ya=
ml b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> index dddf97b50549..b4b5489ad98e 100644
> --- a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> +++ b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml
> @@ -39,6 +39,9 @@ properties:
>      description: |
>        Channel node of a voltage io-channel.
> =20
> +  '#io-channel-cells':
> +    const: 1

The example in this binding looks like the voltage-divider is intended
to be an "IIO consumer" but "#io-channels-cells" is an "IIO provider"
property.

Are you sure this is correct?

> +
>    output-ohms:
>      description:
>        Resistance Rout over which the output voltage is measured. See ful=
l-ohms.
>=20
> base-commit: ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7
> --=20
> 2.42.0
>=20

--wvdRtw+17GEGpdoo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbPa9AAKCRB4tDGHoIJi
0h7+AP9saceOMyUzytSlRwVy5YzQaZ0LZvk31o2TRV06wkAmKAEAoI8Ut9mMne7U
uJOtKAI2Ng+E6A+XyIl9WbuaYrcXqwE=
=kzaD
-----END PGP SIGNATURE-----

--wvdRtw+17GEGpdoo--