Received-SPF: pass (google.com: domain of linux-kernel+bounces-40323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Jan 2024 16:20:18 +0000
From: Conor Dooley <conor@kernel.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	mazziesaccount@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: Add regulator-compatible property
Message-ID: <20240126-deflate-ashy-158a91efb25a@spud>
References: <20240126114614.1424592-1-naresh.solanki@9elements.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="lQRYenakLFWQ8EtE"
Content-Disposition: inline
In-Reply-To: <20240126114614.1424592-1-naresh.solanki@9elements.com>


--lQRYenakLFWQ8EtE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 26, 2024 at 05:16:14PM +0530, Naresh Solanki wrote:
> Add regulator-compatible property.

Why? I can see that this is what you did, but there's no justification
for it.

grepping for this property, the first thing I see is:
rg "regulator-compatible"
drivers/regulator/of_regulator.c
389: * based on either the deprecated property regulator-compatible if pres=
ent,
428:					"regulator-compatible", NULL);
486:		name =3D of_get_property(child, "regulator-compatible", NULL);


The property is deprecated, so you'll need twice as good a justification
for adding it!

> Also update example.
>=20
> TEST=3DRun below command & make sure there is no error
> make DT_CHECKER_FLAGS=3D-m dt_binding_check

Same comment here as my other mail.

Thanks,
Conor.

>=20
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  Documentation/devicetree/bindings/mfd/maxim,max5970.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml b/D=
ocumentation/devicetree/bindings/mfd/maxim,max5970.yaml
> index 0da5cae3852e..75175098cbc2 100644
> --- a/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml
> @@ -74,6 +74,9 @@ properties:
>              description: |
>                The value of current sense resistor in microohms.
> =20
> +          regulator-compatible:
> +            pattern: "^SW[0-1]$"
> +
>          required:
>            - shunt-resistor-micro-ohms
> =20
> @@ -111,6 +114,8 @@ examples:
> =20
>              regulators {
>                  sw0_ref_0: sw0 {
> +                    regulator-compatible =3D "SW0";
> +                    regulator-name =3D "p5v";
>                      shunt-resistor-micro-ohms =3D <12000>;
>                  };
>              };
> @@ -145,9 +150,13 @@ examples:
> =20
>              regulators {
>                  sw0_ref_1: sw0 {
> +                    regulator-compatible =3D "SW0";
> +                    regulator-name =3D "p5v_aux";
>                      shunt-resistor-micro-ohms =3D <12000>;
>                  };
>                  sw1_ref_1: sw1 {
> +                    regulator-compatible =3D "SW1";
> +                    regulator-name =3D "p3v3_aux";
>                      shunt-resistor-micro-ohms =3D <10000>;
>                  };
>              };
>=20
> base-commit: ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7
> --=20
> 2.42.0
>=20

--lQRYenakLFWQ8EtE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbPbwQAKCRB4tDGHoIJi
0mphAP9mNAqgCfGnG2oZT03eR5lo8zVtxGVA3e31U4pT35l3oAEAmSR0t82lnGuR
Ko9mPTkVro5PyNGNvBvn9QwRTqP8qAc=
=FJF6
-----END PGP SIGNATURE-----

--lQRYenakLFWQ8EtE--