Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp709856rdb; Fri, 26 Jan 2024 08:21:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvaBXfa91Qq4oBZVoq8ta2mBBobx7xFvDeMrVXlsJLzr1os1gk+atezkQMub2haVLrhHU3 X-Received: by 2002:aa7:c683:0:b0:55c:febc:d972 with SMTP id n3-20020aa7c683000000b0055cfebcd972mr685792edq.18.1706286084642; Fri, 26 Jan 2024 08:21:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706286084; cv=pass; d=google.com; s=arc-20160816; b=K5mqtA2O03rtWgRhbLVbKcUbTqtinfPrymNtQc3xWB8iGtUfA+TmKxK1oX7OpqmBsA AEQVfcT7mCWsGve/GfWS8Ugbq1QfcaGTnWVz8Hs6armQSFEVYwMF3vQQ7l619gxNmbYF n26+pp1yBO8vPy/c8hCUL48gSt7F2fsUCuqoXJzrXhbuRLeda8v6u7Vxsmh3nDAFBobn ngYYlnULuR5pYtwSsYZCoShm/fjFd1M5ROAlKX7K4y5b1MZTy0Dg/q7UgWDbWrvQSlIE c4Ng2TG2ftSJk/0omWUQsoOxTL6Zfra1O2AgrRbpUhgwSJHL5yQb4NE8+GHCQGjp8i9e pc5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XxSk9Xjv1L8fIDK7yqbqV24ThJunhw8ONOqeFPoB0kU=; fh=7MnVz9OXerfR1+lUSOiEka8f2MKOUaELkBPPyU5ajYA=; b=0sS8BN0NcwwQA8ifweHInVkr0vvjI8QXudmrkyOQD3vSzIkbFXuYMkY32soz8Bq/KL e7S+ZvPJzLYFhxcRD7qiBI2Z+/vqappAZcYmeUw8L+GNiwcgAoPhbtGCzwHzI6dmsT7v FSkP1lqVEDsa90FKFApiUsAIMbwNxu1MJ1QC041Xek/VokCqvTUCREnTrSYgKsux+fF3 g14qq+5Pu+bqyOvLLKL/JVhOPoVCkWVP3Iz89Zak3PcLrqBM4RNTqrIlByni1Ox1s5tE UkTYayZQbtTIg/1o/XTmrrz1gv+8ORHbOuyJ0A4MP1m+VRy89Vba7cBeYEHNzk2IQZLt DzdQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QINdN9B5; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-40147-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40147-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id fj22-20020a0564022b9600b00557766c0f78si842857edb.77.2024.01.26.08.21.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 08:21:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40147-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QINdN9B5; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-40147-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40147-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 121371F26461 for ; Fri, 26 Jan 2024 13:53:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DD2191B95F; Fri, 26 Jan 2024 13:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QINdN9B5" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C3F11B943 for ; Fri, 26 Jan 2024 13:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706277228; cv=none; b=FaV7D4PZ/3bizsdo1PiqqP4uUbztTEBcS2RTzHAuTWxwMi68UZnwjZJL9RcUntT5XpTjl1QGyf24ol1DojASuyqTRd+v3ojcasZXnGui5ULvL2VwOfe0a995YL6CTu2o5xpGUzw/h3IUtMHSGCyNybUn56YkJqijq8SYMiXU9Jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706277228; c=relaxed/simple; bh=9QLCMYdSDg56PB4jhgtUKPidWzlGfB8PBIuvdsq8zZE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OcTnQXqz617TdMWpvv9oOxs969IbLA9YM0mY3PFgwmVNNTnrBdJMLR3FozXddyeqwcMlTimiJVIKLqo8Y5pmAXfwIyJmNYkJToFUAOFeTSWjWNFpixpA8qQzohCK9eqynxle8ntNR4EJhnYQh356W7X4flNaL61aHW4LBkz/KJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=QINdN9B5; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XxSk9Xjv1L8fIDK7yqbqV24ThJunhw8ONOqeFPoB0kU=; b=QINdN9B5u/bXXbU/IOYFbmNxGK 8w5m+DZTQmdpidDw89k3WnUnK4Ucv0Ov+o7voooVVZLhzWqqQbrDaEgTxtsP/z51C5agMn2ffCZJB 2zq5NUJ7S6uTwTDMmpMYD522Ng8pzjp14laKMZ/gHl5W/Alb9IuGtA1+ntNQozgqyBzRvJYQpD9of n5xiWKdMjbUmi7XNv6RZFmnesoqv7yGZcuYiw2DI68VUVFKVhqYD+ASQ7fEbXghdx5Ac/w8dC9Urx kZpGrNR6cFRQ0PVq0xdT1S9wrmxgFzMDzwwsFqJKPTNSqpserY3qTnaGnVyfDk+/mLc9xpsmYTy6M VLJkGOLw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTMeQ-00000004Ftt-0Mff; Fri, 26 Jan 2024 13:53:46 +0000 Date: Fri, 26 Jan 2024 05:53:46 -0800 From: Christoph Hellwig To: Samuel Holland Cc: Sami Tolvanen , Will Deacon , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] scs: add CONFIG_MMU dependency for vfree_atomic() Message-ID: References: <20240122175204.2371009-1-samuel.holland@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122175204.2371009-1-samuel.holland@sifive.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Jan 22, 2024 at 09:52:01AM -0800, Samuel Holland wrote: > The shadow call stack implementation fails to build without CONFIG_MMU: > > ld.lld: error: undefined symbol: vfree_atomic > >>> referenced by scs.c > >>> kernel/scs.o:(scs_free) in archive vmlinux.a Well, please just provide vfree_atomic for nommu then. vfree maps to kfree which can be called from atomic context, so vfree_atomic can do the same.