Received-SPF: pass (google.com: domain of linux-kernel+bounces-40330-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 26 Jan 2024 16:24:40 +0000
From: Conor Dooley <conor@kernel.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, mazziesaccount@gmail.com,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: tda38640: Add interrupt & regulator
 properties
Message-ID: <20240126-fleshed-subdued-36bae813e2ba@spud>
References: <20240126112945.1389573-1-naresh.solanki@9elements.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qKb9f2iDT7+wsvKn"
Content-Disposition: inline
In-Reply-To: <20240126112945.1389573-1-naresh.solanki@9elements.com>


--qKb9f2iDT7+wsvKn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 26, 2024 at 04:59:44PM +0530, Naresh Solanki wrote:
> Add properties for interrupt & regulator.
> Also update example.

Feeling like a broken record, given I am leaving the same comments on
multiple patches. The commit message needs to explain why you're doing
something. I can read the diff and see what you did!

>=20
> TEST=3DRun below command & make sure there is no error.
> make DT_CHECKER_FLAGS=3D-m dt_binding_check

Same comment here as elsewhere.

>=20
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  .../hwmon/pmbus/infineon,tda38640.yaml        | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38=
640.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.=
yaml
> index ded1c115764b..2df625a8b514 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
> @@ -30,6 +30,15 @@ properties:
>        unconnected(has internal pull-down).
>      type: boolean
> =20
> +  interrupts:
> +    maxItems: 1
> +
> +  regulators:
> +    $ref: /schemas/regulator/regulator.yaml#
> +    type: object
> +    description: |

The | here is not needed, there's no formatting to preserve.

=46rom a quick check, most bindings with regulator subnodes restrict the
subnode names with patternproperties. Is there a reason you have not?

> +      list of regulators provided by this controller.
> +
>  required:
>    - compatible
>    - reg
> @@ -38,6 +47,7 @@ additionalProperties: false
> =20
>  examples:
>    - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
>      i2c {
>          #address-cells =3D <1>;
>          #size-cells =3D <0>;
> @@ -45,5 +55,15 @@ examples:
>          tda38640@40 {
>              compatible =3D "infineon,tda38640";
>              reg =3D <0x40>;
> +
> +            //interrupt-parent =3D <&smb_pex_cpu0_event>;

Why is this commented out? Please either restore it or remove it (with
justification).

Thanks

Conor.

> +            interrupts =3D <10 IRQ_TYPE_LEVEL_LOW>;

Blank line here please.

> +            regulators {
> +                pvnn_main_cpu0: vout0 {
> +                    regulator-compatible =3D "vout0";
> +                    regulator-name =3D "pvnn_main_cpu0";
> +                    regulator-enable-ramp-delay =3D <200>;
> +                };
> +            };
>          };
>      };
>=20
> base-commit: ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7
> --=20
> 2.42.0
>=20

--qKb9f2iDT7+wsvKn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbPcyAAKCRB4tDGHoIJi
0teEAQD64Q0ot/0ME0q/yFIeuCDvMzxK6MoqCM3r57v7LnmEuAEAiHZuOa/sLQC2
SpoFQjl7IHHanVwZYyRTpwKNruahDAU=
=ZOVp
-----END PGP SIGNATURE-----

--qKb9f2iDT7+wsvKn--