Received-SPF: pass (google.com: domain of linux-kernel+bounces-40342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <c2fe25b0-a51c-44b8-a454-2573fe6ac651@amd.com>
Date: Fri, 26 Jan 2024 10:31:19 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] crypto: ccp - Fix null pointer dereference in
 __sev_platform_shutdown_locked
To: Liam Merwick <liam.merwick@oracle.com>,
 Ashish Kalra <ashish.kalra@amd.com>, Tom Lendacky <thomas.lendacky@amd.com>,
 John Allen <john.allen@amd.com>, Herbert Xu <herbert@gondor.apana.org.au>,
 "David S . Miller" <davem@davemloft.net>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "stable@vger.kernel.org" <stable@vger.kernel.org>,
 Mario Limonciello <mario.limonciello@amd.com>
References: <20240125231253.3122579-1-kim.phillips@amd.com>
 <91b75885-26c0-4697-b5dd-3ebce922dd44@oracle.com>
Content-Language: en-US
From: Kim Phillips <kim.phillips@amd.com>
Organization: AMD
In-Reply-To: <91b75885-26c0-4697-b5dd-3ebce922dd44@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dW1jT2VYWmM1WVBRRmdFdzh5VUJObjdweDhsZEpSUjIrdmYwdXIydmFrS1ly?=
 =?utf-8?B?UmtPcGsxbFJoZmhtbzN4SmFQS3BldDlDWWhNQ0I3M0FySXk3ZEwyYzBuU3N1?=
 =?utf-8?B?bHBlaUo5L1htWk16VW0ydEkyLzQvdGN0ajhoN0pGaVZsK2VFUXBkYVFtTXNj?=
 =?utf-8?B?K2tLaHJ6OFRJYzVJc2xFdTZPTXg4YjlkU3dxZWdGRWowTVpWU01vcHY5TXJx?=
 =?utf-8?B?bGdyMi93QzlMQm5kL0JtclhOSE1KUXdtNkJxcW9KcUlWY1JSeGxHS21WTTZh?=
 =?utf-8?B?cm9zeTVoS2RaL2NTUC9aM2h0Zm8xNXl4bll5MHVURE1oaU9XMWVhWGIvSUdT?=
 =?utf-8?B?WXBRRTdHbmhMS2xEb2ZvRWNWdHhtTnNza05Mc0lJRnY0d3VVVUlwT0l3cDdN?=
 =?utf-8?B?K1pqUWNSVXd4Y3VOenJBTmgrSVd0YmhDVDA5RmtKeE5XdTd6MDVSSURZVVUx?=
 =?utf-8?B?Z1QzdXloTktFS0xDK1R1dzduYS82L3VlRmRrVThqSGZsdU90K1ZIMno3QmlL?=
 =?utf-8?B?RVJWUjJQOUQyQUh5aGE1Y011MGlBU3luUDhNR29BSHBsdmJHYWdLOEJDWXVS?=
 =?utf-8?B?YlBHL0RWRWYreVZtZ0hwWGk3MU9GZHl3YzFiMkhscEVQbndNMHhiNkhVZWIw?=
 =?utf-8?B?K2dvYk04VkhJOVZTUDBTL0FNZW10MldpbVJkVVR4NnV0VnBScGpCc2NDSnN4?=
 =?utf-8?B?b3JTa0tTQ2trVHJGWk84RTJHZ0tJMWNoZGdQT1Yya05tdjJjeW5qaWdldzhw?=
 =?utf-8?B?ejVyaFkwTXREZjZjajlVbVVabVQwZnJPSVNjMXVWajBQMEtYS0RRVkkza3VV?=
 =?utf-8?B?S2JDQjB1VjczSDlHaTFqVjRZV2dXN1FzanlzMEJIRDBzOVFPVjdCM1NoT1J6?=
 =?utf-8?B?eWVMd2czaGIxQ1d3VGV0eGJ4VVJURlgyV0l6RjNOYnR3Z0dmQWxSK0JWaXY0?=
 =?utf-8?B?VFdyNXIyb3piQTdvcmxJZTJnTm5hY2l3ZW93b21EZ1BUQit6RVVpVUw2UXV4?=
 =?utf-8?B?OHJKRTJ2ZXlOek9pUHgyNmhBZWpBRmNpbzdzL2V1em1EZHVLT3BLelFHWkdn?=
 =?utf-8?B?bS9HaW5sSmw2TTdQSS8wKyt6NmJuZStJUUdicTZiMW1lYmNyVkJHSVA0bStO?=
 =?utf-8?B?VWlIaVNza1dVdVd5ZEk3aDJLNVFaSkowUEFVTEMrNnA2MVpiODdXOUZYYU01?=
 =?utf-8?B?OTI1b25nOEdielkwNnVGUER3RkRJT2diNmk4WmJ2bjJFOFlzT2Z2NFI4eXk0?=
 =?utf-8?B?bHgzRTI5QjgvRnVqWHpCRGI1WHlYMGJqVDFzMlpaQUJ3dHE3Z2hObDkzcGxs?=
 =?utf-8?B?WEZ0a3lMSVFUblhPU25iNWUzU2VDZHluUEJicFo3MEtWRzQwQWl2OXllY0dR?=
 =?utf-8?B?R0lKOFFXWHJURnBPY1ZjbjRIZkVkQUgxVzBrT0g0czhTY1VsU3k0ZzlEV0Nx?=
 =?utf-8?B?Qks2RWkxK3FtdlMzM01lblh6SHgzNmpPeTJYR2tZWVJPVnpNWFVkOWxNK2xJ?=
 =?utf-8?B?RCtJbTJtNVB5SjlUaFFHbDNIcDNCZkFEeTllWUFCby9QOUxob0h0ck9TR3pN?=
 =?utf-8?B?ajJ1alZDMWZhZWZIVGxPYjRFMVNxSGNUU0lTc0xkMzh6VCtPa2RXRDRHTEQ1?=
 =?utf-8?B?QVlVNzFjc0ZXS1pObGVCSG1zZldvYkk4YTRqUnJVdDgzVWljT0dZNEhHZjhp?=
 =?utf-8?B?YzlWc1hsZGZIZUZtN3dHRStWV2pqN2d3WUQwZkVGL3puMnl2TlpZbi9ORW9Z?=
 =?utf-8?B?c0gvbEkreWQzQ1NtMStPeHlHTEduSVc2NFFRM3poY2hSVUxrR0tqWjN0enhZ?=
 =?utf-8?B?SUM0blUrLzNTYVhKakFlSU9KanQ4SVNMN2taUVUvWTF6SWp3WjJwZlgrZjZa?=
 =?utf-8?B?SExVcjBYdnY2UW9wZ3AxdFk2NWt4NUo0bzB3S21jOFlCWnpQNlRYQVRUb1VW?=
 =?utf-8?B?UnRLUG1sY2I0Yk85Z3J5bk8xVHk4UlVGZmxxQ1FyczlPVVdJMGoyZ2J0dDN5?=
 =?utf-8?B?aVd3Tmpzc1NqUFY0SkNOYzlKZGEzT2V3dTFYdjV6OEtEODVnYlVZL1lpVHp1?=
 =?utf-8?B?bmg3S1drM1ZrMlpQKytQQVBvNXBTZUs2WWZwajFLaldDRCt4cXl0WnRmZkRv?=
 =?utf-8?Q?jANl5FEpevkTytKai6DK9XpIs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14561383-c85c-46cd-6b35-08dc1e8c6a14
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6263.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 16:32:40.5186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FbQqNBSRfB1UApK3wwkm2SLguMV5cFWcVfCh/fGMGwrzyUtGGsHzO5XxsmhyVfzSW2PHMgd9i2vK8e1qtC3NSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7944

On 1/26/24 5:59 AM, Liam Merwick wrote:
> On 25/01/2024 23:12, Kim Phillips wrote:
>> Fixes: 1b05ece0c9315 ("crypto: ccp - During shutdown, check SEV data pointer before using")
> 
> checkpatch warns about SHA1 of Fixes: having more than 12 chars...
> 
> However, although 1b05ece0c931 is the last commit to change this
> functionality, I think this issue exists prior to that.
> 
> 5441a07a127f ("crypto: ccp - shutdown SEV firmware on kexec")
> might be more appropriate so that it'd get applied to linux-5.15.y
> (where 1b05ece0c931 and 5441a07a127f have been backported to also)
> This patch applies cleanly to linux-5.15.y.

1b05ece0c931 fixes 5441a07a127f, and I'm assuming Fixes: are transitive.

>> Cc: stable@vger.kernel.org
>> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
>> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
> 
> Code changes LGTM, so
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>

Thanks for your review!

Kim