Received-SPF: pass (google.com: domain of linux-kernel+bounces-40371-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 26 Jan 2024 16:48:50 +0000
From: Conor Dooley <conor@kernel.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	mazziesaccount@gmail.com, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: cy8x95x0: Minor fix & update
Message-ID: <20240126-contently-mute-4e5c1cf09e8e@spud>
References: <20240126115748.1491642-1-naresh.solanki@9elements.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="+2t8z9tC2YpU7WTh"
Content-Disposition: inline
In-Reply-To: <20240126115748.1491642-1-naresh.solanki@9elements.com>


--+2t8z9tC2YpU7WTh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 26, 2024 at 05:27:48PM +0530, Naresh Solanki wrote:
> Update maxItems to 60 for gpio-reserved-ranges.
> Add input-enable property.
> Rearrange allOf
> Update example.

Same as elsewhere, please justify the changes rather than list what can
be seen in the diff.

> TEST=3DRun below command make sure there is no error.
> make DT_CHECKER_FLAGS=3D-m dt_binding_check

Same comment as elsewhere :)

Thanks,
Conor.

>=20
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  .../bindings/pinctrl/cypress,cy8c95x0.yaml    | 28 +++++++++++++++----
>  1 file changed, 23 insertions(+), 5 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.y=
aml b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml
> index 7f30ec2f1e54..89ce0cb68834 100644
> --- a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml
> @@ -45,7 +45,8 @@ properties:
>      maxItems: 1
> =20
>    gpio-reserved-ranges:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 60
> =20
>    vdd-supply:
>      description:
> @@ -85,6 +86,8 @@ patternProperties:
> =20
>        bias-disable: true
> =20
> +      input-enable: true
> +
>        output-high: true
> =20
>        output-low: true
> @@ -101,6 +104,9 @@ patternProperties:
> =20
>      additionalProperties: false
> =20
> +allOf:
> +  - $ref: pinctrl.yaml#
> +
>  required:
>    - compatible
>    - reg
> @@ -112,9 +118,6 @@ required:
> =20
>  additionalProperties: false
> =20
> -allOf:
> -  - $ref: pinctrl.yaml#
> -
>  examples:
>    - |
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
> @@ -133,6 +136,21 @@ examples:
>          interrupts =3D <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
>          interrupt-controller;
>          vdd-supply =3D <&p3v3>;
> -        gpio-reserved-ranges =3D <5 1>;
> +        gpio-reserved-ranges =3D <1 2>, <6 1>, <10 1>, <15 1>;
> +
> +        pinctrl-0 =3D <&U62160_pins>, <&U62160_ipins>;
> +        pinctrl-names =3D "default";
> +        U62160_pins: cfg-pins {
> +                        pins =3D "gp03", "gp16", "gp20", "gp50", "gp51";
> +                        function =3D "gpio";
> +                        input-enable;
> +                        bias-pull-up;
> +        };
> +        U62160_ipins: icfg-pins {
> +                        pins =3D "gp04", "gp17", "gp21", "gp52", "gp53";
> +                        function =3D "gpio";
> +                        input-enable;
> +                        bias-pull-up;
> +        };
>        };
>      };
>=20
> base-commit: ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7
> --=20
> 2.42.0
>=20

--+2t8z9tC2YpU7WTh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbPicQAKCRB4tDGHoIJi
0txmAPwLcy4DcpIJ8errO0RavFgIri/cwB34qCN84wKAghi3fwD+Nxo6KnbflgRr
rKDokwVCP53wtpK/259VEouFIRrpTQU=
=L/dD
-----END PGP SIGNATURE-----

--+2t8z9tC2YpU7WTh--