Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp787848rdb; Fri, 26 Jan 2024 10:35:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5vYkpTEtOeRa9SuFwAqDSfi0FloJBxMryhO537462felSYbmUN+y4kDNSO9VuxG3GbHQT X-Received: by 2002:a62:ce8b:0:b0:6da:ed17:bfa7 with SMTP id y133-20020a62ce8b000000b006daed17bfa7mr280709pfg.6.1706294106396; Fri, 26 Jan 2024 10:35:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706294106; cv=pass; d=google.com; s=arc-20160816; b=LmQRfnIZtEBCG5djaaFM4ULxk8MLI2bb7/kZsuwuWK0Fiv7WypE0A6YhJVEQOEiB4c oxpq/dbI7zgy86CfCUs2O/9ik0DJW9LUaFc+f1up6Z8FjMJOZPg3DP0bkcZJ/mEc6MG3 uOqZJRc/MQljFIQMzlKLn4Cnwnfeuv4kc+gEfwNNkGdAalUMX439A9HDW0xyT5ogrGee XEh/CRsbXH9MIHZvfM+1zVsaIrPLhk8c1JH243zLhDmPqF23YY+yuDdrW5jt2di0tjqn RKc5n7STdgYCeCtPjP08SIc9HsdfU2g0IZX1jWbysDnsItRUOtVoYwLvqfUZIOji/17l o2nA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=g8fiwmPSySU4eNFj55g0a5/9A7qTajzirLf5GX98rOs=; fh=vh34dLG7ee41KOkLSVfvNGb7yu5cb6Z1FESNgL8GDr8=; b=ynaxRCDQLNYL+h2WvcVQBklmBOx/ZRbjiCZpshAV9RrgZA6gKJ3RGxTZTbHB2z4M0g rWLgsDYqUmjzOKG0Mmz/TZoVxz5ajyVkSqd6yiqc2Qh+z172+IasH1F9dIywPtFfpNJL uFil0MaZfHKgbC+rrFYA8Gn55YHYbLIi0d+oh0gRIafxeWcyOWopcnysQZNLnvVYxTc8 lOM6VP8SeCNfF60nQ+7qqZKR65BiBw2c9S0DHg6Du2ehnpdZOXNe4qVSPaJ9XUWqR+AY jLmMdw6wklmA2r6wZodJAV6ml5DFCyyJS7g6oYqiwFZcBNDnmC+CXVzNLhpiHY1J/Za8 IHBw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UwcRX1yS; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-40496-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40496-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y25-20020a056a00181900b006dddb9eb7bfsi1586817pfa.244.2024.01.26.10.35.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 10:35:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40496-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UwcRX1yS; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-40496-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40496-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E057E2828C3 for ; Fri, 26 Jan 2024 18:35:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 32A242231C; Fri, 26 Jan 2024 18:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UwcRX1yS" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19ACC22301 for ; Fri, 26 Jan 2024 18:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706294100; cv=none; b=JmuhGthS7uciqlJFaS3LYfbktDXGQPhiIV8scN6d0xfgAIR/4wTVBrgRbzV2X/B4soJyrJGz4p1cssuhEEGcW633fo2Gca+hHrhn+TN1JpCfsreSGoAvhqYKqX6cu7KZrEiKMO1lqScEiJxyg2vtCmcbvXmMV9xDyjd+/8gDqKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706294100; c=relaxed/simple; bh=preSX0quXvFKX+sSbZN+zc+SigzkAHZEJzhFhllCae8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M/mEaUcucl0l+iDtXDQC1TtB3zaBVS8nkiWmoj2bDqEJBbkKk+hkFUZsAKSOCvPa1+4RHPeTrdghpSZRN3xYzZaLaj1G5Gcg3QPNfk3LxRp511iIb06GxTpARn9aC8iuD2Yfl2efX8wwUnSHDQu4RdWW/Cblovbo5FmsHXtzOi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=UwcRX1yS; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g8fiwmPSySU4eNFj55g0a5/9A7qTajzirLf5GX98rOs=; b=UwcRX1ySFi1nbOK5g7PfabK6sw 7qXUH+5DP3RGvhMrBAH0NjHlQc18EsMIs0fBXguuVmmtNX0wzGAfNlnMvUje8wBU+WjtdLUhB6iCQ KJvKSPFA5F09x4naLxMx5rOD5iMJe3KtPiYgA63p5KOPhRVXY4UK8gFkb027dTcs41tTiYN5HacPQ /PHL4ZkTZ66AOtgPszGnjv6LLLcWfD80omFft65a3af/c+r+fX6ndJzRJg95EBB7bLI0VUSd+CbB+ i4dfFnte4jYPjSFzzvcNgfJYY7OcnwAkjC41ojscIBOG/Soct19joxB42DElNMezqgtaRpc6DRmgu qXHqzJyQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTR2U-0000000EUM5-3YYE; Fri, 26 Jan 2024 18:34:55 +0000 Date: Fri, 26 Jan 2024 18:34:54 +0000 From: Matthew Wilcox To: Chenyuan Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com, Zijie Zhao , John Hubbard Subject: Re: [Linux Kernel Bug][mm/gup] 3 Warning Crashes: kmalloc bug in gup_test_ioctl, is_valid_gup_args, pin_user_pages_fast Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 26, 2024 at 11:31:26AM -0600, Chenyuan Yang wrote: > In this context, I would like to seek your valued opinion. Do you > believe it would be more prudent to avoid fuzz testing the > `gup_test_ioctl`, or are the warnings in `gup_test_ioctl` an > anticipated outcome? It seems like a waste of time. Debian certainly disables it, so unless you can find a distro who enables it, I wouldn't bother. > It seems that `gup_test_ioctl` can indeed be exposed in the kernel by > accessing /sys/kernel/debug/gup_test. If someone wants to fix these things, they can, but it just doesn't seem worth doing. Part of the art of fuzz testing is finding things that are worth testing.