Received-SPF: pass (google.com: domain of linux-kernel+bounces-40530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: zhaoyang.huang <zhaoyang.huang@unisoc.com>
CC: Andrew Morton <akpm@linux-foundation.org>, Jens Axboe <axboe@kernel.dk>,
	Matthew Wilcox <willy@infradead.org>, Yu Zhao <yuzhao@google.com>, Damien Le
 Moal <dlemoal@kernel.org>, "Martin K . Petersen"
	<martin.petersen@oracle.com>, Hannes Reinecke <hare@suse.de>, Linus Walleij
	<linus.walleij@linaro.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Zhaoyang Huang
	<huangzhaoyang@gmail.com>, "steve.kang@unisoc.com" <steve.kang@unisoc.com>
Subject: Re: [PATCHv4 1/1] block: introduce content activity based ioprio
Thread-Topic: [PATCHv4 1/1] block: introduce content activity based ioprio
Thread-Index: AQHaUFBnGykW+CDLBEeg2i74DPeGorDscJWA
Date: Fri, 26 Jan 2024 18:51:03 +0000
Message-ID: <ZbP/FRGfkBrtAm7y@x1-carbon>
References: <20240126120800.3410349-1-zhaoyang.huang@unisoc.com>
In-Reply-To: <20240126120800.3410349-1-zhaoyang.huang@unisoc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?ghhiS+2iRG/nVLyPdGXkv0aCsXaWQGbRRPgPYyi9ehxERvu7pMfeCyXmTW9B?=
 =?us-ascii?Q?QSIhSff5z4p8nXfwsOLWUqtN8u7sBr51sMoUr0MS3AlkIzhC4R4V3XZo2PZe?=
 =?us-ascii?Q?KmQFpDEake4awf/pael442ml27ec686aNPU8gNZ+cDNeMRhA2cwJ9p2BZTi9?=
 =?us-ascii?Q?8EWJnqpaus0ye5wPh7Q+NyPtLW7FffTNLFP2jOEAdXaFXFFr6qtni6XmuHhZ?=
 =?us-ascii?Q?Duq942Ibyh4/f17sGnhvG5RjjVYwxsx678E/WjpBxuzi+fvL198vHdpxN7xv?=
 =?us-ascii?Q?QdxJu9ZSIOMQyAlhaPUsHcacrjXzGugvmeSINGoZawto3QQU4kXogGs8Q2Ow?=
 =?us-ascii?Q?nsqFvl4MdDG+4R3ICfDBq/lgnCFW7gx5IlZ99CulOuCQszAIX07JKiI7RSuw?=
 =?us-ascii?Q?+SamaWx3FiRW8mvtVaEdQ1Im0ufxsZFZLyXoMZf25y2xWYfYxViSycSAmvXc?=
 =?us-ascii?Q?/zNyvhpNm45WtBVa/QXW4VXpWvVU0g3l0TWTiC/UgtDcakxvwX9jItv10c4B?=
 =?us-ascii?Q?WBwT9G8SHW4ufTaBdVr8vI8wO8TutI8+RBmdNlmi/rLJ60h3h55x3zE/xVND?=
 =?us-ascii?Q?RDAxxQyQtcGXGh5bYw5sWkGQxf6aAPFli+Ni5lLu8nZrUdSTJaI3AO/7w7lB?=
 =?us-ascii?Q?GFYh31tLDC5/Nz1wypJ8lnh4IrUGNPTBmyyTak5bq7lrUSghNYMVl9QgG7ev?=
 =?us-ascii?Q?S4Y5vfh1RUQ7OgNJpHJT701fkZbMqld+DC1dP0/LW7vGxtZNhHmh7EI/FNh0?=
 =?us-ascii?Q?x6nASb590JxHON7EX0JtMXv+Qwekj311kb+qbWMveZN7XjpAd9C6EYJid4U2?=
 =?us-ascii?Q?GWFVIJDeo/1RDnQzeze+ABzkU/j+if0GWqPmA7mCcT3Q0urNAVAtEyxPJ9x3?=
 =?us-ascii?Q?LLFcOD1/ERnhZo40YfCfaKHaBM8VHDteNrw7A4wjHJlZpscRNNjWShUx2wOK?=
 =?us-ascii?Q?wE9VRlZU5YBFlOaO24BBoBt5Rka1Jo/Et16CrU6/F9bQFy2/UDY78Kc6SPao?=
 =?us-ascii?Q?RWSGTj7fpi6S6VEzdhSNIW507AFFzGdRQUq/4cdfVpVmbdo3rhEK2tswcjzY?=
 =?us-ascii?Q?gSIe6PbtuZ3ySzofCLJIbsb+24NZ91MvPUoHwNmt1lHi0oQDT5709t8k6de+?=
 =?us-ascii?Q?wYdjwdf35Gp+139858LAj/viOZWOPWAGlY9a5eOYk3fc0lMC13LMFe6crSRL?=
 =?us-ascii?Q?BerrxGufo4A+C1vdGOaTMYQjpRVV/ZUIddeSI53zksvduAx/7TF4TjvFsLcX?=
 =?us-ascii?Q?q0ab0jY3stspckc0l97VpvIHzZcoBGFOmroP8icxJTQbN3tQ2epGhy/0fcON?=
 =?us-ascii?Q?utnrqZON2iJjWXbWDLfbNni+Zuo6L7eUOv0bsN/sSs1/Trve30kBvaa+tVfo?=
 =?us-ascii?Q?MdEd8FYS5MbIDP1BoBYm5bRE+gCFFwd8RV7RTUYSgpU238btYV3NfLQCXNr6?=
 =?us-ascii?Q?pGm7O/ak0zsf/ic1IKpzbqm7trAqB40yjzCODbWHMubvehbHpjidzaav4Jx2?=
 =?us-ascii?Q?yTpxzMoiRuOTy5iuoZdjn1A43IeWYc/G+pJub74aipD8hZh3aZCYMfltAmFM?=
 =?us-ascii?Q?tnpHEsxrzNZxGxh8MJBtUdOcMBIOvcbK+i1z5iOfbl+/HGKF15xb1rDXRT5b?=
 =?us-ascii?Q?Hg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B173C9B9FAE8C447A01184D8188A8F4A@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	m8wmnPqls3qUZ/ai0gPNtAmbLn5Ka4ObZ/LR8x8PLUDwNUCzogGDoWpI9wcINzFan0uWrW7i2Qonq7kuVd0Rsg9NGQgRTGn3Ch/xqbL2coPCnI59lC6HLGEm7Dhu6ut/TrlUGazVnrkRlLGklsSUlxNiXIa1jfXDrlN57x/Jw8j7LpfcHwqW1D8RONx85NIsVh9QhxB3m43ok8REqi+cZiU4O7UudoMVTQHTLQg6V9Bzc0kmEfIWD2N4GRITITRfwoojL3ELTa6iytIFsJ6wCOnrWmCSZnLbcTwuA/qls0inx9syd+mY/KgBTfabSGEPsM2lfIcZVsBFKSV5nXhJ8sg5QmG72IfOUvE6jZe0Arg4UHw90VNtY3wcB+Re6N9fn7ZNgHxC/R3HCT2HSOKfBgfJg43Nf94xraIY48vip6xt+vHM/J7Lx9j+YQx5gh+EbcSypuXxI+1pVBEHh2tE9A2SWUe3tFR9YT0C44v1JB7UtPz7wpdFLsz/MGGfYFvhhu1L/ed9c42nsLaWFAGQVv6OVjdElTUum24zNzZCxmCtet6i7ComTzGrZcAhIqB+9N2/vg0HJSvHZzGJpeYU6VtWQAoiLjaVWz8PQX0q3uO8jt/1Yr552h1FikOsE5hM
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR04MB1040.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e09ba746-748f-4f05-d326-08dc1e9fbf14
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2024 18:51:03.3749
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /qvw5hCM3earYEWfKGrg1GnSElRjenythNCwEMXP4zvMkVDV8CksVo0UCQyFyhJc8QZMreApRFCbpKC06dp8tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR04MB7593

On Fri, Jan 26, 2024 at 08:08:00PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

(snip)

> --- a/include/uapi/linux/ioprio.h
> +++ b/include/uapi/linux/ioprio.h
> @@ -71,12 +71,24 @@ enum {
>   * class and level.
>   */
>  #define IOPRIO_HINT_SHIFT		IOPRIO_LEVEL_NR_BITS
> +#ifdef CONFIG_CONTENT_ACT_BASED_IOPRIO
> +#define IOPRIO_HINT_NR_BITS		3
> +#else
>  #define IOPRIO_HINT_NR_BITS		10
> +#endif

Remember, this is a uapi header.
The ABI cannot be one way if a certain Kconfig is set,
but another way if that same Kconfig is not set.

What could go wrong? :)


Kind regards,
Niklas=