Received-SPF: pass (google.com: domain of linux-kernel+bounces-40536-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <611fd2b6-d9ec-42f0-9711-b1398fc02842@intel.com>
Date: Fri, 26 Jan 2024 10:58:04 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/5] selftests/resctrl: Add helpers for the
 non-contiguous test
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@intel.com>
CC: <fenghua.yu@intel.com>, <shuah@kernel.org>, LKML
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <cover.1706180726.git.maciej.wieczor-retman@intel.com>
 <85b1efc3ddd698b3ac81aa72a6dc987ee17da3e2.1706180726.git.maciej.wieczor-retman@intel.com>
 <ea9b0e06-c07e-eb4b-9e7d-ed20419b677d@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ea9b0e06-c07e-eb4b-9e7d-ed20419b677d@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzNFOEM5WWJSOUZXL203YjVQY25aN3BRKzZ5Y2c4ZXhFcGVKdWZTM3pCeXZU?=
 =?utf-8?B?ek1RZElCT205Znk4ajM3cm9hdC9LWHhiL2lVVzdrVVp4Vldrenk2Mjd1bW8v?=
 =?utf-8?B?ZHAwYmJ0a0NwL3UzeUFUeUNBSU9mTjJneDlCVFN4blRjMTJDbUFkQXpENjRK?=
 =?utf-8?B?OUx6RTlQVXk4MnVUcjhPM0M1T0VORWF5YWMyVDJkeHdSV2ZGMWxRYk1QVzZm?=
 =?utf-8?B?OVFRT1BDUmNQMmJPa1ZKYm1Bb3YzV21hald0NjlwazkvakpLMGY0MGRjcW4x?=
 =?utf-8?B?c0VBTXR4TVQyeE1FM0ZEMlJPVXRPZ2QzNGUrTWJjckZUTE9YSHJxZDBZbmdN?=
 =?utf-8?B?VFQvWDlqbEthd0pZTmp2YXJrcmpYK3ZMdFlucnA1bmxsMnAzbXNFV2xHbGV1?=
 =?utf-8?B?cEJMenhNbWgrT3JHOTNZeGtNSWdmTkVxbWY0WVZueGlWYmVmM0RhWUZ4VEdt?=
 =?utf-8?B?WkdHckJKTmU0UVpzOUNRaWNCcitHQnBiaUZtV1BTRFVrV3B1TnVpTHVEMjY2?=
 =?utf-8?B?TjdFSXBEeUFxU3ZId3dnMFg5bVJhVFd1ZU93YVBVcjFOKy8xUXhOWml1MmpJ?=
 =?utf-8?B?VW9yZ09sc3pvbjdYaDdCaHozT3RZcWFFZDFsdnFFR0RuK1JHd1huS0J6bnlt?=
 =?utf-8?B?YWdWeWZjbmNMTTZXSExQeHcwVzhSMEtkOWJNTWNlS0VpekloVlMxRGo5THFT?=
 =?utf-8?B?TVJ5WjYvdWkyNFZ6SlloNmhkM0FLWXhhNUFhVWh4UUJNTlpTb25TL3Y2YWtV?=
 =?utf-8?B?dWl1Nldyc1M3aEhCa3Ntakg5VFlYRGNSQ1BySVliYlRWNkg2bDU3YnZ4ZXp3?=
 =?utf-8?B?a0c2RnB0aDhHMk9GTjg1a1cybnpvZ08rNklqa0RxVnRtbWNtb0piYnZWY1py?=
 =?utf-8?B?RXF2azZyQWszNkE3RnRDdHcvMkZZZk0ybnUwRm9LSmE4V0xwZjFUZFJleGZl?=
 =?utf-8?B?SHI2d0J1MGF0Ri9WN0dkb2cyazY2ZklhRTh0bU9HSVdoQzJVbVNYVU0veTlo?=
 =?utf-8?B?MWlCcTRrR25GcGpLTE96YXdQVkNhWFc0Snh3dVJoU29uaC9vVDFIekdveFB1?=
 =?utf-8?B?Y0Z4RXdYSUNCdk4xbWNkWkpoNEorTnJ5bXE3TldSMzBLdGVtb20zckQ1YUNP?=
 =?utf-8?B?K0VuWjJqa0c5dWU0OWorSmZCaGo0S1E4YmUyNmdJeGd0SmNUWFluZUxQZU4v?=
 =?utf-8?B?M2M5K3lRSEo3OTI3TmRDK2NVSlErdDRBSFA3bHZSRlEzRkRXcXJZMXR4T2w3?=
 =?utf-8?B?K3FSazdvSzdmbGdEN1NDWGltKzZVcTN4cTVTOXMzMU1GZnNuTUhWc0RCREZF?=
 =?utf-8?B?NGVsQUd3V3R0Q01iM1BEUU5mSFBPOTdBRk1ma2hoc1VSTkdyN0RkejFBVlI5?=
 =?utf-8?B?R0h4dmdBWkNoTWFJa0pKdGNiNTArbmkybmxMS0IzQjFzQXJZaXBhWGZrZ3kv?=
 =?utf-8?B?VE5GcXZza2NqMUp0L0lHQXhPdGVUTDNKT2VPRzFBT0lMK0hUT3J6YWJ5THdH?=
 =?utf-8?B?bkhtR2hwc0x6d29KODhCdmRuZ2FDOTlaczg4R0RGelpXQStNek40akpUdW5n?=
 =?utf-8?B?THd0bTlheGgvRUdXWlBLQmozZi95c3QrSThoZ0UxcW1iRHhWMjY5bGs3MWlh?=
 =?utf-8?B?NEozTXQrb01pb2kraGxONnRKaVRhQlNOZXpFSDVXK3RSa1J1QkhtR0tyZkgv?=
 =?utf-8?B?eWVob1F0MktYTEx3S3lyTzVIcFRDL3B6YVYvOHVWelNuM0RDZlZRQ3Vhekdr?=
 =?utf-8?B?Vm90Q296YStNWWtqMHdNeGRsQkxIMEpsM3dXenhvMVZtbWhMSWd6TE1EdXAz?=
 =?utf-8?B?Njh1bDJhdzBDU1I3bGl6WHZGL0lQVFVPa2g1ZHd6MXdxek5ubGxFTDlTUzQx?=
 =?utf-8?B?VWErcHJjV0N1ZVJFNjRRZHkvdHpJbE12YmovOVZONFlHMGlRcG9yYUhybm9o?=
 =?utf-8?B?N1Fza1prcTdGUVFucTVSdU9xdTB0Z1p2aEdKOUxnckpzSzJtUEFPbmhNSmpN?=
 =?utf-8?B?L2xhUG55Y3oxamM0K3ljSXVwVDI3RStsdlFXdWlZQ250c3Z5VG4yQ2tLUnV4?=
 =?utf-8?B?Wkw1TmZpeEJiUGlKQ240NW5ZaWVGRHBiZW1CcEFKd29JaXpaeTFpc0dtdWkw?=
 =?utf-8?B?NFFScDV3dFQxVk1IbEo5c0RHNlpqZGlKWG1ZajdsK2JVQ2hNNUNQOVluSFV3?=
 =?utf-8?B?WlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c35d86dc-5941-44b0-85a6-08dc1ea0bb76
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 18:58:06.9615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PTMNe3XoMXeBvqb8iwTfyGOch1jCd72rcfPhU3a6Ue/5wLbdLRfon1B91wSFWHCQSWup5Kr7lRMZKBZ+q7hxiPCC79TMHyLp8aGSEHZZ3e0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB7160
X-OriginatorOrg: intel.com


On 1/25/2024 4:14 AM, Ilpo Järvinen wrote:
> On Thu, 25 Jan 2024, Maciej Wieczor-Retman wrote:


>> +	fp = fopen(file_path, "r");
>> +	if (!fp) {
>> +		snprintf(reason, sizeof(reason), "Error in opening %s file\n", filename);
>> +		ksft_perror(reason);
> 
> Was this the conclusion of the kstf_perror() discussion with Reinette? I 
> expected a bit different outcome when I stopped following it...
> 
> In any case, it would be nice though if ksft_perror() (or some kselftest.h 
> function yet to be added with a different name) would accept full printf 
> interface and just add the errno string into the end of the string so one 
> would not need to build constructs like this at all.
> 
> It will require a bit of macro trickery into kselftest.h. I don't know how 
> it should handle the case where somebody just passes a char pointer to it, 
> not a string literal, but I guess it would just throw an error while 
> compiling if somebody tries to do that as the macro string literal 
> concatenation could not build useful/compilable token.
> 
> It would make these prints informative enough to become actually useful 
> without needed to resort to preparing the string in advance which seems
> to be required almost every single case with the current interface.

I think this can be accomplished with a new:
	void  ksft_vprint_msg(const char *msg, va_list args)

.. but ksft_perror() does conform to perror() and I expect that having one
support variable number of arguments while the other does to cause confusion.

To support variable number of arguments with errno I'd propose just to use
ksft_print_msg() with strerror(errno), errno as the arguments (or even %m
that that errno handling within ksft_print_msg() aims to support). This does
indeed seem to be the custom in other tests.

Reinette