Received-SPF: pass (google.com: domain of linux-kernel+bounces-40606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 26 Jan 2024 12:08:13 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>, Dan Williams
	<dan.j.williams@intel.com>
CC: Alistair Francis <alistair23@gmail.com>, <bhelgaas@google.com>,
	<linux-pci@vger.kernel.org>, <Jonathan.Cameron@huawei.com>,
	<lukas@wunner.de>, <alex.williamson@redhat.com>, <christian.koenig@amd.com>,
	<kch@nvidia.com>, <logang@deltatee.com>, <linux-kernel@vger.kernel.org>,
	<chaitanyak@nvidia.com>, <rdunlap@infradead.org>, Alistair Francis
	<alistair.francis@wdc.com>
Subject: Re: [PATCH v6 2/3] sysfs: Add a attr_is_visible function to
 attribute_group
Message-ID: <65b4112db4de0_51c7f2943a@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <2023090142-circling-probably-7828@gregkh>
 <2023100539-playgroup-stoppable-d5d4@gregkh>
 <CAKmqyKOgej1jiiHsoLuDKXwdLDGa4njrndu6c1=bxnqk2NM58Q@mail.gmail.com>
 <2023101113-swimwear-squealer-464c@gregkh>
 <CAKmqyKMX3HDphrWHYcdnLEjMwe1pCROcPNZchPonhsLOq=FoHw@mail.gmail.com>
 <CAKmqyKOOSBF7qDpqAp6nn3+3wAnaGmqu88Fk3KY58fmgQ-44Jw@mail.gmail.com>
 <2024012321-envious-procedure-4a58@gregkh>
 <65b1739b2c789_37ad294f5@dwillia2-xfh.jf.intel.com.notmuch>
 <65b400bf65c33_51c7f294c5@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <2024012631-removed-stuffed-ecc0@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2024012631-removed-stuffed-ecc0@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z8XS/ZBNI6JFfFB5g5R3r+H5ep3uKlyku+IzImiK/yF/lJCdbFSGvb1JQYTA?=
 =?us-ascii?Q?S9BMpXtxj/2x9oOUtPzsaS7U1lTgXeRizIJJhmuvHgqEce0SaRq8Of3t81sC?=
 =?us-ascii?Q?eMZDyl7EjLvwf/jXo91lo9ckvvWzSXvenmJE205lF9/QTo0Hl7rOVDl8qrxo?=
 =?us-ascii?Q?JgynFc/jYxJQfbH+TNk5piwPfBtIqFSv9LYnMGsPXsWLcQfFZZPQUGhWlvNo?=
 =?us-ascii?Q?mHpi+TB93pNvZw6YSvvYlSA+W6k0bz+QGersZp4mvCQrParwJm+eHqT/thMU?=
 =?us-ascii?Q?uMhGXC+5XEHjW7LM3dR05CAG8PTflkqBNgJz0TC4ymKh2grIybqzWnUw3LH2?=
 =?us-ascii?Q?AUjGx60XWVYnUVpJ1BWSwkRZ9qVDCgQ0CXLqMoepqoPcLtOwoW2r9MI/2Diq?=
 =?us-ascii?Q?8LBgqKTmSiz3Y27Runs5l1LQApggqgSmUlqngnr3U+ytkBQAyHIx0HFGTdg/?=
 =?us-ascii?Q?JbX14eA4vBLDPkWWCwE1kE3C8Jc1WWwne0neG66bgm9yQymcscBJpmPjJvKy?=
 =?us-ascii?Q?6Wxs67LYKvtogPtE9K1lSoDyAqeQqe6p07QrE7j5tC37EPJC3hr3tn8H4K9L?=
 =?us-ascii?Q?hMNyvtWhGKQZPVuPYJluX/al8q93h7ausKGlWH5RzXJDFLVq9QbLESnD7NJB?=
 =?us-ascii?Q?ezMOFb6CrlraDbUJP5Sj+FwKcKLCVRhJUOjL+1Ae12seoPsMZxHdgyxEHo+r?=
 =?us-ascii?Q?8cfaY26zWf66qLPTJs9j1V5kzuFFTwbSTs0UVlBrHwLDcdjObzZhNu4eqGbf?=
 =?us-ascii?Q?FGFHttcBnQFb5WjH1C3z+tjIx5piSvUGM5VuOjyFuu+9ZA8vcAE+pnMhoUxJ?=
 =?us-ascii?Q?207/tR+0SQHc3NE5Pl3N1kNb75vYLCChV5tT0Tr17icJbPn0T3TTnmrFuIH7?=
 =?us-ascii?Q?4zwi3lzuBZsQcrJ4c+fOGS0oeUheXAvy3BnvFpLdiSP8aGoUDjPCMikNz7J/?=
 =?us-ascii?Q?dKgAg6tWsdKUvMyUvcRFaLeS+Z8FcbrHFyVExPEDQ12j8Oo4mdlnKVvfY5bP?=
 =?us-ascii?Q?bGmgOKEtBKnHcqtHzAx6gtLkyVL32LAgSXwIQgYK6eys/FZRczGrJWrAJGH3?=
 =?us-ascii?Q?DKeXdw5xArzhYNy/EUtqFXKmyoMnniTQ5Dz3GkXF3uaYtaMask7MQm/hzS9p?=
 =?us-ascii?Q?sgvChnN7qxiJbG/FYTS/8QSxetGm6hApeAgCV6BsGB2GkC42yykIkZDmcWDv?=
 =?us-ascii?Q?Y6RRYdsUojYg7nxCwKGqMfDUDQs+ufg9Zeio5ATIzXetboSlLP5clZM+1qOD?=
 =?us-ascii?Q?heDhfZ8GF6aPrzJoPmdPzSoFNmU81vvMNZlizL82fUoI3O74KHUUbwgEbQIk?=
 =?us-ascii?Q?bZaZrVifAJr47w8kYqBs2tl3A1GgJsisOky/LpyxCln7u/yIBOZZiE6gYiSz?=
 =?us-ascii?Q?5x8iiaG5zvGjeAknzz7pecW0SCDzNCBGCfaCWrUHiyXh0IDX5Jjev0aYlPpR?=
 =?us-ascii?Q?KJ8ZY/PY6VqFHhHUaAfoTbpVLT8wwFlTZ7xQbbL/qPDaXiMOvLhCTmbirAvf?=
 =?us-ascii?Q?NVLXKNzGc2jsPZqdZPUFocCmjexaqK11Gvbv51D0bnsFVj9MuypX/E9eGvto?=
 =?us-ascii?Q?RtRLC1Cu+nTdzqimQjVCNndp6kpggi4YvDq8AdGtO5k+5lDUd6UzwvZFX4dh?=
 =?us-ascii?Q?ug=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5dede7fa-662a-414e-06d2-08dc1eaa88b6
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 20:08:16.8127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: joqtmAX/skuf8W+zbSaYoNR24j8YeIVdF+Ov6RPQ6PXh1G0JKGnOe5ANVqfUZYGpCfdekZBshdn0AV6HzcQnhqYMGmK8ga5F0d9ag4wVe14=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5466
X-OriginatorOrg: intel.com

Greg KH wrote:
> On Fri, Jan 26, 2024 at 10:58:07AM -0800, Dan Williams wrote:
> > Dan Williams wrote:
> > > Greg KH wrote:
> > > [..]
> > > > > 
> > > > > Hey Greg,
> > > > > 
> > > > > I wanted to follow up on this and see if you are able to provide more
> > > > > details for reproducing or if you are able to look into it?
> > > > 
> > > > Last I tried this, it still crashed and would not boot either on my
> > > > laptop or my workstation.  I don't know how it is working properly for
> > > > you, what systems have you tried it on?
> > > > 
> > > > I'm not going to be able to look at this for many weeks due to
> > > > conference stuff, so if you want to take the series and test it and
> > > > hopefully catch my error, that would be great, I'd love to move forward
> > > > and get this merged someday.
> > > 
> > > I mentioned to Lukas that I was working on a "sysfs group visibility"
> > > patch and he pointed me to this thread. I will note that I tried to make
> > > the "hide group if all attributes are invisible" approach work, but
> > > reverted to a "new is_group_visible() callback" approach. I did read
> > > through the thread and try to improve the argument in the changelog
> > > accordingly.
> > > 
> > > I do admit to liking the cleanliness (not touching 'struct
> > > attribute_group') of the "hide if no visible attribute" approch, but see
> > > the criticism of that alternative below, and let me know if it is
> > > convincing. I tested it locally with the following hack to make the
> > > group disappear every other sysfs_update_group() event:
> > 
> > Hey Greg,
> > 
> > Ignore this version:
> > 
> > ---
> > From: Dan Williams <dan.j.williams@intel.com>
> > Date: Tue, 23 Jan 2024 20:20:39 -0800
> > Subject: [PATCH] sysfs: Introduce is_group_visible() for attribute_groups
> > ---
> > 
> > I am going back to your approach without a new callback, and some fixups
> > to avoid unintended directory removal. I will post that shortly with its
> > consumer.
> 
> Ignore it?  I was just about to write an email that said "maybe this is
> the right way forward" :)
> 
> What happened to cause it to not be ok? And if you can find the bug in
> the posted patch here, that would be great as well.

It was an aha moment this morning that I could rely on something like:

#define SYSFS_GROUP_INVISIBLE ((umode_t)-1)

..as the return value from either is_visible() or attr_is_visible() and
not need to define a new is_group_visible() callback.

The only downside I can see is that there is no way to know if the
is_visible() handler might return SYSFS_GROUP_INVISIBLE to decide when
to warn about deletion not finding anything to delete, or update not
finding the existing node to update.

I'll type it up and see how it looks, but if you're not worried about
the is_group_visible() addition to 'struct atttribute_group' I think
that way is less hacky than the above.