Received-SPF: pass (google.com: domain of linux-kernel+bounces-40653-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9f8f1f00-f8a8-4c40-90ab-fd3357ab3b6e@intel.com>
Date: Fri, 26 Jan 2024 13:08:52 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 4/5] selftests/resctrl: Add resource_info_file_exists()
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
CC: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1706180726.git.maciej.wieczor-retman@intel.com>
 <e73a79210076d6b1b7b584b12d0499e2f2e5f4fe.1706180726.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <e73a79210076d6b1b7b584b12d0499e2f2e5f4fe.1706180726.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0FzNVA2aW9Td29kZnNpc3g0S3hHUHRXRkppYnlXN004TzRBZzVKTFFjNGhO?=
 =?utf-8?B?Tmt6NXQ5U0hHYk14ZUoxSjJEa3dPSmorZmpoWUVpSm5lSzBjYnplb3VSQmpk?=
 =?utf-8?B?Z2FrZmx3Mm01eGdaOUVIbExwZnkxeUwvbzBYUzZYbndxMDFqNVJYaGhTcUJx?=
 =?utf-8?B?MEJpdE1SSnFXWW95SUxJU0VveVVtODR3eUxlQ3YzZ1p4RkpFTFFKOEhLK002?=
 =?utf-8?B?clVBZjdVOHYrUUJ0bmpSRzhmNjE3WHlJQ3BIcExtNTdXT3NLR29ib3hvdmh6?=
 =?utf-8?B?Y2VRM2EzUzU2ajNCd3RkWGJzZFZseDY0Y3B0OHFRbzBla3dzV1Z5ZjhZYkp1?=
 =?utf-8?B?dWFPZm1BZHZEOXVENmJpZXVnd3FKRTdsdlBsaFNxREloaXk1NFI3MmZiRXQ4?=
 =?utf-8?B?azBWYTlsT2EzcWZ0bW5EemxzUm8zL1p5SkhIY2hzT0dmS2RpRnNLTTVzUXVI?=
 =?utf-8?B?VkZWQUtZc3Q2eDV2elp6aGxOMlUrcWxRSEZIY05FYkFzT0NQT0JtbVY2UENE?=
 =?utf-8?B?MGpTM3ZZNU03dUhpS0p0RiswNUlEMGFseE9vcWdySFg0OHZHZHRoeDBRSlBI?=
 =?utf-8?B?ek5tV0grSDlidnlNQUQyTXFibEJZU0p0Zm9KSEtHOWhEYko1aHQzeWhYT0ht?=
 =?utf-8?B?dFpOQUo3dlRnbG91RFBSSE56cXpqbVVuam0wTncvZHlzaWxZTDhuRi9PcjRu?=
 =?utf-8?B?bG4rc1REYkNQdlhOeEM5YjlUZTVkS3JEVjQrVTl5NHlOazdZWS83OVdMeVpj?=
 =?utf-8?B?RWdVMG1TL0twcWVVanFhQ1lxdVpZTHBEVXJLS2ZiSVMyRVl2YXZzVE1FT2Zw?=
 =?utf-8?B?QUFtV0RXRTJDelBBSVlEYVAwaU02U2h0dWJhc1ZiaUpHcWhVcGZKdFJBaGp5?=
 =?utf-8?B?eHk4QnpwWnEyZC9Tam5vdVRhVXZqS0lkSlFjWG5VSCtMYmRTcVJScStHM0pa?=
 =?utf-8?B?VkJqekFEaE5ZV1JWWUxtbDdkaFZKYTNZanBDSE1JaEFUNitDRXozU283UW5u?=
 =?utf-8?B?cDV0ejlvM3YrelUvQ3kwYkFGdGFkVk44MXhDMFAvTmdBQ1Y5YWVRNkhYZnRT?=
 =?utf-8?B?anFKMTlZV0laYnRYM29jODh5RDdUVGRneFllSFhrWC9WMEc1SE1EYThZRU8w?=
 =?utf-8?B?M2NkUHNNcjhRQkxtRjVBUXBVRVB0YnVIK00rbzNwNlN3czROTkUyQytUdkxE?=
 =?utf-8?B?UkV6TnAwOXBDWXdFNWRTRE5DNjd3M2k5L0hxQXU0a29UZ2xlWW81NytoNm1h?=
 =?utf-8?B?QVk2RzdWZmNkeHFIbWdsVVhQak0valI0SFhrZEhrRUNZQjliSytITGQzT29t?=
 =?utf-8?B?SjM5cjFIbFZBTUJLNTRaTStXd1NxTWNHZkRkbit6bVpzdFVTNVpPQ0lUeStD?=
 =?utf-8?B?WDlYcXY4TUxvbWpRcGRRcjVnVG5zNVVwZm5DSVBkQjdHT1ZyYUlnQUorQk9L?=
 =?utf-8?B?d1ovanM1R20vUGdJVHdzNWtUakxSd3kxQ1NEVXVjTGNvWHMxNkVTbnJpQ1JI?=
 =?utf-8?B?OU1sU0t2R0dNTDhjbVR4YkR0NFV1b3dOSWd4SUY0WGljd0pMeFNybHpkUE55?=
 =?utf-8?B?UW5ORFJzVmFpK3Z3WXhBT3R0SXFtUk9MRTJ5MUdpam9lVEdGemNKV1Bla2xi?=
 =?utf-8?B?TDMyVFNqck4wZVZ1M0FPbGNUTHhqQmJOYlgxdE9rcVU2L3FYZjlqb2tzaU5s?=
 =?utf-8?B?STlJNS9Md1FkSGxnTUR4cFU5MUF1QmZYTG1ZT3VuSGRLUkphVkNVbklLK0ND?=
 =?utf-8?B?MzYzc2YzL3RrMjhCSFl1UUtacVVBWUtQOFB2QnRhOG5jMk51Ym8wZ1NmZzJO?=
 =?utf-8?B?SXNSbWxtWlFKQjJ3bnNGNXNPdzBueGdaSmVkRW1OZlMzbXltc1lYMk1ML0t1?=
 =?utf-8?B?N29PQmxxUklxViticm53dTBZdG14K3A3Tjd6dmoyV3NNb3V1c2xZaC82b0ha?=
 =?utf-8?B?M0Q2bk0xclZLM2xCVW81c1J2TWxRS1hjTjk0TXFibXpKNGZaUG5CbzZJYUhh?=
 =?utf-8?B?SjJNaDBQazd3TUhUazBKM2M0ak5wNXBOaGhSRUtCTGJrdDA3NHpGOG9jVzZC?=
 =?utf-8?B?STBOcDhiaE9Nc3czaksyLzZ6S3BEM1dGMVdSU3JPZGFVdjBwbjQ1SkRQK0ph?=
 =?utf-8?B?d1dNV2gzV0xNRTZHM0I5cCtaS2czSlp0ZURmaFdvT3QrSGhIdUZ3NTdoMkp1?=
 =?utf-8?B?Q3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0800927a-7f7e-4116-962d-08dc1eb2ffd7
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 21:08:52.6140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zl9d9+zpFUxxAnwW5eYacE7GU+BBzFpvb4T/H6lGqkMjLRtu88YHT6oCFoVJQW6OXsxJifsnHymiG0M5oousKj7/Uq7UXVzkmHW/lRTolDE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4723
X-OriginatorOrg: intel.com

Hi Maciej,

On 1/25/2024 3:12 AM, Maciej Wieczor-Retman wrote:
> Feature checking done by resctrl_mon_feature_exists() covers features
> represented by the feature name presence inside the 'mon_features' file
> in /sys/fs/resctrl/info/L3_MON directory. There exists a different way
> to represent feature support and that is by the presence of 0 or 1 in a
> single file in the info/resource directory. In this case the filename
> represents what feature support is being indicated.
> 
> Add a generic function to check file presence in the
> /sys/fs/resctrl/info/<RESOURCE> directory.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---
> Changelog v3:
> - Split off the new function into this patch. (Reinette)
> 
> Changelog v2:
> - Add this patch.
> 
>  tools/testing/selftests/resctrl/resctrl.h   |  2 ++
>  tools/testing/selftests/resctrl/resctrlfs.c | 26 +++++++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index 4603b215b97e..c39105f46da9 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -138,6 +138,8 @@ int umount_resctrlfs(void);
>  int validate_bw_report_request(char *bw_report);
>  bool resctrl_resource_exists(const char *resource);
>  bool resctrl_mon_feature_exists(const char *feature);
> +bool resource_info_file_exists(const char *resource,
> +			       const char *feature);

In addition what Ilpo commented about other line, this too can be
on one line.

>  bool test_resource_feature_check(const struct resctrl_test *test);
>  char *fgrep(FILE *inf, const char *str);
>  int taskset_benchmark(pid_t bm_pid, int cpu_no, cpu_set_t *old_affinity);
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index e4ba8614fb7b..a6427732e0ad 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -763,6 +763,32 @@ bool resctrl_mon_feature_exists(const char *feature)
>  	return !!res;
>  }
>  
> +/*
> + * resource_info_file_exists - Check if a file is present inside
> + * /sys/fs/resctrl/info/RESOURCE.

As confirmed in the changelog this is intended to be a generic function that
tests if a file exists ...

> + * @resource:	Required resource (Eg: MB, L3, L2, etc.)
> + * @feature:	Required feature.

.. so assuming a use of this by referring to the file as "feature" is unexpected.

This function jumps between "file" and "feature" in comments and code, please
just stick to goal of making it a generic utility that checks for a file and
refer to it consistently so.

Reinette