Received-SPF: pass (google.com: domain of linux-kernel+bounces-40654-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <db08ba56-ae73-4c70-87fb-aae59e524238@intel.com>
Date: Fri, 26 Jan 2024 13:10:18 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 5/5] selftests/resctrl: Add non-contiguous CBMs CAT
 test
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<fenghua.yu@intel.com>, <shuah@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1706180726.git.maciej.wieczor-retman@intel.com>
 <647fbfd449f8b0e0ad6cfe58bb280ff44ee162b8.1706180726.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <647fbfd449f8b0e0ad6cfe58bb280ff44ee162b8.1706180726.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVRLc2FTcElwTDFBRHpxWGkydU1NR1RDY3Rudm5MVmVDS3JQWDhMRjhEaFNx?=
 =?utf-8?B?Y1U5blREbFIwYVRCZzVwSGwzOEZ1c0MwaklleEVOT3RBcjVJaGxxM0tXRU5y?=
 =?utf-8?B?Mm9JSURLRFpVaFNvRkVyOE1ERG0rMnhRaDVxdzJXZGhhSEYzUjdPSDB1S05s?=
 =?utf-8?B?UFlIcGNBY2lXUHFOeVBmdUZDbTV5bGdGTnptRTVRUGd2aWc4dkhWMUh5UExZ?=
 =?utf-8?B?STBROG1TSldrZVB1VXhhSmJwS0R4NXZrRTFsbkdTbFpvTVZVb2czc0tkQVZp?=
 =?utf-8?B?ZEJEYWpTM2ZzVGUwcFBmN0FpaG1EQ2hHdDVrbjdyek5kcDFza2o2dUp4QlEx?=
 =?utf-8?B?UTVDejhaWS8zQ1JBWUhkMk44anFQRTJVLzhwUTdGQlRuNlNNbXlMZTJOVVM1?=
 =?utf-8?B?UXg5MytvVnBFbnlVdTBoM2UxS1Q1QXNKYW9veEZ4QkRzTU5oZFRzOTE1MzR0?=
 =?utf-8?B?TnZJdlM1NlJ1c0xzVmlVVWlMVjFJVnVac3UvU1dYOXkralpVbE9kWDV1aXJ3?=
 =?utf-8?B?a0NSaTBWbEkzSlpHOUNRa3UwZ1luWllqL01aaE1PT1N6MTBpWk9ZdUtqZEJx?=
 =?utf-8?B?OWo1TnN0MDZZMFVxNyt4NnRObkduR21xTHVvQklNQmdNa3cyeVg2Y2NGWnp5?=
 =?utf-8?B?b2toaGdESkVNQ1FTS1VJdGR2OEx2RitBSWhHUVAyTHVoMzR5aWZOTnpZUVh6?=
 =?utf-8?B?UEFlSGR5WlZUOEhUMFRQYjZuT2RsL1VLTnBXYVNFR0cxRHA5bS91Q0J0QUNu?=
 =?utf-8?B?RW1Pa1hWUGpUem43Z0FYRndqREo4dWZoYmZjMllhdTl6V1RXTmo2NDdHRkJj?=
 =?utf-8?B?Q2ZKK1ZDWEVmaTlmdHJ5dkFsMkN2OFoxU1pXUU9xcVdyR2NSU2U2aGZkZGdz?=
 =?utf-8?B?dHErWWcxcVRIZlV5WllmZWtCaWRJL3JJMlUxMmVHRm5rbW9vWFp2Rk9McUNi?=
 =?utf-8?B?eTJSd2tQMzczNm9ZRWRtRStOQmpFdWg4bzRFNE9ONHpMYWZTdGM0L2Y2QXp0?=
 =?utf-8?B?MTdIUUJtQm1QTDd1REh3RVBhaitSdFk2VDZoODQrTlFkaEF1RUFTdDl2NzhC?=
 =?utf-8?B?Q0M1bmlRWW9KNjZibHp2d2ZaaEl1TUFzNEE2WFFFdndqM2xDVTlRd2JQbFhl?=
 =?utf-8?B?bkhkMTVrV09FTUZscHgwbUxWSUhjUnZnUC9WV3ZCcEovZjUyNVk5TG12VmZR?=
 =?utf-8?B?RjQwY0wwZi90Yi9hcGMrdDZVL0wzT0ZPSlZsQTZ0QmhmQTdLVGpOZjBOWGdD?=
 =?utf-8?B?QjEzUW5rMGVmYXBuS0liWUJ2bGFDWU5seEYrY1JBWDJUVi9ENndscHYrOWo2?=
 =?utf-8?B?RlRVbGc3U1dtSFpkWDB2QlNnNUVZNlBkQklTSEJKTUs4RjdxMWYwT1pLTk1L?=
 =?utf-8?B?MGFvY1Y0cmplQzZaSFU0UUQwd0g2aWNtZ2p1S1JVZTBVcldmR1kyWHNjVVFV?=
 =?utf-8?B?MitVR2F4SmhSeVhSWjR2bFQ5OEJnU3BQRVI5R3ZPeGx3cUlrcHJ2VXF6Vnlh?=
 =?utf-8?B?NXlSc241K1p4dUVhQ3NFeER3UlFJU0FOS0l0TXdMUTcvc0JBS3JBOTNZSVJ5?=
 =?utf-8?B?S0JrTkF6VlpZdFJQM1d5eHVTV1NWaGJXWnJ0aFNGOWRJeUJSRG8zOTJyRXUy?=
 =?utf-8?B?Z3hSa21LRE9NeEYzcmpsUTgxMm5RUDgzVTB5YURjVC9NUVdrd1FyUXZXaWVO?=
 =?utf-8?B?dmE4a3V5VGIzR3Z6RzdHbGhZOVJtZ2pLUVNNVFhwV1RyZFBjYWpMc1grWVpL?=
 =?utf-8?B?cWU4WVZaTXdMKzgvT0dhSytPSFByc2hFSXAzbUNWcittcjErK1dqQys5a1lQ?=
 =?utf-8?B?d0V5Y0swSjBEd3hzaTc4bjk0WWhTZTh5OVlkZUdMc2pDdDArbHI5RlNZT1BL?=
 =?utf-8?B?b09JUWR6eWpnM1lMVmVzWmN5MTcybVBTT0JqbnNhL1duRldIOXI5K05vQUdD?=
 =?utf-8?B?Ukc4VndFc2RDVnFnaVZrNG1rdUUvaHJhL2VmSlZFS0Y3RmNKZXplNGtNV2tT?=
 =?utf-8?B?dFNObnNGVXpNTDVMKy80UU95VW5DQXZ1bDFMUkNoLzFZanVYbkhDdjEvQUJl?=
 =?utf-8?B?cnpmd210WWxNOE9BZEd3R0pLYk5UNzlUUXRMUnBGVEQ2UWpaYTYrTU9pK2cy?=
 =?utf-8?B?d1ZpTFpPZ1FyUnRVc3VBK0o2RHArT2JOYVV5a2pWSUxFQUJNNVhZVzhxV0Z1?=
 =?utf-8?B?bHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 68975460-4cd7-49f8-1c9e-08dc1eb33325
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 21:10:18.6957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eKnBjGLA4iWDPAFL5SbK+KqAf5N4qYqazyfEgCPySOB0dghfCWTjZQVt7SlcBxzX2+rzkj2DTFfJ6Brb6I3zkd7vw7iQB+SEoYYG1Avw4aE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4723
X-OriginatorOrg: intel.com

Hi Maciej,

On 1/25/2024 3:13 AM, Maciej Wieczor-Retman wrote:
> Add tests for both L2 and L3 CAT to verify the return values
> generated by writing non-contiguous CBMs don't contradict the
> reported non-contiguous support information.
> 
> Use a logical XOR to confirm return value of write_schemata() and
> non-contiguous CBMs support information match.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---
> Changelog v3:
> - Roll back __cpuid_count part. (Reinette)
> - Update function name to read sparse_masks file.
> - Roll back get_cache_level() changes.
> - Add ksft_print_msg() to contiguous schemata write error handling
>   (Reinette).
> 
> Changelog v2:
> - Redo the patch message. (Ilpo)
> - Tidy up __cpuid_count calls. (Ilpo)
> - Remove redundant AND in noncont_mask calculations (Ilpo)
> - Fix bit_center offset.
> - Add newline before function return. (Ilpo)
> - Group non-contiguous tests with CAT tests. (Ilpo)
> - Use a helper for reading sparse_masks file. (Ilpo)
> - Make get_cache_level() available in other source files. (Ilpo)
> 
>  tools/testing/selftests/resctrl/cat_test.c    | 81 +++++++++++++++++++
>  tools/testing/selftests/resctrl/resctrl.h     |  2 +
>  .../testing/selftests/resctrl/resctrl_tests.c |  2 +
>  3 files changed, 85 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index 39fc9303b8e8..9086bf359072 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -294,6 +294,71 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
>  	return ret;
>  }
>  
> +static int noncont_cat_run_test(const struct resctrl_test *test,
> +				const struct user_params *uparams)
> +{
> +	unsigned long full_cache_mask, cont_mask, noncont_mask;
> +	unsigned int eax, ebx, ecx, edx, ret, sparse_masks;
> +	char schemata[64];
> +	int bit_center;
> +
> +	/* Check to compare sparse_masks content to CPUID output. */
> +	ret = resource_info_unsigned_get(test->resource, "sparse_masks", &sparse_masks);
> +	if (ret)
> +		return ret;
> +
> +	if (!strcmp(test->resource, "L3"))
> +		__cpuid_count(0x10, 1, eax, ebx, ecx, edx);
> +	else if (!strcmp(test->resource, "L2"))
> +		__cpuid_count(0x10, 2, eax, ebx, ecx, edx);
> +	else
> +		return -EINVAL;
> +
> +	if (sparse_masks != ((ecx >> 3) & 1)) {
> +		ksft_print_msg("CPUID output doesn't match 'sparse_masks' file content!\n");
> +		return -1;

If I understand correctly this falls into the "test failure" [1] category
and should return 1? ...

> +	}
> +
> +	/* Write checks initialization. */
> +	ret = get_full_cbm(test->resource, &full_cache_mask);
> +	if (ret < 0)
> +		return ret;
> +	bit_center = count_bits(full_cache_mask) / 2;
> +	cont_mask = full_cache_mask >> bit_center;
> +
> +	/* Contiguous mask write check. */
> +	snprintf(schemata, sizeof(schemata), "%lx", cont_mask);
> +	ret = write_schemata("", schemata, uparams->cpu, test->resource);
> +	if (ret) {
> +		ksft_print_msg("Write of contiguous CBM failed\n");
> +		return ret;

.. although here I think the goal to distinguish between test error and test failure
falls apart since it is not possible to tell within the test if the failure is
because of error in the test or if test failed.

Reinette

[1] https://lore.kernel.org/all/33787043-5823-6de4-4e5c-a24a136ba541@linux.intel.com/