Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp867706rdb; Fri, 26 Jan 2024 13:19:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHI4d8NzsT4mpvZUQoSFVPt4GdLgXM+LsqBsHP3N6esYPd1NjZ/6ke090OjsAulxTPO+hYO X-Received: by 2002:a17:906:bc4b:b0:a23:4faa:d4e9 with SMTP id s11-20020a170906bc4b00b00a234faad4e9mr296905ejv.21.1706303966240; Fri, 26 Jan 2024 13:19:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706303966; cv=pass; d=google.com; s=arc-20160816; b=UTSsiH/k1Rp6j2VKHKSPu6kD9E0BRmZA1rBKl8FAFWagDzCKsVr2Jb1xCCakGjg2oH 6S+Mesq9Bz+4c1ZerC0T4nw86x1N1s3xAMKhyduvLwLCnEK/V2K3QzmJp2Nd8ipDAXVJ WNxEDr/SiGHYOR+okDIbMOyGG6jggDy59fKAT6YQnFGLsTnIuperaI2VnzqDEG1jnYyF VEanTNGWt+/sqxAJqSrj0wPbLIKXupoM7dW10cT8JQYHU8RYWIf/IS4lMNpttRvzYYcR KRWxdeUjiMlSfZHuIVMuyJIXKWbvuakBQXRuDlCqzKkvKNIrYdvBYbLIl0kvHgGc89m4 xbZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QAmhzRN9Gx5RRTwBMINr0tSQKWvpM2+7nYt4uq/mnFU=; fh=gNNHusI0IOL4a9UcZTNWJa65O8IjXnENImSJkcrhEBE=; b=pBLKWjlRmLudD0f2QIjqJph268XOjfHB/B0itP2h+hrAFHL41Wo4/hSeNQLWqW5CPg hmJD8nQu52vDI+YHG7m4QToKo8Sv0Uo2iod7cK6vf/GsjdwgwXuN05f2YvwAm3r30DFY RhmjOIFzUbKZCan/zmmz1TNSbN4/4FSizhzA8KQrS/i1Jd9FoZHQbFmIy7iD3Why46vo UTfM6jfE+VBA32DxiI+cfJmE3PsBmKYvdg2tShHgO3WVIW7mHcZZilWJQcm1IOdv99We q+C82/FLOMlkD+OFBg1BFc/UtbMmEQDGKJCQ50BEMFDHdW3D1DWhaVXW3uno0Def9Wno yHNg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HtO1CxMm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-40660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id lc7-20020a170906dfe700b00a30abba5150si951080ejc.445.2024.01.26.13.19.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 13:19:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HtO1CxMm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-40660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 044A21F24C16 for ; Fri, 26 Jan 2024 21:19:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF75B24A08; Fri, 26 Jan 2024 21:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HtO1CxMm" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12A68241E5; Fri, 26 Jan 2024 21:19:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706303956; cv=none; b=ME1UivnNzPAJvpZ5zi8ExsD+cOQrHTi50s0ka6DYX7SfKvsBHjp63Nm1cyl03B9Rj443R8W8rxbJwF5KtQszXsfPU4RRjr+jZpsjLAqbpSk0Yopm7NLrWoD1xu4VF7klTZNPWclJ7Pb0p9OlbPP1GhR+ZrNG8dvJTHnrWgia7lM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706303956; c=relaxed/simple; bh=QAmhzRN9Gx5RRTwBMINr0tSQKWvpM2+7nYt4uq/mnFU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GbZ0gkNuAakTO5zFMEbqFd0gnpDVSUZTr4Yu7yfyz0nAuYWy8ob/7tce4v0mlcSPNFNBGc9HgkOyJDFgm9j+zukUBK2ak93yYwGPA/It/qsSvBwWTM+T+mrORIiJqtYR9+0RbhgYBbd1z6377WIVrURm5c4uGcroXaiAgTrpeYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HtO1CxMm; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F4D9C433F1; Fri, 26 Jan 2024 21:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706303955; bh=QAmhzRN9Gx5RRTwBMINr0tSQKWvpM2+7nYt4uq/mnFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HtO1CxMm/dTj6BxsdRp2VlOcmN4qRo3PsXFYQywV8xlyPCpJzy+8A01s8s0vBpxHj VWlMKMvjTuXziTD4IfTEm862VYZOfPfZ16kI9/qgf/IgnJjmL+FMxdM0r95Q5ZI7O3 Pbk99uRXUn3FUGjqjSnWa+jWeaGep7Ipk5uwYM3PIsd77PhhNy8fO1Oc2bIZt0vYuH HX8P3PIIY2iNxwMfnjQVnk0sNqMSefKsYs5bEsT6L5GOMqWXO2TZg8qdvEulmBZMXX isyelBBpWE6Sr1rz7gTFVLAPKkzB/OAzN0Tquc9TwA6fIezfEqr7sryZtj/qyG2S4X MiYe/oVeKQTPQ== Date: Fri, 26 Jan 2024 21:19:09 +0000 From: Mark Brown To: Arnd Bergmann Cc: Sam Protsenko , Tudor Ambarus , Andi Shyti , Rob Herring , krzysztof.kozlowski+dt@linaro.org, Conor Dooley , Alim Akhtar , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux-Arch , =?iso-8859-1?Q?Andr=E9?= Draszik , Peter Griffin , kernel-team@android.com, William McVicker Subject: Re: [PATCH v2 23/28] spi: s3c64xx: retrieve the FIFO size from the device tree Message-ID: <0c4a90f0-b40e-41e8-8950-16863cbd4c07@sirena.org.uk> References: <20240125145007.748295-1-tudor.ambarus@linaro.org> <20240125145007.748295-24-tudor.ambarus@linaro.org> <1e117c5c-1e82-47ae-82f4-cdcf0a087f5f@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PNVF8uZx8MQjuD9w" Content-Disposition: inline In-Reply-To: X-Cookie: Excellent day to have a rotten day. --PNVF8uZx8MQjuD9w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 26, 2024 at 09:16:53PM +0100, Arnd Bergmann wrote: > That sounds like the same bug as in the serial port driver, > by assuming that the alias values in the devicetree have > a particular meaning in identifying instances. This immediately > breaks when there is a dtb file that does not use the same > alias values, e.g. because it only needs some of the SPI > ports. It'll be the result of a conversion from board files where that was a normal way of doing things. --PNVF8uZx8MQjuD9w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmW0IcwACgkQJNaLcl1U h9B/SAf/S9EZ2RMGzQoioDEZX27gnXJCqSurY1TDyT6aGYEKEfM95MwWi1cAiUI/ uBwUMJ3a3d2V+0vpL/xoXLpUYU/sr1CfbmvpE71M5U429GMemLZrzUqUFmWNfQYC kJgUakh6v9/Yzd6jGBD4oIU6XYtcfiX46m/qSeIuIde1miqRUeR/vlZpZ8264YEB q4xjWlNbErInSJa7bt/srm2e4OCrjlsM7UwRyeTUfRCZ6Mh20VsiCN9o7iwPAOjD hqOVvIdRQad2iIG/UXxv1Yrswy0/BN5urIpxolQmx1pxDFzTLdw7LSareKjBqUvI dgVm6/5De7gMVkQTciuwAtijMaT4bw== =U2OJ -----END PGP SIGNATURE----- --PNVF8uZx8MQjuD9w--