Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp880064rdb; Fri, 26 Jan 2024 13:53:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IHPF5SL/0LUXOeafdqn47HQfNeE453cmY0H+763Xgaae1nKXI2UwW0dInsuIi+JunEbD9XH X-Received: by 2002:a5d:456f:0:b0:33a:c4af:68f4 with SMTP id a15-20020a5d456f000000b0033ac4af68f4mr221213wrc.56.1706305990815; Fri, 26 Jan 2024 13:53:10 -0800 (PST) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id zn6-20020a170906ff0600b00a349982a383si1063988ejb.751.2024.01.26.13.53.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 13:53:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-40699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=LG52CtNc; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-40699-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-40699-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9072C1F21B5E for ; Fri, 26 Jan 2024 21:53:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6479250F6; Fri, 26 Jan 2024 21:52:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LG52CtNc" Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A051CD34; Fri, 26 Jan 2024 21:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706305978; cv=none; b=JluaPOS2k9V+flsqVM9zyWEkK7eOvMHrlWZxQU6jfUQMompfGQtlB48KkvsL3zzeN/zUUD2YUSkxUSZjhoUCNkhTP5TwIGN9ulvPz6AK3imKRZ2WyiwliRR40yG//ZDfb/blKejqf8V5QckoOi980mLUzlBcmNXEpPXuRRwNJOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706305978; c=relaxed/simple; bh=UiYEGeSKvmD1AptgnorZy5fQNkEfpWdosA24Vbe8h4k=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Mq05rMIYnxCE89wNBsqGTCY1lVd8m+1j5ZgbpPo8VeQbyIJohyLO9cSuxGzoEcXaOQSNl1w7qIiS7dpaYMRA/Rx3qjaTNnVWSDKZmdC3xFJMIL8KC69ngS9kH5wG58Oi70OH6kGiCmEU+M7Pf8Y4ce+4EMPhKAk7nuBzHVzUTiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LG52CtNc; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40eeadb7151so3351875e9.1; Fri, 26 Jan 2024 13:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706305974; x=1706910774; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PwCn1j7lcGKWVrBf99kL7TfgwgawY1TDNPn2McRxeCs=; b=LG52CtNcU7t9JG9W2hcxNLhAias7mth8QQwG13lLU/YxzyrVZbNMz7oCr4NuDHTs8D zwzGFHaycj0YurMsnOTBTRRT/90lEIhBqrMuajm0karAyVbN114tBRpkHVQMTZ+TToSn NUL5XgEAHZtcTQPXR0HlsJRXyC9eAstLP3DUAOMUT0DvnzcvN+oanPaFPNYjxdWGXXUo fhrhykqDi6c11ffWa6vRljPCCgSwRsEqIzOF22igRex6NncfZ2d0tpc8FDvYsXAsP2KQ XpTCc855Kk59k3lqXc7hZG3Fj/WiJkm4GcT3KngRmHhQ6FU+j/OXdZ858wgMjl/VMieK iMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706305974; x=1706910774; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PwCn1j7lcGKWVrBf99kL7TfgwgawY1TDNPn2McRxeCs=; b=mPiGBRuiLYr+KmnBalS7X8tahmVsVDgz4yHurwjt+P73oaWZyLjc2Lpg5ibb8sesuE mu8MvDn0UgaB802rlMm7bjnHUnFp2TyUH1O7DbvcllSxUiWimnsh0LzszqexM8/kQEKa TfoSaZbl6b0KVE3lsZcFFSCW7mHxsFCcShRLQlE4+bkoEGvwu5kBvTjCJB4tPercPdpv AKNx0yoF3bYKbWdDDHnjIIrT2lig3O7+Dq/CG9X7eToe2qAd1NCKR1OknmqbkOGh8M+c m/R0TIeOE0+vEHsIJQr7b2PDOHZtT49M7nDd8V2RHu9rXHisbm7boHVVVd+BmCU79APi ScGg== X-Gm-Message-State: AOJu0YwfGrevBBbYgllFcMJPi5y1FUObtrDnHIhzS0ojudBNyIo8zg5R F12/uB+weIUyWF+KRrs0dc7wBYi/DDVuWVyfzcGbOWx24oW6Rep+5UcrSXSUJUugf30V60FTQ7h mXfhn+czzXGbe4TQaSSKY0S4F0jA+TX9uQ3o= X-Received: by 2002:a05:600c:43c5:b0:40e:becd:d5eb with SMTP id f5-20020a05600c43c500b0040ebecdd5ebmr312299wmn.185.1706305974596; Fri, 26 Jan 2024 13:52:54 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240102-j7200-pcie-s2r-v2-0-8e4f7d228ec2@bootlin.com> <20240102-j7200-pcie-s2r-v2-14-8e4f7d228ec2@bootlin.com> In-Reply-To: <20240102-j7200-pcie-s2r-v2-14-8e4f7d228ec2@bootlin.com> From: Andy Shevchenko Date: Fri, 26 Jan 2024 23:52:18 +0200 Message-ID: Subject: Re: [PATCH v2 14/15] PCI: j721e: add reset GPIO to struct j721e_pcie To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Tom Joseph , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 26, 2024 at 4:38=E2=80=AFPM Thomas Richard wrote: > > From: Th=C3=A9o Lebrun > > Add reset GPIO to struct j721e_pcie, so it can be used at suspend and > resume stages. .. > + pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset"= , GPIOD_OUT_LOW); > + if (IS_ERR(pcie->reset_gpio)) { > + ret =3D PTR_ERR(pcie->reset_gpio); > if (ret !=3D -EPROBE_DEFER) > dev_err(dev, "Failed to get reset GPIO\n"= ); A side note: At some point would be nice to see this being changed to simpl= y ret =3D dev_err_probe(...); goto ...; > goto err_get_sync; --=20 With Best Regards, Andy Shevchenko