Received-SPF: pass (google.com: domain of linux-kernel+bounces-40726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH net] bnxt_en: Make PTP timestamp HWRM more silent
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <170630702464.26145.16441639508108329995.git-patchwork-notify@kernel.org>
Date: Fri, 26 Jan 2024 22:10:24 +0000
References: <20240125134104.2045573-1-leitao@debian.org>
In-Reply-To: <20240125134104.2045573-1-leitao@debian.org>
To: Breno Leitao <leitao@debian.org>
Cc: pavan.chebbi@broadcom.com, michael.chan@broadcom.com, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
 richardcochran@gmail.com, gospo@broadcom.com, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 25 Jan 2024 05:41:03 -0800 you wrote:
> commit 056bce63c469 ("bnxt_en: Make PTP TX timestamp HWRM query silent")
> changed a netdev_err() to netdev_WARN_ONCE().
> 
> netdev_WARN_ONCE() is it generates a kernel WARNING, which is bad, for
> the following reasons:
> 
>  * You do not a kernel warning if the firmware queries are late
>  * In busy networks, timestamp query failures fairly regularly
>  * A WARNING message doesn't bring much value, since the code path
> is clear.
> (This was discussed in-depth in [1])
> 
> [...]

Here is the summary with links:
  - [net] bnxt_en: Make PTP timestamp HWRM more silent
    https://git.kernel.org/netdev/net/c/281cb9d65a95

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html