Received-SPF: pass (google.com: domain of linux-kernel+bounces-40783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.80 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.80; helo=repost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
From: Sean Anderson <sean.anderson@seco.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sean Anderson <sean.anderson@seco.com>,
	stable@vger.kernel.org
Subject: [PATCH] usb: ulpi: Fix debugfs directory leak
Date: Fri, 26 Jan 2024 17:38:00 -0500
Message-Id: <20240126223800.2864613-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 YHHHImnzVxeQcuXI1jQ4/GSf/bEjoHQ8YptpxYD0L743zUBlWNO0/XukgHZCKTlwS5GdGwS8Kzim8hGzpnT2HPv8J3JCD4UOPq3hswPv0U+h7s+2Vi/+N0VkwdTZ26hY0Xg3ASPf3dPBC6HOHSuQbIuPNWonmrM/W8ouUumQm+EoC9uGwb+BPeLgf8vHM3WgIxzklPY0mnv7s4UzH1T2yiALfy07D3eKnyhdSJtAOhyERHUIX7i+xWKP7NUCC2Vtqxj6lGKjqMlK3LA3M4vAk0BbPAXP3nQ94Fjjs2bpW6k4MF1tZdtqz1IxfYYO79Lnx+LEUlVwGjAj3Aw5eKAXlpBG9JDi2kaZv4jr0GgtzWx4v2J7LhjOB2AtU1MNVItwcmkFhl0hnPRpQuN44LtVY7g9F6G8haWFbCTeJg7pe6qRUXgZEYS7vQpLOXQlEN3Ma2gihE3lag8wD78S3TJ46i+G9FOu7jO+4nf8OVWi5GadfIUwm0uFoKat9zSBH8K6lJMID5q2dU7PHjjZ048rZWsFvtc47gbhugcTtG7+QTYsOjYR66AuA7jHMXulLbfUpctugsKV0fVzZz+lVnSbiLdKC4lYMOteV20mlgeJhMacXr8hI0jRl2qbVMuDQOWX
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39850400004)(396003)(376002)(346002)(136003)(366004)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(86362001)(316002)(2616005)(83380400001)(6512007)(6506007)(66476007)(66946007)(54906003)(66556008)(44832011)(8936002)(8676002)(38100700002)(478600001)(6486002)(52116002)(26005)(1076003)(4326008)(6666004)(5660300002)(2906002)(38350700005)(41300700001)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7425
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB8EUR05FT061.eop-eur05.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	721fcd4f-30b9-4358-820f-08dc1ebf7bca
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2l3PxEBGzJSabtaQJ5LiltkkKOZAxDwSjIzUXSWjcAAAfraPCi+QD7G6rgRuHAAa8l6/ULgl4RSFx7uVl7Ds+Tae4GC8K6Gbv8w2j3wSJEFI5czpkAdIGXBMfJ7QoXzt4oA+HtEIwibuNbWV7l5lLYraS8J7VQFYMC7I+oWuCOeuDfdjsSSKiQKuah6xC99w14mXpm6P7RW6DGB0YQhSfFACZJDVaw6/8S/7QAB1xkCjqWgSO9mw6ev0yAYjAg0SALZx0s7YoyoQCOmlbhVWGvw9UY13lCJmxqcMRRMPPcKQr06BcEhVuhqI6DNljVZM4Yu2mh2cd7TuoEUUfDxIEIQmK7vA7fd8+UgVRn6UyQZmcT1Lk95gs6xyQMlT+kRArXPEWU2phW6UjXQBgTeGVKu6j6XWNChmBAU6GbFRePE8iU9i+yEP8zPm250BY8giRmJQEtFaqkAhExxJuNx1OG2d7wPotHN4LehoWqdkKi72qFh6pm84FEb/ZAdblblNwUt5oPIvSR4rJVotpUFl+pfwg0Bomx8up4VXKFfFf0Yly18Oy/7jzBzzFInRaoO+DoIbvzGfXx989XshahV4X0soXrMSXVZDr7453VIEtn1uE1isQNZ1qYxmGI/mYztIt//6RNsdY9hu5VeVrvB5zGpQ1FgYYsN7NlrZLdLhOCUG39lVxoiFUuWOkhztL7TqX9vR/XCFcGm0sDiUpsYTHKXE8S7KviIfAI1CV4yt7kaF+zojhxjyE9LQtOHNKWa0Gz3YQsHv8qcgMYIclazDQg==
X-Forefront-Antispam-Report:
	CIP:20.160.56.80;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(39850400004)(136003)(376002)(396003)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(82310400011)(36840700001)(46966006)(40470700004)(2906002)(36756003)(41300700001)(86362001)(83380400001)(70206006)(70586007)(316002)(54906003)(47076005)(478600001)(6512007)(40480700001)(40460700003)(6486002)(6666004)(6506007)(336012)(2616005)(1076003)(26005)(44832011)(34070700002)(5660300002)(356005)(7596003)(7636003)(82740400003)(8676002)(36860700001)(8936002)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 22:38:26.2473
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e6b47a90-49bb-42cd-c81c-08dc1ebf82e2
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.80];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB8EUR05FT061.eop-eur05.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7138

The ULPI per-device debugfs root is named after the ulpi device's
parent, but ulpi_unregister_interface tries to remove a debugfs
directory named after the ulpi device itself. This results in the
directory sticking around and preventing subsequent (deferred) probes
from succeeding. Change the directory name to match the ulpi device.

Fixes: bd0a0a024f2a ("usb: ulpi: Add debugfs support")
Cc: stable@vger.kernel.org
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

 drivers/usb/common/ulpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
index 84d91b1c1eed..0886b19d2e1c 100644
--- a/drivers/usb/common/ulpi.c
+++ b/drivers/usb/common/ulpi.c
@@ -301,7 +301,7 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi)
 		return ret;
 	}
 
-	root = debugfs_create_dir(dev_name(dev), ulpi_root);
+	root = debugfs_create_dir(dev_name(&ulpi->dev), ulpi_root);
 	debugfs_create_file("regs", 0444, root, ulpi, &ulpi_regs_fops);
 
 	dev_dbg(&ulpi->dev, "registered ULPI PHY: vendor %04x, product %04x\n",
-- 
2.35.1.1320.gc452695387.dirty