Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762327AbXLQX5c (ORCPT ); Mon, 17 Dec 2007 18:57:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760461AbXLQX5X (ORCPT ); Mon, 17 Dec 2007 18:57:23 -0500 Received: from gate.crashing.org ([63.228.1.57]:51869 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754582AbXLQX5W (ORCPT ); Mon, 17 Dec 2007 18:57:22 -0500 Subject: Re: [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Johannes Weiner Cc: linux-pci@atrey.karlin.mff.cuni.cz, Alan Cox , Greg Kroah-Hartman , jgarzik@pobox.com, Ivan Kokshaysky , wingel@nano-system.com, Bartlomiej Zolnierkiewicz , james.smart@emulex.com, linux-driver@qlogic.com, linux-kernel@vger.kernel.org In-Reply-To: References: <1197932473.576079.142524077033.qpush@grosgo> Content-Type: text/plain Date: Tue, 18 Dec 2007 10:55:36 +1100 Message-Id: <1197935736.13400.5.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 19 On Tue, 2007-12-18 at 00:49 +0100, Johannes Weiner wrote: > > These two functions should be refactored, the only difference is the > flag checking. Yeah, I somewhat though about it... anyway, it's not important right now, I'm waiting for feedback on the approach itself. I'll send a new patch with a nicer implementation later. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/