Received-SPF: pass (google.com: domain of linux-kernel+bounces-41035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 27 Jan 2024 03:21:09 +0000
To: tipc-discussion@lists.sourceforge.net
From: Carlos Ortiz <jmp0x29A@protonmail.com>
Cc: skhan@linuxfoundation.org, Carlos Ortiz <jmp0x29A@protonmail.com>, Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net/tipc: Remove Documentation Warnings for `Excess struct member`
Message-ID: <20240127032058.3030-1-jmp0x29A@protonmail.com>
Feedback-ID: 24524753:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="------8a7865ae482313782a62a2e5020667e351c62284c97e1e61b255d216c997144a"; charset=utf-8

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------8a7865ae482313782a62a2e5020667e351c62284c97e1e61b255d216c997144a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Carlos Ortiz <jmp0x29A@protonmail.com>
To: tipc-discussion@lists.sourceforge.net
Cc: skhan@linuxfoundation.org,
	Carlos Ortiz <jmp0x29A@protonmail.com>,
	Jon Maloy <jmaloy@redhat.com>,
	Ying Xue <ying.xue@windriver.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org (open list:TIPC NETWORK LAYER),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] net/tipc: Remove Documentation Warnings for `Excess struct member`
Date: Fri, 26 Jan 2024 21:20:56 -0600
Message-ID: <20240127032058.3030-1-jmp0x29A@protonmail.com>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0

As far as I can tell,the struct `inputq` and `namedq` were never part of the `tipc_node`,
therefor removing the documentation comments this will make the warnings for ./net/tipc/node.c when
running `make htmldocs` to be gone.

For socket.c, and documentation comment was added on commit 365ad353c2564bba8835290061308ba825166b3a
but the struct member was not added in addition of removing `blocking_link` also move `dupl_rcvcnt`
documentations a few lines up to match the struct member order.

Signed-off-by: Carlos Ortiz <jmp0x29A@protonmail.com>
---
 net/tipc/node.c   | 2 --
 net/tipc/socket.c | 3 +--
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index 3105abe97bb9..c1e890a82434 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -86,8 +86,6 @@ struct tipc_bclink_entry {
  * @lock: rwlock governing access to structure
  * @net: the applicable net namespace
  * @hash: links to adjacent nodes in unsorted hash chain
- *
 @inputq: pointer to input queue containing messages for msg event
- * @namedq: pointer to name table input queue with name table messages
  * @active_links: bearer ids of active links, used as index into links[] array
  * @links: array containing references to all links to node
  * @bc_entry: broadcast link entry
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index bb1118d02f95..a022719882ce 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -80,11 +80,10 @@ struct sockaddr_pair {
  * @phdr: preformatted message header used when sending messages
  * @cong_links: list of congested links
  * @publications: list of publications for port
- * @blocking_link: address of the congested link we are currently sleeping on
  * @pub_count: total # of publications port has made during its lifetime
+ * @dupl_rcvcnt: number of bytes counted twice, in both backlog and rcv queue
  * @conn_timeout: the time we can wait for an unresponded setup request
  * @probe_unacked: prob
e has not received ack yet
- * @dupl_rcvcnt: number of bytes counted twice, in both backlog and rcv queue
  * @cong_link_cnt: number of congested links
  * @snt_unacked: # messages sent by socket, and not yet acked by peer
  * @snd_win: send window size
-- 
2.43.0


--------8a7865ae482313782a62a2e5020667e351c62284c97e1e61b255d216c997144a
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wnUEARYIACcFAmW0dqQJEP/88erosmiBFiEEK5py9W+SnfjCVyLD//zx6uiy
aIEAAE3RAQDz1vnRwvq19AGgFyW2nVa6d0X9Nv5jXSb69oIW0An7EwEAujd9
ieOXKgSS2WIq3RyNkf+MmZc+8eEgsauBWE3nzgA=
=7v4p
-----END PGP SIGNATURE-----


--------8a7865ae482313782a62a2e5020667e351c62284c97e1e61b255d216c997144a--