Received: by 2002:a05:7412:9c07:b0:fa:6e18:a558 with SMTP id lr7csp87466rdb; Fri, 26 Jan 2024 20:44:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDxAuDxQJjyOtzTc/6Gn+XCvnfIwa2S5oAbvMN1ufgpG3NQ55kEN6XFvrYZvUwE5HSPtqc X-Received: by 2002:a17:906:4c52:b0:a35:48cb:20d6 with SMTP id d18-20020a1709064c5200b00a3548cb20d6mr145716ejw.13.1706330676316; Fri, 26 Jan 2024 20:44:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706330676; cv=pass; d=google.com; s=arc-20160816; b=WpKrCMzCh6nijUGj/pW52jhK6G2ypupDx7OV1cJX6oooMKzZV9pblm7pPmSE6LPEGm oreCrpqSGwzO9l3CXF9j1zfMcwjyLzqEwJ7Cuhr80OJYNJ3y4D6jjuJxLirjl07BKvxH l1p2pXfHSrRl4ptBFpkZ5S0pDh9sWVQPGC+XkrMAKLs/W0IMZrZYQ2gQHoPrNgDg851A p+aRIDVaPpoQruHPLtd3PW7rxfYSo2d2pouoCIxBWGARLGEjuaRIl9B+hF47ugN7MbLe UhzzarXDbJcw2KnqFJvSDB9dvdESRFxGihCCNVZ/hAjeHJ9EpIYpA9Y0SG9l8ZZYVD8v fJmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=s7jLR46gio3vZTab7LhK9Kly74f3LwWpXd4imPNlVOE=; fh=yJo69h2OxDIQQZb9FitpUMmtDSD5KuimY5NX2/8Xj0U=; b=loeeQg8b7d0oyEGsG5eBAkSdowkmf70+J/fGm4aJ8a9/FMBcD8vx26uAIBhcEMTwah hZN8kEA9yvvM7wG6YSRj+1LVHzGXxFCxIRC3ffnAp/8OrukR4UrpIQQE+HuTj0PQRmp5 ucwEXHSLD8pgUXPhMs7NVDLE/UuU2sxjopoKDSRSjmvgN/1xEffuhggmVS2o+zpQkcHb TMAJ6PZV8cDyAPFBuIYmtGfYh7Qkc89A0H+jXltFRHNDIeKY7rlBJyVes04ZmLidAd9G fspDr3lGTd6iCY9WVuUFw8s39yr+gPRIeCgi1D3b48a0CfGCMixXjknvVVrMaK639Ce0 EusQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S55sBXu6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-41062-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id lc7-20020a170906dfe700b00a31069ef7ffsi1332435ejc.258.2024.01.26.20.44.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 20:44:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-41062-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S55sBXu6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-41062-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-41062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 090BE1F241B5 for ; Sat, 27 Jan 2024 04:44:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D40BB13AF9; Sat, 27 Jan 2024 04:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S55sBXu6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0558311CAF; Sat, 27 Jan 2024 04:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706330665; cv=none; b=H4WHhdPODo+gd0QNh6fqdFl53RKDqrH0Bf1HOjxtKPZ63pSXqbh+RNZgjqhqj6TwlfTDwkck400THWzhED2rAC6YnbipZA5+9f/gdGJkQgOodRcQNZREsCIWfieLXhlp9IE9dILeKMMD0kb3Efc/AMlZX6/8lv3J6RVQN5NSce4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706330665; c=relaxed/simple; bh=EEVrPSo++7IeRvcKVZvtophgR0qotpsnHk5/F/gDV48=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I1cC5vCoYOIsH0mFPMX19gj1R7rt/PgeUhckw+efpiz+pz7vm5wB3DWDQ5MSVLpKW3jIZZ1dWlOqKrZz2K6Ov5Kj0NULOO2XOJTxlHsJiA2IrgDkRyabcviz4h1MfpnZXSmJzTOpqVwUSQK++iQz+Ui92FHRXymlVMISB/Wf6IQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S55sBXu6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 168CBC433F1; Sat, 27 Jan 2024 04:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706330664; bh=EEVrPSo++7IeRvcKVZvtophgR0qotpsnHk5/F/gDV48=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S55sBXu6TUvYGGufO1tVf8KqBEjEXUI2su1UTJtcQpFr9zgF6U1HVdAQ16Mj6BH3Y tYmBQ0qQ6EtAJTCYYMSI26IvkMFyCHiWZXE/FQ74GaK3mWAIqgtFU82FcBtudv9l8m xW9Mlr+ur7Gob7zP1S2ZEwZ4u7fWUYW1bLPnJeCxv7TKRL4nqr5xR/rIwhRyw77Nu9 pYrNBBHD5IXo0MCpxtm15jr2LaYDaerW+jg5A+JtoK9Y4xTRy264Su6SRO6ogGQ2Fz zm10OvKmTJ8TxX0Flu5QqOTGzuvVpV5I9yuD98n5zM1aOaZmzhuccyWI05T8bctQTS iXSKqcrtuZfqg== Date: Fri, 26 Jan 2024 20:44:23 -0800 From: Jakub Kicinski To: Brett Creeley Cc: , , , , , Subject: Re: [PATCH v2 net-next 0/10] pds_core: Various improvements and AQ race condition cleanup Message-ID: <20240126204423.47c20ef6@kernel.org> In-Reply-To: <20240126174255.17052-1-brett.creeley@amd.com> References: <20240126174255.17052-1-brett.creeley@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 26 Jan 2024 09:42:45 -0800 Brett Creeley wrote: > This series includes the following changes: > > There can be many users of the pds_core's adminq. This includes > pds_core's uses and any clients that depend on it. When the pds_core > device goes through a reset for any reason the adminq is freed > and reconfigured. There are some gaps in the current implementation > that will cause crashes during reset if any of the previously mentioned > users of the adminq attempt to use it after it's been freed. > > Issues around how resets are handled, specifically regarding the driver's > error handlers. Patches 1, 2 and 4 look like fixes. Is there any reason these are targeting net-next? If someone deploys this device at scale rare things will happen a lot..