Received-SPF: pass (google.com: domain of linux-kernel+bounces-41044-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <501aa5d8-9376-4479-b3d1-18f3b92898c2@infradead.org>
Date: Fri, 26 Jan 2024 19:44:40 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net/tipc: Remove Documentation Warnings for `Excess
 struct member`
Content-Language: en-US
To: Carlos Ortiz <jmp0x29A@protonmail.com>,
 tipc-discussion@lists.sourceforge.net
Cc: skhan@linuxfoundation.org, Jon Maloy <jmaloy@redhat.com>,
 Ying Xue <ying.xue@windriver.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240127032058.3030-1-jmp0x29A@protonmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240127032058.3030-1-jmp0x29A@protonmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 1/26/24 19:21, Carlos Ortiz wrote:
> As far as I can tell,the struct `inputq` and `namedq` were never part of the `tipc_node`,
> therefor removing the documentation comments this will make the warnings for ./net/tipc/node.c when
> running `make htmldocs` to be gone.
> 
> For socket.c, and documentation comment was added on commit 365ad353c2564bba8835290061308ba825166b3a
> but the struct member was not added in addition of removing `blocking_link` also move `dupl_rcvcnt`
> documentations a few lines up to match the struct member order.
> 
> Signed-off-by: Carlos Ortiz <jmp0x29A@protonmail.com>
> ---
>  net/tipc/node.c   | 2 --
>  net/tipc/socket.c | 3 +--
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 

Hi,
These are already fixed (recently), but Thanks.

https://lore.kernel.org/netdev/170614862613.13756.7070098094645334807.git-patchwork-notify@kernel.org/
https://lore.kernel.org/netdev/170614862616.13756.18046951576152774345.git-patchwork-notify@kernel.org/
-- 
#Randy