Received-SPF: pass (google.com: domain of linux-kernel+bounces-41081-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <472d92aa-1b49-43c9-a91f-80dfc8f25ad3@oracle.com>
Date: Sat, 27 Jan 2024 12:12:20 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/2] smb: client: fix "df: Resource temporarily
 unavailable" on 5.10 stable kernel
Content-Language: en-US
To: kovalev@altlinux.org, Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org,
        samba-technical@lists.samba.org, keescook@chromium.org,
        sfrench@samba.org, corbet@lwn.net, natechancellor@gmail.com,
        ndesaulniers@google.com, "pc@manguebit.com" <pc@manguebit.com>,
        "Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com>,
        Shyam Prasad N <nspmangalore@gmail.com>,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Darren Kenny <darren.kenny@oracle.com>
References: <20240126193143.245122-1-kovalev@altlinux.org>
 <2024012613-woozy-exhume-7b9d@gregkh>
From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <2024012613-woozy-exhume-7b9d@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?THdoRlBZWHJ1NVExaVJxUHlOUi9QZWVpaEN4cUdXSTdiK25WUlNrbzJLNDNM?=
 =?utf-8?B?cXlrV29kRTRHdVQ3dHdXM1hOZ082eWkrQnU1aVFsemhJQzBKbWMyUVVBb09h?=
 =?utf-8?B?MmF1R1VNRVBDKzdQNFlZbmtMNk5xWDR4Q3JTMVZFTmw2NVR3MXdlby8weVhL?=
 =?utf-8?B?UHFTdVJFdmRoejhCRnhLcG5MblV2NnJNUHVKN1prbWdNRU1sdVBQVUFIZlYz?=
 =?utf-8?B?NWwvdUlOY21MK0t0MmxLak1WQzlmR3BsVmgwc0JRY1BLYlB1eUJXSWQ1UXNB?=
 =?utf-8?B?WkIweCs0UDNPY0dGclR2ODBhWERvYno0bDl6bFNzQzVsUGk0KzMxVXV3QU05?=
 =?utf-8?B?cHdqT0tJSVBXSVpHWlZBa0J5OEM5YzQ1UXU3SzIrYTdxcEg4djJVQUVwQnpR?=
 =?utf-8?B?UlhCSkV0UnRhc3U1L3MzbnRRV3F4dkQ2T3RyYUNYOUF2SnZLa1Uzb1BMMEFo?=
 =?utf-8?B?UDJLTEd6Y09jSzB3ZTBCNXRaOVZaenNxQlg4OTRtb1VQOFNlU0RlL0ZxL25p?=
 =?utf-8?B?MmNOVW1weW5TMVBsdkRzV20rQkdCMlVPV2RwdjUyTG91TXMydGtPSjZsdDd3?=
 =?utf-8?B?dkVrMU03YW9mRWJDbnJrRW5YbW1pZ0lUeGR5ejVkblZlOHZhdGRBd0pnRlhk?=
 =?utf-8?B?V1hNeG1TdGZJUzFLOUorVzBVZzVXSlIrTzF1WnN3QU1tZW4rUkJuZFFZcm9r?=
 =?utf-8?B?RUR2OVJhZUNoRmhTVzV0ajFxQm5SQnRmNHJVWlpqWlN4bjkwUzNlQ0Z1MVlr?=
 =?utf-8?B?ajZDZHArWHY4Zm9LWUVoUDZkdG9BY3JVWmRsQ0ZMdmxRZlhYeVFXeXVJNUl1?=
 =?utf-8?B?YS9pQkpYUmJpdlpxTFNXU3BRZkpsajNLN1JjRkNLMlRTazFDTzB1cU5xak1a?=
 =?utf-8?B?clBKalc3Q0g5SjVJVnk1SlFWZDk4VzZFc0tjR01iTkxaTDdpQXgxSTBNYUNN?=
 =?utf-8?B?SDdOS2krOHJNejNsOFZ3RDlma0F5VUNMYUFpQTE2Uno5TndUeFNXRW45NUps?=
 =?utf-8?B?azFPZXA3Nm9Xb0U2S2Z1a2RHSnIxUysyUWRxTEdTOHFmTTBkZURqeEFTRlh5?=
 =?utf-8?B?dWNKc294di9tcVJSOE9DendwNDNFY1hLcStvVGJQUGFlQTFuNVZjamd1TWxV?=
 =?utf-8?B?R0dtaVRmVURQaFIyQmxhbkd3MXdVb01peENjSGpnM3pkYWI1N2dFRjl3Q3Nm?=
 =?utf-8?B?T3FtRFQ3ZGMyL21LdXVSRzk4MGh6bTNVY3dCZTIvdkVSQ2owZGF5ZUZXc0cv?=
 =?utf-8?B?K3M3amVkNnJ4dWxPa2ZwbHJWRU80MFR2ZS9QYXU3cHRZWFNCVWlJVS9PN1Mw?=
 =?utf-8?B?MGlOQjVDM1JocGs1UE1VdTVHMTY5enROaFZQYTUrUk9UZnE3S1B0VVRFbmhK?=
 =?utf-8?B?N3NpZ1FZS25UU21odlZKMFJmMmRKakF3T0JkTk1udGJEcDdiaXdPbXN2MDVU?=
 =?utf-8?B?M0VDU0k4ZUFKeXFLV3FFS1NTOVVVOWU4ZnlZT21PUDY0M09pc0lPYlgxLytD?=
 =?utf-8?B?ZlphZWFUZ0Q3Yy9zSUtCN3RvSGpyQjRhdkt6RnB1aG1hTlYydk4rWTROVCtO?=
 =?utf-8?B?d09jSGxKTThjVDJhUnUzcW9wcnpGalNpamcrZm5ZSG9ybWtaZzg3R1lvT29k?=
 =?utf-8?B?SVpiWTFDWVJqSFU5b0IwYjltcllDNW1XNndMSFo3a1JZK1MxaUt4dzNXaVBk?=
 =?utf-8?B?MXZnT3VBY0VKSU10K2N1bWFNeHh5dXY5ai9VWWVVeDUzQ2tBU3htT29LNGdx?=
 =?utf-8?B?c3hqMkdHUHoxSnp2QnlzcW9qSWdRaTBiNldkb0RxMG1HbGpheTNRekJLU2d6?=
 =?utf-8?B?aDJGWSs0QmtMUW5BeERGVmZoNm5GL0tTR2VnQ3NyUjB0YVd2dHRhbWNHRTl6?=
 =?utf-8?B?S2dtS1RIU1JQNjV5K3Z5Tm1VL0gxZUdIR0RnVWZla1l5eXVpd2ZvYng5bk05?=
 =?utf-8?B?ZUpkMkZqdjZJV1RObEVIVlF0R09yWlNDMGl3Z1UrVEFMVlM5SjJtN05sOGFF?=
 =?utf-8?B?QnJTY0VRSE92SlhDU09JdExMdUlHaFdRQXREdUUzRTdmZkhXd2hjTCs3WWE2?=
 =?utf-8?B?WmVHdzl6S0RqR2NXR3BBSW1GbUdOSTY5WkhhdHFNZTNDUVpWQ0JubDlYRm9T?=
 =?utf-8?B?cGFBRy9CN0dWZnJlRXBZTmtWb1lmZkNpb2ZhaWZmeGV2TDhkUzlSUDh3Y0t6?=
 =?utf-8?Q?C98gRWb6tZBHTzFNIX1kEnU=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	aVYW3lWYmQpseIuVfbO3IKhmLXhecZf+uOyVpd944QiWJGeyHauuZI59Vay4QiDuSFOLaL6so88ikvjV4GKbgPptCs++AImXGxL9jau9n8W3fHyG45trN095ixl3mWJAFMVVEDmHO6+++L9lCXejb4UGhCai4eQHOvyTWsL56ffQSxG3bVHeFED7pvJL5nHcId99Z0hy3O2kr6tXQGdHhQ9mmwrr7ObERFbsYrN/d05qetEUYDyLAaSBWiusqrILGQuDKhgZK7Dm4WX5AOv2oZ7+JgmHXfjNczZMClBs4FN/8KYOBH7/xBzzf/oE5G6HZHiTtfizZs/Bk45IoWS56mZ70gD29tvTErRZBq6XHDY4DyPFrB2RjaTA9pKgIQ3+s5tpGlQBgBYqZZuaqB4u9C20ydYLVv6BWDz1F5IKdLQk+/nWwv1set2Rzg66THG6U161eDLm5VwOS6C5P39qJe4at2JUj0bZvAqSp4ETujSLE63ujCp8O4XYBur79aXnFjtfnOar88JUFnAnYZe15opI28qotKtrWeyl17PLqGeUTrwMXhYGJl3dbV/krb0jxsBcv+003tb9JbE1iAvnCDsZGfQSuTgNtMHxxjl7cDA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ace35667-5308-4f13-0cf1-08dc1f032223
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2024 06:42:30.0688
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z/TkUi02sigyCjjJs/Eyggr8cuajUZQJL//fY43RCgsjQKhIbq1BJazNrsTUsYwXZoon/GBbaLrHjzMtmDgfKv4oaZN9jBrgmLopRP//VrAKdCFt0LPgxyLzEuLMRSRD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7051
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 mlxlogscore=999 spamscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401270049
X-Proofpoint-ORIG-GUID: 7VnGMP38MIj9s6Zg7Ep3dbdHgUBE0llq
X-Proofpoint-GUID: 7VnGMP38MIj9s6Zg7Ep3dbdHgUBE0llq

Hi,

Adding more people to CC.(who have looked at this issue)

On 27/01/24 6:19 am, Greg KH wrote:
> On Fri, Jan 26, 2024 at 10:31:41PM +0300, kovalev@altlinux.org wrote:
>> After mounting a remote cifs resource, it becomes unavailable:
>> df: /mnt/sambashare: Resource temporarily unavailable
>>
>> It was tested on the following Linux kernels:
>> Linux altlinux 5.10.208-std-def-alt1
>> Linux fedora 5.10.208-200.el8.x86_64
>>
>> The error appeared starting from kernel 5.10.206 after adding
>> the commit [1] "smb: client: fix OOB in SMB2_query_info_init()",
>> in which the buffer length increases by 1 as a result of changes:
>> ...
>> -      iov[0].iov_len = total_len - 1 + input_len;
>> +      iov[0].iov_len = len;
>> ...
>>

We can reproduce this on 5.15.148(latest 5.15.y) and Mohamed reported 
this on 6.1.y, so we need backports there as well.

https://lore.kernel.org/all/09738f0f-53a2-43f1-a09d-a2bef48e1344@oracle.com/


[root@vm1 xfstests-dev]# ./check -g quick -s smb3
TEST_DEV=//<SERVER_IP>/TEST is mounted but not a type cifs filesystem
[root@vm1 xfstests-dev]# df
df: /mnt/test: Resource temporarily unavailable


This two patch series doesn't cleanly apply to 5.15.y.

Also I am unsure, which is the better approach to go with

Approach 1 - suggested by Paulo:
https://lore.kernel.org/all/446860c571d0699ed664175262a9e84b@manguebit.com/

Approach 2 - this series
Pulling in [PATCH 2/2] smb3: Replace smb2pdu 1-element arrays with 
flex-arrays like this series did.

I think approach 1 is better as the changes are minimal, but please 
correct me if that seems wrong.

Thanks,
Harshit
>> [1] https://patchwork.kernel.org/project/cifs-client/patch/20231213152557.6634-2-pc@manguebit.com/
>>
>> Error fixed by backported commits in next two patches  adapted for the 5.10 kernel:
>>
>> [PATCH 1/2] stddef: Introduce DECLARE_FLEX_ARRAY() helper
>> [PATCH 2/2] smb3: Replace smb2pdu 1-element arrays with flex-arrays
>>
>>
> 
> Now queued up, thanks.
> 
> greg k-h
>